2017-02-07 11:47:55 +00:00
// Copyright 2017 The Gitea Authors. All rights reserved.
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.
package models
import (
2021-03-18 06:06:40 +00:00
"fmt"
2017-02-07 11:47:55 +00:00
"reflect"
2021-03-18 06:06:40 +00:00
"regexp"
2017-02-28 01:42:10 +00:00
"strings"
2017-02-07 11:47:55 +00:00
"testing"
2021-03-18 06:06:40 +00:00
"code.gitea.io/gitea/modules/setting"
2017-02-07 11:47:55 +00:00
"github.com/stretchr/testify/assert"
2020-05-29 13:24:15 +00:00
"xorm.io/builder"
2017-02-07 11:47:55 +00:00
)
2017-05-20 08:48:22 +00:00
// consistencyCheckable a type that can be tested for database consistency
type consistencyCheckable interface {
checkForConsistency ( t * testing . T )
2017-02-07 11:47:55 +00:00
}
// CheckConsistencyForAll test that the entire database is consistent
func CheckConsistencyForAll ( t * testing . T ) {
CheckConsistencyFor ( t ,
& User { } ,
& Repository { } ,
& Issue { } ,
& PullRequest { } ,
& Milestone { } ,
& Label { } ,
2017-02-28 01:42:10 +00:00
& Team { } ,
& Action { } )
2017-02-07 11:47:55 +00:00
}
// CheckConsistencyFor test that all matching database entries are consistent
func CheckConsistencyFor ( t * testing . T , beansToCheck ... interface { } ) {
for _ , bean := range beansToCheck {
sliceType := reflect . SliceOf ( reflect . TypeOf ( bean ) )
sliceValue := reflect . MakeSlice ( sliceType , 0 , 10 )
ptrToSliceValue := reflect . New ( sliceType )
ptrToSliceValue . Elem ( ) . Set ( sliceValue )
2019-06-23 15:22:43 +00:00
assert . NoError ( t , x . Table ( bean ) . Find ( ptrToSliceValue . Interface ( ) ) )
2017-02-07 11:47:55 +00:00
sliceValue = ptrToSliceValue . Elem ( )
for i := 0 ; i < sliceValue . Len ( ) ; i ++ {
entity := sliceValue . Index ( i ) . Interface ( )
2017-05-20 08:48:22 +00:00
checkable , ok := entity . ( consistencyCheckable )
2017-02-07 11:47:55 +00:00
if ! ok {
t . Errorf ( "Expected %+v (of type %T) to be checkable for consistency" ,
entity , entity )
} else {
2017-05-20 08:48:22 +00:00
checkable . checkForConsistency ( t )
2017-02-07 11:47:55 +00:00
}
}
}
}
// getCount get the count of database entries matching bean
func getCount ( t * testing . T , e Engine , bean interface { } ) int64 {
count , err := e . Count ( bean )
assert . NoError ( t , err )
return count
}
// assertCount test the count of database entries matching bean
func assertCount ( t * testing . T , bean interface { } , expected int ) {
assert . EqualValues ( t , expected , getCount ( t , x , bean ) ,
"Failed consistency test, the counted bean (of type %T) was %+v" , bean , bean )
}
2017-05-20 08:48:22 +00:00
func ( user * User ) checkForConsistency ( t * testing . T ) {
2017-02-07 11:47:55 +00:00
assertCount ( t , & Repository { OwnerID : user . ID } , user . NumRepos )
assertCount ( t , & Star { UID : user . ID } , user . NumStars )
assertCount ( t , & OrgUser { OrgID : user . ID } , user . NumMembers )
assertCount ( t , & Team { OrgID : user . ID } , user . NumTeams )
assertCount ( t , & Follow { UserID : user . ID } , user . NumFollowing )
assertCount ( t , & Follow { FollowID : user . ID } , user . NumFollowers )
2017-02-08 06:29:21 +00:00
if user . Type != UserTypeOrganization {
assert . EqualValues ( t , 0 , user . NumMembers )
assert . EqualValues ( t , 0 , user . NumTeams )
}
2017-02-07 11:47:55 +00:00
}
2017-05-20 08:48:22 +00:00
func ( repo * Repository ) checkForConsistency ( t * testing . T ) {
2017-02-28 01:42:10 +00:00
assert . Equal ( t , repo . LowerName , strings . ToLower ( repo . Name ) , "repo: %+v" , repo )
2017-02-07 11:47:55 +00:00
assertCount ( t , & Star { RepoID : repo . ID } , repo . NumStars )
assertCount ( t , & Milestone { RepoID : repo . ID } , repo . NumMilestones )
assertCount ( t , & Repository { ForkID : repo . ID } , repo . NumForks )
if repo . IsFork {
AssertExistsAndLoadBean ( t , & Repository { ID : repo . ForkID } )
}
2019-11-10 09:22:19 +00:00
actual := getCount ( t , x . Where ( "Mode<>?" , RepoWatchModeDont ) , & Watch { RepoID : repo . ID } )
assert . EqualValues ( t , repo . NumWatches , actual ,
"Unexpected number of watches for repo %+v" , repo )
actual = getCount ( t , x . Where ( "is_pull=?" , false ) , & Issue { RepoID : repo . ID } )
2017-02-08 06:29:21 +00:00
assert . EqualValues ( t , repo . NumIssues , actual ,
"Unexpected number of issues for repo %+v" , repo )
actual = getCount ( t , x . Where ( "is_pull=? AND is_closed=?" , false , true ) , & Issue { RepoID : repo . ID } )
2017-02-07 11:47:55 +00:00
assert . EqualValues ( t , repo . NumClosedIssues , actual ,
"Unexpected number of closed issues for repo %+v" , repo )
2017-02-08 06:29:21 +00:00
actual = getCount ( t , x . Where ( "is_pull=?" , true ) , & Issue { RepoID : repo . ID } )
2017-02-07 11:47:55 +00:00
assert . EqualValues ( t , repo . NumPulls , actual ,
"Unexpected number of pulls for repo %+v" , repo )
2017-02-08 06:29:21 +00:00
actual = getCount ( t , x . Where ( "is_pull=? AND is_closed=?" , true , true ) , & Issue { RepoID : repo . ID } )
2017-02-07 11:47:55 +00:00
assert . EqualValues ( t , repo . NumClosedPulls , actual ,
"Unexpected number of closed pulls for repo %+v" , repo )
2017-02-08 06:29:21 +00:00
actual = getCount ( t , x . Where ( "is_closed=?" , true ) , & Milestone { RepoID : repo . ID } )
2017-02-07 11:47:55 +00:00
assert . EqualValues ( t , repo . NumClosedMilestones , actual ,
"Unexpected number of closed milestones for repo %+v" , repo )
}
2017-05-20 08:48:22 +00:00
func ( issue * Issue ) checkForConsistency ( t * testing . T ) {
2017-02-08 06:29:21 +00:00
actual := getCount ( t , x . Where ( "type=?" , CommentTypeComment ) , & Comment { IssueID : issue . ID } )
assert . EqualValues ( t , issue . NumComments , actual ,
"Unexpected number of comments for issue %+v" , issue )
2017-02-07 11:47:55 +00:00
if issue . IsPull {
pr := AssertExistsAndLoadBean ( t , & PullRequest { IssueID : issue . ID } ) . ( * PullRequest )
assert . EqualValues ( t , pr . Index , issue . Index )
}
}
2017-05-20 08:48:22 +00:00
func ( pr * PullRequest ) checkForConsistency ( t * testing . T ) {
2017-02-07 11:47:55 +00:00
issue := AssertExistsAndLoadBean ( t , & Issue { ID : pr . IssueID } ) . ( * Issue )
assert . True ( t , issue . IsPull )
assert . EqualValues ( t , issue . Index , pr . Index )
}
2017-05-20 08:48:22 +00:00
func ( milestone * Milestone ) checkForConsistency ( t * testing . T ) {
2017-02-07 11:47:55 +00:00
assertCount ( t , & Issue { MilestoneID : milestone . ID } , milestone . NumIssues )
2017-02-08 06:29:21 +00:00
actual := getCount ( t , x . Where ( "is_closed=?" , true ) , & Issue { MilestoneID : milestone . ID } )
2017-02-07 11:47:55 +00:00
assert . EqualValues ( t , milestone . NumClosedIssues , actual ,
"Unexpected number of closed issues for milestone %+v" , milestone )
2021-06-21 18:34:58 +00:00
completeness := 0
if milestone . NumIssues > 0 {
completeness = milestone . NumClosedIssues * 100 / milestone . NumIssues
}
assert . Equal ( t , completeness , milestone . Completeness )
2017-02-07 11:47:55 +00:00
}
2017-05-20 08:48:22 +00:00
func ( label * Label ) checkForConsistency ( t * testing . T ) {
2017-02-07 11:47:55 +00:00
issueLabels := make ( [ ] * IssueLabel , 0 , 10 )
assert . NoError ( t , x . Find ( & issueLabels , & IssueLabel { LabelID : label . ID } ) )
assert . EqualValues ( t , label . NumIssues , len ( issueLabels ) ,
"Unexpected number of issue for label %+v" , label )
issueIDs := make ( [ ] int64 , len ( issueLabels ) )
for i , issueLabel := range issueLabels {
issueIDs [ i ] = issueLabel . IssueID
}
expected := int64 ( 0 )
if len ( issueIDs ) > 0 {
2017-02-08 06:29:21 +00:00
expected = getCount ( t , x . In ( "id" , issueIDs ) . Where ( "is_closed=?" , true ) , & Issue { } )
2017-02-07 11:47:55 +00:00
}
assert . EqualValues ( t , expected , label . NumClosedIssues ,
"Unexpected number of closed issues for label %+v" , label )
}
2017-05-20 08:48:22 +00:00
func ( team * Team ) checkForConsistency ( t * testing . T ) {
2017-02-07 11:47:55 +00:00
assertCount ( t , & TeamUser { TeamID : team . ID } , team . NumMembers )
assertCount ( t , & TeamRepo { TeamID : team . ID } , team . NumRepos )
}
2017-02-28 01:42:10 +00:00
2017-05-20 08:48:22 +00:00
func ( action * Action ) checkForConsistency ( t * testing . T ) {
2017-02-28 01:42:10 +00:00
repo := AssertExistsAndLoadBean ( t , & Repository { ID : action . RepoID } ) . ( * Repository )
assert . Equal ( t , repo . IsPrivate , action . IsPrivate , "action: %+v" , action )
}
2020-05-29 13:24:15 +00:00
// CountOrphanedLabels return count of labels witch are broken and not accessible via ui anymore
func CountOrphanedLabels ( ) ( int64 , error ) {
noref , err := x . Table ( "label" ) . Where ( "repo_id=? AND org_id=?" , 0 , 0 ) . Count ( "label.id" )
if err != nil {
return 0 , err
}
norepo , err := x . Table ( "label" ) .
2021-06-08 04:36:23 +00:00
Where ( builder . And (
builder . Gt { "repo_id" : 0 } ,
builder . NotIn ( "repo_id" , builder . Select ( "id" ) . From ( "repository" ) ) ,
) ) .
Count ( )
2020-05-29 13:24:15 +00:00
if err != nil {
return 0 , err
}
noorg , err := x . Table ( "label" ) .
2021-06-08 04:36:23 +00:00
Where ( builder . And (
builder . Gt { "org_id" : 0 } ,
builder . NotIn ( "org_id" , builder . Select ( "id" ) . From ( "user" ) ) ,
) ) .
Count ( )
2020-05-29 13:24:15 +00:00
if err != nil {
return 0 , err
}
return noref + norepo + noorg , nil
}
// DeleteOrphanedLabels delete labels witch are broken and not accessible via ui anymore
func DeleteOrphanedLabels ( ) error {
// delete labels with no reference
if _ , err := x . Table ( "label" ) . Where ( "repo_id=? AND org_id=?" , 0 , 0 ) . Delete ( new ( Label ) ) ; err != nil {
return err
}
// delete labels with none existing repos
2021-06-08 04:36:23 +00:00
if _ , err := x .
Where ( builder . And (
builder . Gt { "repo_id" : 0 } ,
builder . NotIn ( "repo_id" , builder . Select ( "id" ) . From ( "repository" ) ) ,
) ) .
2020-05-29 13:24:15 +00:00
Delete ( Label { } ) ; err != nil {
return err
}
// delete labels with none existing orgs
2021-06-08 04:36:23 +00:00
if _ , err := x .
Where ( builder . And (
builder . Gt { "org_id" : 0 } ,
builder . NotIn ( "org_id" , builder . Select ( "id" ) . From ( "user" ) ) ,
) ) .
2020-05-29 13:24:15 +00:00
Delete ( Label { } ) ; err != nil {
return err
}
return nil
}
2021-03-19 19:01:24 +00:00
// CountOrphanedIssueLabels return count of IssueLabels witch have no label behind anymore
func CountOrphanedIssueLabels ( ) ( int64 , error ) {
return x . Table ( "issue_label" ) .
2021-06-08 04:36:23 +00:00
NotIn ( "label_id" , builder . Select ( "id" ) . From ( "label" ) ) .
Count ( )
2021-03-19 19:01:24 +00:00
}
// DeleteOrphanedIssueLabels delete IssueLabels witch have no label behind anymore
func DeleteOrphanedIssueLabels ( ) error {
2021-06-08 04:36:23 +00:00
_ , err := x .
NotIn ( "label_id" , builder . Select ( "id" ) . From ( "label" ) ) .
2021-03-19 19:01:24 +00:00
Delete ( IssueLabel { } )
return err
}
2020-05-29 13:24:15 +00:00
// CountOrphanedIssues count issues without a repo
func CountOrphanedIssues ( ) ( int64 , error ) {
return x . Table ( "issue" ) .
Join ( "LEFT" , "repository" , "issue.repo_id=repository.id" ) .
Where ( builder . IsNull { "repository.id" } ) .
Count ( "id" )
}
// DeleteOrphanedIssues delete issues without a repo
func DeleteOrphanedIssues ( ) error {
sess := x . NewSession ( )
defer sess . Close ( )
if err := sess . Begin ( ) ; err != nil {
return err
}
var ids [ ] int64
if err := sess . Table ( "issue" ) . Distinct ( "issue.repo_id" ) .
Join ( "LEFT" , "repository" , "issue.repo_id=repository.id" ) .
Where ( builder . IsNull { "repository.id" } ) . GroupBy ( "issue.repo_id" ) .
Find ( & ids ) ; err != nil {
return err
}
var attachmentPaths [ ] string
for i := range ids {
paths , err := deleteIssuesByRepoID ( sess , ids [ i ] )
if err != nil {
return err
}
attachmentPaths = append ( attachmentPaths , paths ... )
}
if err := sess . Commit ( ) ; err != nil {
return err
}
// Remove issue attachment files.
for i := range attachmentPaths {
removeAllWithNotice ( x , "Delete issue attachment" , attachmentPaths [ i ] )
}
return nil
}
// CountOrphanedObjects count subjects with have no existing refobject anymore
func CountOrphanedObjects ( subject , refobject , joinCond string ) ( int64 , error ) {
return x . Table ( "`" + subject + "`" ) .
Join ( "LEFT" , refobject , joinCond ) .
Where ( builder . IsNull { "`" + refobject + "`.id" } ) .
Count ( "id" )
}
// DeleteOrphanedObjects delete subjects with have no existing refobject anymore
func DeleteOrphanedObjects ( subject , refobject , joinCond string ) error {
2021-04-30 18:08:46 +00:00
subQuery := builder . Select ( "`" + subject + "`.id" ) .
2020-05-29 13:24:15 +00:00
From ( "`" + subject + "`" ) .
Join ( "LEFT" , "`" + refobject + "`" , joinCond ) .
2021-04-30 18:08:46 +00:00
Where ( builder . IsNull { "`" + refobject + "`.id" } )
sql , args , err := builder . Delete ( builder . In ( "id" , subQuery ) ) . From ( "`" + subject + "`" ) . ToSQL ( )
if err != nil {
return err
}
_ , err = x . Exec ( append ( [ ] interface { } { sql } , args ... ) ... )
2020-05-29 13:24:15 +00:00
return err
}
2020-06-11 20:18:11 +00:00
// CountNullArchivedRepository counts the number of repositories with is_archived is null
func CountNullArchivedRepository ( ) ( int64 , error ) {
return x . Where ( builder . IsNull { "is_archived" } ) . Count ( new ( Repository ) )
}
// FixNullArchivedRepository sets is_archived to false where it is null
func FixNullArchivedRepository ( ) ( int64 , error ) {
2021-01-29 18:30:43 +00:00
return x . Where ( builder . IsNull { "is_archived" } ) . Cols ( "is_archived" ) . NoAutoTime ( ) . Update ( & Repository {
2020-06-11 20:18:11 +00:00
IsArchived : false ,
} )
}
2021-01-29 18:30:43 +00:00
// CountWrongUserType count OrgUser who have wrong type
func CountWrongUserType ( ) ( int64 , error ) {
return x . Where ( builder . Eq { "type" : 0 } . And ( builder . Neq { "num_teams" : 0 } ) ) . Count ( new ( User ) )
}
// FixWrongUserType fix OrgUser who have wrong type
func FixWrongUserType ( ) ( int64 , error ) {
return x . Where ( builder . Eq { "type" : 0 } . And ( builder . Neq { "num_teams" : 0 } ) ) . Cols ( "type" ) . NoAutoTime ( ) . Update ( & User { Type : 1 } )
}
2021-02-10 02:50:44 +00:00
// CountCommentTypeLabelWithEmptyLabel count label comments with empty label
func CountCommentTypeLabelWithEmptyLabel ( ) ( int64 , error ) {
return x . Where ( builder . Eq { "type" : CommentTypeLabel , "label_id" : 0 } ) . Count ( new ( Comment ) )
}
// FixCommentTypeLabelWithEmptyLabel count label comments with empty label
func FixCommentTypeLabelWithEmptyLabel ( ) ( int64 , error ) {
return x . Where ( builder . Eq { "type" : CommentTypeLabel , "label_id" : 0 } ) . Delete ( new ( Comment ) )
}
2021-03-18 06:06:40 +00:00
2021-03-19 13:25:14 +00:00
// CountCommentTypeLabelWithOutsideLabels count label comments with outside label
func CountCommentTypeLabelWithOutsideLabels ( ) ( int64 , error ) {
2021-03-23 23:10:19 +00:00
return x . Where ( "comment.type = ? AND ((label.org_id = 0 AND issue.repo_id != label.repo_id) OR (label.repo_id = 0 AND label.org_id != repository.owner_id))" , CommentTypeLabel ) .
2021-03-19 13:25:14 +00:00
Table ( "comment" ) .
Join ( "inner" , "label" , "label.id = comment.label_id" ) .
Join ( "inner" , "issue" , "issue.id = comment.issue_id " ) .
Join ( "inner" , "repository" , "issue.repo_id = repository.id" ) .
Count ( new ( Comment ) )
}
// FixCommentTypeLabelWithOutsideLabels count label comments with outside label
func FixCommentTypeLabelWithOutsideLabels ( ) ( int64 , error ) {
res , err := x . Exec ( ` DELETE FROM comment WHERE comment . id IN (
SELECT il_too . id FROM (
SELECT com . id
FROM comment AS com
INNER JOIN label ON com . label_id = label . id
INNER JOIN issue on issue . id = com . issue_id
2021-03-23 23:10:19 +00:00
INNER JOIN repository ON issue . repo_id = repository . id
2021-03-19 13:25:14 +00:00
WHERE
2021-03-23 23:10:19 +00:00
com . type = ? AND ( ( label . org_id = 0 AND issue . repo_id != label . repo_id ) OR ( label . repo_id = 0 AND label . org_id != repository . owner_id ) )
2021-03-19 13:25:14 +00:00
) AS il_too ) ` , CommentTypeLabel )
if err != nil {
return 0 , err
}
return res . RowsAffected ( )
}
// CountIssueLabelWithOutsideLabels count label comments with outside label
func CountIssueLabelWithOutsideLabels ( ) ( int64 , error ) {
2021-03-23 23:10:19 +00:00
return x . Where ( builder . Expr ( "(label.org_id = 0 AND issue.repo_id != label.repo_id) OR (label.repo_id = 0 AND label.org_id != repository.owner_id)" ) ) .
2021-03-19 13:25:14 +00:00
Table ( "issue_label" ) .
2021-03-23 10:23:33 +00:00
Join ( "inner" , "label" , "issue_label.label_id = label.id " ) .
2021-03-19 13:25:14 +00:00
Join ( "inner" , "issue" , "issue.id = issue_label.issue_id " ) .
Join ( "inner" , "repository" , "issue.repo_id = repository.id" ) .
Count ( new ( IssueLabel ) )
}
// FixIssueLabelWithOutsideLabels fix label comments with outside label
func FixIssueLabelWithOutsideLabels ( ) ( int64 , error ) {
res , err := x . Exec ( ` DELETE FROM issue_label WHERE issue_label . id IN (
SELECT il_too . id FROM (
SELECT il_too_too . id
FROM issue_label AS il_too_too
2021-03-22 18:26:38 +00:00
INNER JOIN label ON il_too_too . label_id = label . id
2021-03-19 13:25:14 +00:00
INNER JOIN issue on issue . id = il_too_too . issue_id
INNER JOIN repository on repository . id = issue . repo_id
WHERE
2021-03-23 23:10:19 +00:00
( label . org_id = 0 AND issue . repo_id != label . repo_id ) OR ( label . repo_id = 0 AND label . org_id != repository . owner_id )
2021-03-19 13:25:14 +00:00
) AS il_too ) ` )
if err != nil {
return 0 , err
}
return res . RowsAffected ( )
}
2021-03-18 06:06:40 +00:00
// CountBadSequences looks for broken sequences from recreate-table mistakes
func CountBadSequences ( ) ( int64 , error ) {
if ! setting . Database . UsePostgreSQL {
return 0 , nil
}
sess := x . NewSession ( )
defer sess . Close ( )
var sequences [ ] string
schema := sess . Engine ( ) . Dialect ( ) . URI ( ) . Schema
sess . Engine ( ) . SetSchema ( "" )
if err := sess . Table ( "information_schema.sequences" ) . Cols ( "sequence_name" ) . Where ( "sequence_name LIKE 'tmp_recreate__%_id_seq%' AND sequence_catalog = ?" , setting . Database . Name ) . Find ( & sequences ) ; err != nil {
return 0 , err
}
sess . Engine ( ) . SetSchema ( schema )
return int64 ( len ( sequences ) ) , nil
}
// FixBadSequences fixes for broken sequences from recreate-table mistakes
func FixBadSequences ( ) error {
if ! setting . Database . UsePostgreSQL {
return nil
}
sess := x . NewSession ( )
defer sess . Close ( )
if err := sess . Begin ( ) ; err != nil {
return err
}
var sequences [ ] string
schema := sess . Engine ( ) . Dialect ( ) . URI ( ) . Schema
sess . Engine ( ) . SetSchema ( "" )
if err := sess . Table ( "information_schema.sequences" ) . Cols ( "sequence_name" ) . Where ( "sequence_name LIKE 'tmp_recreate__%_id_seq%' AND sequence_catalog = ?" , setting . Database . Name ) . Find ( & sequences ) ; err != nil {
return err
}
sess . Engine ( ) . SetSchema ( schema )
sequenceRegexp := regexp . MustCompile ( ` tmp_recreate__(\w+)_id_seq.* ` )
for _ , sequence := range sequences {
tableName := sequenceRegexp . FindStringSubmatch ( sequence ) [ 1 ]
newSequenceName := tableName + "_id_seq"
if _ , err := sess . Exec ( fmt . Sprintf ( "ALTER SEQUENCE `%s` RENAME TO `%s`" , sequence , newSequenceName ) ) ; err != nil {
return err
}
if _ , err := sess . Exec ( fmt . Sprintf ( "SELECT setval('%s', COALESCE((SELECT MAX(id)+1 FROM `%s`), 1), false)" , newSequenceName , tableName ) ) ; err != nil {
return err
}
}
return sess . Commit ( )
}