2014-09-25 23:33:39 +00:00
|
|
|
{{range .Feeds}}
|
2015-12-07 22:30:52 +00:00
|
|
|
<div class="news">
|
|
|
|
|
<div class="ui left">
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 13:37:34 +00:00
|
|
|
{{avatarByAction $.Context .}}
|
2015-12-07 22:30:52 +00:00
|
|
|
</div>
|
|
|
|
|
<div class="ui grid">
|
2019-02-02 12:44:33 +00:00
|
|
|
<div class="ui fourteen wide column">
|
2018-09-07 02:06:09 +00:00
|
|
|
<div class="{{if or (eq .GetOpType 5) (eq .GetOpType 18)}}push news{{end}}">
|
2015-12-07 22:30:52 +00:00
|
|
|
<p>
|
2019-03-27 22:22:39 +00:00
|
|
|
{{if gt .ActUser.ID 0}}
|
2021-11-16 18:18:25 +00:00
|
|
|
<a href="{{AppSubUrl}}/{{.GetActUserName | PathEscape}}" title="{{.GetDisplayNameTitle}}">{{.GetDisplayName}}</a>
|
2019-03-27 22:22:39 +00:00
|
|
|
{{else}}
|
|
|
|
|
{{.ShortActUserName}}
|
|
|
|
|
{{end}}
|
2015-12-07 22:30:52 +00:00
|
|
|
{{if eq .GetOpType 1}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.create_repo" (.GetRepoLink|Escape) (.ShortRepoPath|Escape) | Str2html}}
|
2015-12-07 22:30:52 +00:00
|
|
|
{{else if eq .GetOpType 2}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.rename_repo" (.GetContent|Escape) (.GetRepoLink|Escape) (.ShortRepoPath|Escape) | Str2html}}
|
2015-12-07 22:30:52 +00:00
|
|
|
{{else if eq .GetOpType 5}}
|
2021-01-04 16:51:00 +00:00
|
|
|
{{if .Content}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.commit_repo" (.GetRepoLink|Escape) (.GetRefLink|Escape) (Escape .GetBranch) (.ShortRepoPath|Escape) | Str2html}}
|
2021-01-04 16:51:00 +00:00
|
|
|
{{else}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.create_branch" (.GetRepoLink|Escape) (.GetRefLink|Escape) (Escape .GetBranch) (.ShortRepoPath|Escape) | Str2html}}
|
2021-01-04 16:51:00 +00:00
|
|
|
{{end}}
|
2015-12-07 22:30:52 +00:00
|
|
|
{{else if eq .GetOpType 6}}
|
2022-08-31 15:58:54 +00:00
|
|
|
{{$index := index .GetIssueInfos 0}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.create_issue" ((printf "%s/issues/%s" .GetRepoLink $index) |Escape) $index (.ShortRepoPath|Escape) | Str2html}}
|
2015-12-07 22:30:52 +00:00
|
|
|
{{else if eq .GetOpType 7}}
|
2022-08-31 15:58:54 +00:00
|
|
|
{{$index := index .GetIssueInfos 0}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.create_pull_request" ((printf "%s/pulls/%s" .GetRepoLink $index) |Escape) $index (.ShortRepoPath|Escape) | Str2html}}
|
2015-12-07 22:30:52 +00:00
|
|
|
{{else if eq .GetOpType 8}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.transfer_repo" .GetContent (.GetRepoLink|Escape) (.ShortRepoPath|Escape) | Str2html}}
|
2015-12-07 22:30:52 +00:00
|
|
|
{{else if eq .GetOpType 9}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.push_tag" (.GetRepoLink|Escape) (.GetRefLink|Escape) (.GetTag|Escape) (.ShortRepoPath|Escape) | Str2html}}
|
2015-12-07 22:30:52 +00:00
|
|
|
{{else if eq .GetOpType 10}}
|
2022-08-31 15:58:54 +00:00
|
|
|
{{$index := index .GetIssueInfos 0}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.comment_issue" ((printf "%s/issues/%s" .GetRepoLink $index) |Escape) $index (.ShortRepoPath|Escape) | Str2html}}
|
2015-12-07 22:30:52 +00:00
|
|
|
{{else if eq .GetOpType 11}}
|
2022-08-31 15:58:54 +00:00
|
|
|
{{$index := index .GetIssueInfos 0}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.merge_pull_request" ((printf "%s/pulls/%s" .GetRepoLink $index) |Escape) $index (.ShortRepoPath|Escape) | Str2html}}
|
2016-02-22 17:40:00 +00:00
|
|
|
{{else if eq .GetOpType 12}}
|
2022-08-31 15:58:54 +00:00
|
|
|
{{$index := index .GetIssueInfos 0}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.close_issue" ((printf "%s/issues/%s" .GetRepoLink $index) |Escape) $index (.ShortRepoPath|Escape) | Str2html}}
|
2016-02-22 17:40:00 +00:00
|
|
|
{{else if eq .GetOpType 13}}
|
2022-08-31 15:58:54 +00:00
|
|
|
{{$index := index .GetIssueInfos 0}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.reopen_issue" ((printf "%s/issues/%s" .GetRepoLink $index) |Escape) $index (.ShortRepoPath|Escape) | Str2html}}
|
2016-03-05 17:58:51 +00:00
|
|
|
{{else if eq .GetOpType 14}}
|
2022-08-31 15:58:54 +00:00
|
|
|
{{$index := index .GetIssueInfos 0}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.close_pull_request" ((printf "%s/pulls/%s" .GetRepoLink $index) |Escape) $index (.ShortRepoPath|Escape) | Str2html}}
|
2016-03-05 17:58:51 +00:00
|
|
|
{{else if eq .GetOpType 15}}
|
2022-08-31 15:58:54 +00:00
|
|
|
{{$index := index .GetIssueInfos 0}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.reopen_pull_request" ((printf "%s/pulls/%s" .GetRepoLink $index) |Escape) $index (.ShortRepoPath|Escape) | Str2html}}
|
2017-09-21 07:43:26 +00:00
|
|
|
{{else if eq .GetOpType 16}}
|
2022-08-31 15:58:54 +00:00
|
|
|
{{$index := index .GetIssueInfos 0}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.delete_tag" (.GetRepoLink|Escape) (.GetTag|Escape) (.ShortRepoPath|Escape) | Str2html}}
|
2017-09-21 07:43:26 +00:00
|
|
|
{{else if eq .GetOpType 17}}
|
2022-08-31 15:58:54 +00:00
|
|
|
{{$index := index .GetIssueInfos 0}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.delete_branch" (.GetRepoLink|Escape) (.GetBranch|Escape) (.ShortRepoPath|Escape) | Str2html}}
|
2018-09-07 02:06:09 +00:00
|
|
|
{{else if eq .GetOpType 18}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.mirror_sync_push" (.GetRepoLink|Escape) (.GetRefLink|Escape) (.GetBranch|Escape) (.ShortRepoPath|Escape) | Str2html}}
|
2018-09-07 02:06:09 +00:00
|
|
|
{{else if eq .GetOpType 19}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.mirror_sync_create" (.GetRepoLink|Escape) (.GetRefLink|Escape) (.GetBranch|Escape) (.ShortRepoPath|Escape) | Str2html}}
|
2018-09-07 02:06:09 +00:00
|
|
|
{{else if eq .GetOpType 20}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.mirror_sync_delete" (.GetRepoLink|Escape) (.GetBranch|Escape) (.ShortRepoPath|Escape) | Str2html}}
|
2019-11-14 23:52:18 +00:00
|
|
|
{{else if eq .GetOpType 21}}
|
2022-08-31 15:58:54 +00:00
|
|
|
{{$index := index .GetIssueInfos 0}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.approve_pull_request" ((printf "%s/pulls/%s" .GetRepoLink $index) |Escape) $index (.ShortRepoPath|Escape) | Str2html}}
|
2019-11-14 23:52:18 +00:00
|
|
|
{{else if eq .GetOpType 22}}
|
2022-08-31 15:58:54 +00:00
|
|
|
{{$index := index .GetIssueInfos 0}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.reject_pull_request" ((printf "%s/pulls/%s" .GetRepoLink $index) |Escape) $index (.ShortRepoPath|Escape) | Str2html}}
|
2019-12-22 08:29:26 +00:00
|
|
|
{{else if eq .GetOpType 23}}
|
2022-08-31 15:58:54 +00:00
|
|
|
{{$index := index .GetIssueInfos 0}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.comment_pull" ((printf "%s/pulls/%s" .GetRepoLink $index) |Escape) $index (.ShortRepoPath|Escape) | Str2html}}
|
2020-07-29 19:20:54 +00:00
|
|
|
{{else if eq .GetOpType 24}}
|
2023-03-05 21:59:05 +00:00
|
|
|
{{$linkText := .Content | RenderEmoji $.Context}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.publish_release" (.GetRepoLink|Escape) ((printf "%s/releases/tag/%s" .GetRepoLink .GetTag)|Escape) (.ShortRepoPath|Escape) $linkText | Str2html}}
|
2021-02-11 17:32:25 +00:00
|
|
|
{{else if eq .GetOpType 25}}
|
2022-08-31 15:58:54 +00:00
|
|
|
{{$index := index .GetIssueInfos 0}}
|
|
|
|
|
{{$reviewer := index .GetIssueInfos 1}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{$.locale.Tr "action.review_dismissed" ((printf "%s/pulls/%s" .GetRepoLink $index) |Escape) $index (.ShortRepoPath|Escape) $reviewer | Str2html}}
|
2015-12-07 22:30:52 +00:00
|
|
|
{{end}}
|
|
|
|
|
</p>
|
2018-09-07 02:06:09 +00:00
|
|
|
{{if or (eq .GetOpType 5) (eq .GetOpType 18)}}
|
2015-12-07 22:30:52 +00:00
|
|
|
<div class="content">
|
|
|
|
|
<ul>
|
2022-08-31 15:58:54 +00:00
|
|
|
{{$push := ActionContent2Commits .}}
|
|
|
|
|
{{$repoLink := .GetRepoLink}}
|
2021-08-09 18:08:51 +00:00
|
|
|
{{range $push.Commits}}
|
2022-08-31 15:58:54 +00:00
|
|
|
{{$commitLink := printf "%s/commit/%s" $repoLink .Sha1}}
|
2021-08-09 18:08:51 +00:00
|
|
|
<li>
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 13:37:34 +00:00
|
|
|
{{avatarHTML ($push.AvatarLink $.Context .AuthorEmail) 16 "gt-mr-2" .AuthorName}}
|
2023-02-13 17:59:59 +00:00
|
|
|
<a class="commit-id gt-mr-2" href="{{$commitLink}}">{{ShortSha .Sha1}}</a>
|
2021-08-09 18:08:51 +00:00
|
|
|
<span class="text truncate light grey">
|
2022-01-19 23:26:57 +00:00
|
|
|
{{RenderCommitMessage $.Context .Message $repoLink $.ComposeMetas}}
|
2021-08-09 18:08:51 +00:00
|
|
|
</span>
|
|
|
|
|
</li>
|
2015-12-07 22:30:52 +00:00
|
|
|
{{end}}
|
2022-06-27 20:58:46 +00:00
|
|
|
{{if and (gt $push.Len 1) $push.CompareURL}}<li><a href="{{AppSubUrl}}/{{$push.CompareURL}}">{{$.locale.Tr "action.compare_commits" $push.Len}} »</a></li>{{end}}
|
2015-12-07 22:30:52 +00:00
|
|
|
</ul>
|
|
|
|
|
</div>
|
|
|
|
|
{{else if eq .GetOpType 6}}
|
2023-03-05 21:59:05 +00:00
|
|
|
<span class="text truncate issue title">{{index .GetIssueInfos 1 | RenderEmoji $.Context | RenderCodeBlock}}</span>
|
2015-12-07 22:30:52 +00:00
|
|
|
{{else if eq .GetOpType 7}}
|
2023-03-05 21:59:05 +00:00
|
|
|
<span class="text truncate issue title">{{index .GetIssueInfos 1 | RenderEmoji $.Context | RenderCodeBlock}}</span>
|
2019-12-22 08:29:26 +00:00
|
|
|
{{else if or (eq .GetOpType 10) (eq .GetOpType 21) (eq .GetOpType 22) (eq .GetOpType 23)}}
|
2023-03-05 21:59:05 +00:00
|
|
|
<a href="{{.GetCommentLink}}" class="text truncate issue title">{{.GetIssueTitle | RenderEmoji $.Context | RenderCodeBlock}}</a>
|
2021-03-06 04:09:49 +00:00
|
|
|
{{$comment := index .GetIssueInfos 1}}
|
2023-03-05 21:59:05 +00:00
|
|
|
{{if gt (len $comment) 0}}<p class="text light grey">{{$comment | RenderEmoji $.Context}}</p>{{end}}
|
2015-12-07 22:30:52 +00:00
|
|
|
{{else if eq .GetOpType 11}}
|
2020-04-28 18:05:39 +00:00
|
|
|
<p class="text light grey">{{index .GetIssueInfos 1}}</p>
|
2020-04-16 21:26:24 +00:00
|
|
|
{{else if or (eq .GetOpType 12) (eq .GetOpType 13) (eq .GetOpType 14) (eq .GetOpType 15)}}
|
2023-03-05 21:59:05 +00:00
|
|
|
<span class="text truncate issue title">{{.GetIssueTitle | RenderEmoji $.Context | RenderCodeBlock}}</span>
|
2021-02-11 17:32:25 +00:00
|
|
|
{{else if eq .GetOpType 25}}
|
2022-06-27 20:58:46 +00:00
|
|
|
<p class="text light grey">{{$.locale.Tr "action.review_dismissed_reason"}}</p>
|
2023-03-05 21:59:05 +00:00
|
|
|
<p class="text light grey">{{index .GetIssueInfos 2 | RenderEmoji $.Context}}</p>
|
2015-12-07 22:30:52 +00:00
|
|
|
{{end}}
|
2022-06-27 20:58:46 +00:00
|
|
|
<p class="text italic light grey">{{TimeSince .GetCreate $.locale}}</p>
|
2015-12-07 22:30:52 +00:00
|
|
|
</div>
|
|
|
|
|
</div>
|
2019-02-02 12:44:33 +00:00
|
|
|
<div class="ui two wide right aligned column">
|
2020-02-11 17:02:41 +00:00
|
|
|
<span class="text grey">{{svg (printf "octicon-%s" (ActionIcon .GetOpType)) 32}}</span>
|
2015-12-07 22:30:52 +00:00
|
|
|
</div>
|
|
|
|
|
</div>
|
|
|
|
|
<div class="ui divider"></div>
|
|
|
|
|
</div>
|
|
|
|
|
{{end}}
|
2023-02-24 21:15:10 +00:00
|
|
|
|
|
|
|
|
{{template "base/paginate" .}}
|
