2020-01-07 18:27:36 +00:00
|
|
|
// Copyright 2015 The Gogs Authors. All rights reserved.
|
|
|
|
// Copyright 2019 The Gitea Authors. All rights reserved.
|
2022-11-27 18:20:29 +00:00
|
|
|
// SPDX-License-Identifier: MIT
|
2020-01-07 18:27:36 +00:00
|
|
|
|
|
|
|
package wiki
|
|
|
|
|
|
|
|
import (
|
2022-01-19 23:26:57 +00:00
|
|
|
"context"
|
2024-03-06 06:26:32 +00:00
|
|
|
"errors"
|
2020-01-07 18:27:36 +00:00
|
|
|
"fmt"
|
|
|
|
"os"
|
|
|
|
"strings"
|
|
|
|
|
2024-03-06 06:26:32 +00:00
|
|
|
"code.gitea.io/gitea/models/db"
|
2021-12-10 01:27:50 +00:00
|
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
2022-10-16 23:29:26 +00:00
|
|
|
system_model "code.gitea.io/gitea/models/system"
|
2021-11-09 19:57:58 +00:00
|
|
|
"code.gitea.io/gitea/models/unit"
|
2021-11-24 09:49:20 +00:00
|
|
|
user_model "code.gitea.io/gitea/models/user"
|
2020-01-07 18:27:36 +00:00
|
|
|
"code.gitea.io/gitea/modules/git"
|
2024-03-06 06:26:32 +00:00
|
|
|
"code.gitea.io/gitea/modules/gitrepo"
|
2024-09-06 10:12:41 +00:00
|
|
|
"code.gitea.io/gitea/modules/globallock"
|
2020-01-07 18:27:36 +00:00
|
|
|
"code.gitea.io/gitea/modules/log"
|
2020-01-20 20:01:19 +00:00
|
|
|
repo_module "code.gitea.io/gitea/modules/repository"
|
2024-03-06 06:26:32 +00:00
|
|
|
"code.gitea.io/gitea/modules/util"
|
2021-12-10 08:14:24 +00:00
|
|
|
asymkey_service "code.gitea.io/gitea/services/asymkey"
|
2024-01-12 21:50:38 +00:00
|
|
|
repo_service "code.gitea.io/gitea/services/repository"
|
2020-01-07 18:27:36 +00:00
|
|
|
)
|
|
|
|
|
2024-03-06 06:26:32 +00:00
|
|
|
const DefaultRemote = "origin"
|
2022-10-15 14:40:32 +00:00
|
|
|
|
2024-09-06 10:12:41 +00:00
|
|
|
func getWikiWorkingLockKey(repoID int64) string {
|
|
|
|
return fmt.Sprintf("wiki_working_%d", repoID)
|
|
|
|
}
|
|
|
|
|
2020-01-07 18:27:36 +00:00
|
|
|
// InitWiki initializes a wiki for repository,
|
|
|
|
// it does nothing when repository already has wiki.
|
2022-01-19 23:26:57 +00:00
|
|
|
func InitWiki(ctx context.Context, repo *repo_model.Repository) error {
|
2020-01-07 18:27:36 +00:00
|
|
|
if repo.HasWiki() {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2023-12-17 11:56:08 +00:00
|
|
|
if err := git.InitRepository(ctx, repo.WikiPath(), true, repo.ObjectFormatName); err != nil {
|
2022-10-24 19:29:17 +00:00
|
|
|
return fmt.Errorf("InitRepository: %w", err)
|
2020-01-20 20:01:19 +00:00
|
|
|
} else if err = repo_module.CreateDelegateHooks(repo.WikiPath()); err != nil {
|
2022-10-24 19:29:17 +00:00
|
|
|
return fmt.Errorf("createDelegateHooks: %w", err)
|
2024-03-06 06:26:32 +00:00
|
|
|
} else if _, _, err = git.NewCommand(ctx, "symbolic-ref", "HEAD").AddDynamicArguments(git.BranchPrefix + repo.DefaultWikiBranch).RunStdString(&git.RunOpts{Dir: repo.WikiPath()}); err != nil {
|
|
|
|
return fmt.Errorf("unable to set default wiki branch to %q: %w", repo.DefaultWikiBranch, err)
|
2020-01-07 18:27:36 +00:00
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2023-04-19 17:50:10 +00:00
|
|
|
// prepareGitPath try to find a suitable file path with file name by the given raw wiki name.
|
2021-07-07 23:23:09 +00:00
|
|
|
// return: existence, prepared file path with name, error
|
2024-03-06 06:26:32 +00:00
|
|
|
func prepareGitPath(gitRepo *git.Repository, defaultWikiBranch string, wikiPath WebPath) (bool, string, error) {
|
2023-04-19 17:50:10 +00:00
|
|
|
unescaped := string(wikiPath) + ".md"
|
|
|
|
gitPath := WebPathToGitPath(wikiPath)
|
2021-07-07 23:23:09 +00:00
|
|
|
|
|
|
|
// Look for both files
|
2024-03-06 06:26:32 +00:00
|
|
|
filesInIndex, err := gitRepo.LsTree(defaultWikiBranch, unescaped, gitPath)
|
2021-07-07 23:23:09 +00:00
|
|
|
if err != nil {
|
2024-03-06 06:26:32 +00:00
|
|
|
if strings.Contains(err.Error(), "Not a valid object name") {
|
|
|
|
return false, gitPath, nil // branch doesn't exist
|
2021-08-01 17:04:32 +00:00
|
|
|
}
|
2024-03-06 06:26:32 +00:00
|
|
|
log.Error("Wiki LsTree failed, err: %v", err)
|
2023-04-19 17:50:10 +00:00
|
|
|
return false, gitPath, err
|
2021-07-07 23:23:09 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
foundEscaped := false
|
|
|
|
for _, filename := range filesInIndex {
|
|
|
|
switch filename {
|
|
|
|
case unescaped:
|
|
|
|
// if we find the unescaped file return it
|
|
|
|
return true, unescaped, nil
|
2023-04-19 17:50:10 +00:00
|
|
|
case gitPath:
|
2021-07-07 23:23:09 +00:00
|
|
|
foundEscaped = true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// If not return whether the escaped file exists, and the escaped filename to keep backwards compatibility.
|
2023-04-19 17:50:10 +00:00
|
|
|
return foundEscaped, gitPath, nil
|
2021-07-07 23:23:09 +00:00
|
|
|
}
|
|
|
|
|
2022-09-04 19:54:23 +00:00
|
|
|
// updateWikiPage adds a new page or edits an existing page in repository wiki.
|
2023-04-19 17:50:10 +00:00
|
|
|
func updateWikiPage(ctx context.Context, doer *user_model.User, repo *repo_model.Repository, oldWikiName, newWikiName WebPath, content, message string, isNew bool) (err error) {
|
2023-09-21 23:43:29 +00:00
|
|
|
err = repo.MustNotBeArchived()
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2023-04-19 17:50:10 +00:00
|
|
|
if err = validateWebPath(newWikiName); err != nil {
|
2020-01-07 18:27:36 +00:00
|
|
|
return err
|
|
|
|
}
|
2024-09-06 10:12:41 +00:00
|
|
|
releaser, err := globallock.Lock(ctx, getWikiWorkingLockKey(repo.ID))
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
defer releaser()
|
2020-01-07 18:27:36 +00:00
|
|
|
|
2022-01-19 23:26:57 +00:00
|
|
|
if err = InitWiki(ctx, repo); err != nil {
|
2022-10-24 19:29:17 +00:00
|
|
|
return fmt.Errorf("InitWiki: %w", err)
|
2020-01-07 18:27:36 +00:00
|
|
|
}
|
|
|
|
|
2024-03-06 06:26:32 +00:00
|
|
|
hasDefaultBranch := git.IsBranchExist(ctx, repo.WikiPath(), repo.DefaultWikiBranch)
|
2020-01-07 18:27:36 +00:00
|
|
|
|
2022-05-08 16:46:32 +00:00
|
|
|
basePath, err := repo_module.CreateTemporaryPath("update-wiki")
|
2020-01-07 18:27:36 +00:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
defer func() {
|
2022-05-08 16:46:32 +00:00
|
|
|
if err := repo_module.RemoveTemporaryPath(basePath); err != nil {
|
2020-01-07 18:27:36 +00:00
|
|
|
log.Error("Merge: RemoveTemporaryPath: %s", err)
|
|
|
|
}
|
|
|
|
}()
|
|
|
|
|
|
|
|
cloneOpts := git.CloneRepoOptions{
|
|
|
|
Bare: true,
|
|
|
|
Shared: true,
|
|
|
|
}
|
|
|
|
|
2024-03-06 06:26:32 +00:00
|
|
|
if hasDefaultBranch {
|
|
|
|
cloneOpts.Branch = repo.DefaultWikiBranch
|
2020-01-07 18:27:36 +00:00
|
|
|
}
|
|
|
|
|
2022-01-19 23:26:57 +00:00
|
|
|
if err := git.Clone(ctx, repo.WikiPath(), basePath, cloneOpts); err != nil {
|
2020-01-07 18:27:36 +00:00
|
|
|
log.Error("Failed to clone repository: %s (%v)", repo.FullName(), err)
|
2023-04-19 17:50:10 +00:00
|
|
|
return fmt.Errorf("failed to clone repository: %s (%w)", repo.FullName(), err)
|
2020-01-07 18:27:36 +00:00
|
|
|
}
|
|
|
|
|
2022-03-29 19:13:41 +00:00
|
|
|
gitRepo, err := git.OpenRepository(ctx, basePath)
|
2020-01-07 18:27:36 +00:00
|
|
|
if err != nil {
|
|
|
|
log.Error("Unable to open temporary repository: %s (%v)", basePath, err)
|
2023-04-19 17:50:10 +00:00
|
|
|
return fmt.Errorf("failed to open new temporary repository in: %s %w", basePath, err)
|
2020-01-07 18:27:36 +00:00
|
|
|
}
|
|
|
|
defer gitRepo.Close()
|
|
|
|
|
2024-03-06 06:26:32 +00:00
|
|
|
if hasDefaultBranch {
|
2020-01-07 18:27:36 +00:00
|
|
|
if err := gitRepo.ReadTreeToIndex("HEAD"); err != nil {
|
|
|
|
log.Error("Unable to read HEAD tree to index in: %s %v", basePath, err)
|
2023-04-19 17:50:10 +00:00
|
|
|
return fmt.Errorf("fnable to read HEAD tree to index in: %s %w", basePath, err)
|
2020-01-07 18:27:36 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-03-06 06:26:32 +00:00
|
|
|
isWikiExist, newWikiPath, err := prepareGitPath(gitRepo, repo.DefaultWikiBranch, newWikiName)
|
2021-07-07 23:23:09 +00:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2020-01-07 18:27:36 +00:00
|
|
|
if isNew {
|
2021-07-07 23:23:09 +00:00
|
|
|
if isWikiExist {
|
2022-08-25 02:31:57 +00:00
|
|
|
return repo_model.ErrWikiAlreadyExist{
|
2020-01-07 18:27:36 +00:00
|
|
|
Title: newWikiPath,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
} else {
|
2021-07-07 23:23:09 +00:00
|
|
|
// avoid check existence again if wiki name is not changed since gitRepo.LsFiles(...) is not free.
|
|
|
|
isOldWikiExist := true
|
|
|
|
oldWikiPath := newWikiPath
|
|
|
|
if oldWikiName != newWikiName {
|
2024-03-06 06:26:32 +00:00
|
|
|
isOldWikiExist, oldWikiPath, err = prepareGitPath(gitRepo, repo.DefaultWikiBranch, oldWikiName)
|
2021-07-07 23:23:09 +00:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
2020-01-07 18:27:36 +00:00
|
|
|
}
|
|
|
|
|
2021-07-07 23:23:09 +00:00
|
|
|
if isOldWikiExist {
|
2020-01-07 18:27:36 +00:00
|
|
|
err := gitRepo.RemoveFilesFromIndex(oldWikiPath)
|
|
|
|
if err != nil {
|
2024-04-07 11:17:06 +00:00
|
|
|
log.Error("RemoveFilesFromIndex failed: %v", err)
|
2020-01-07 18:27:36 +00:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// FIXME: The wiki doesn't have lfs support at present - if this changes need to check attributes here
|
|
|
|
|
|
|
|
objectHash, err := gitRepo.HashObject(strings.NewReader(content))
|
|
|
|
if err != nil {
|
2024-04-07 11:17:06 +00:00
|
|
|
log.Error("HashObject failed: %v", err)
|
2020-01-07 18:27:36 +00:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
if err := gitRepo.AddObjectToIndex("100644", objectHash, newWikiPath); err != nil {
|
2024-04-07 11:17:06 +00:00
|
|
|
log.Error("AddObjectToIndex failed: %v", err)
|
2020-01-07 18:27:36 +00:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
tree, err := gitRepo.WriteTree()
|
|
|
|
if err != nil {
|
2024-04-07 11:17:06 +00:00
|
|
|
log.Error("WriteTree failed: %v", err)
|
2020-01-07 18:27:36 +00:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
commitTreeOpts := git.CommitTreeOpts{
|
|
|
|
Message: message,
|
|
|
|
}
|
|
|
|
|
2020-09-19 16:44:55 +00:00
|
|
|
committer := doer.NewGitSig()
|
|
|
|
|
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.
## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:
Firstly, there are temporary repositories which do not change:
```go
git.OpenRepository(ctx, diskPath)
```
Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:
```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```
Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.
## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.
---------
Co-authored-by: delvh <dev.lh@web.de>
2024-01-27 20:09:51 +00:00
|
|
|
sign, signingKey, signer, _ := asymkey_service.SignWikiCommit(ctx, repo, doer)
|
2020-01-07 18:27:36 +00:00
|
|
|
if sign {
|
|
|
|
commitTreeOpts.KeyID = signingKey
|
2021-12-10 01:27:50 +00:00
|
|
|
if repo.GetTrustModel() == repo_model.CommitterTrustModel || repo.GetTrustModel() == repo_model.CollaboratorCommitterTrustModel {
|
2020-09-19 16:44:55 +00:00
|
|
|
committer = signer
|
|
|
|
}
|
2020-01-07 18:27:36 +00:00
|
|
|
} else {
|
|
|
|
commitTreeOpts.NoGPGSign = true
|
|
|
|
}
|
2024-03-06 06:26:32 +00:00
|
|
|
if hasDefaultBranch {
|
2020-01-07 18:27:36 +00:00
|
|
|
commitTreeOpts.Parents = []string{"HEAD"}
|
|
|
|
}
|
2020-09-19 16:44:55 +00:00
|
|
|
|
|
|
|
commitHash, err := gitRepo.CommitTree(doer.NewGitSig(), committer, tree, commitTreeOpts)
|
2020-01-07 18:27:36 +00:00
|
|
|
if err != nil {
|
2024-04-07 11:17:06 +00:00
|
|
|
log.Error("CommitTree failed: %v", err)
|
2020-01-07 18:27:36 +00:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2021-11-30 20:06:32 +00:00
|
|
|
if err := git.Push(gitRepo.Ctx, basePath, git.PushOptions{
|
2022-10-15 14:40:32 +00:00
|
|
|
Remote: DefaultRemote,
|
2024-03-06 06:26:32 +00:00
|
|
|
Branch: fmt.Sprintf("%s:%s%s", commitHash.String(), git.BranchPrefix, repo.DefaultWikiBranch),
|
2022-05-08 16:46:32 +00:00
|
|
|
Env: repo_module.FullPushingEnvironment(
|
2020-01-07 18:27:36 +00:00
|
|
|
doer,
|
|
|
|
doer,
|
|
|
|
repo,
|
|
|
|
repo.Name+".wiki",
|
|
|
|
0,
|
|
|
|
),
|
|
|
|
}); err != nil {
|
2024-04-07 11:17:06 +00:00
|
|
|
log.Error("Push failed: %v", err)
|
2020-03-28 04:13:18 +00:00
|
|
|
if git.IsErrPushOutOfDate(err) || git.IsErrPushRejected(err) {
|
|
|
|
return err
|
|
|
|
}
|
2024-04-07 11:17:06 +00:00
|
|
|
return fmt.Errorf("failed to push: %w", err)
|
2020-01-07 18:27:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// AddWikiPage adds a new wiki page with a given wikiPath.
|
2023-04-19 17:50:10 +00:00
|
|
|
func AddWikiPage(ctx context.Context, doer *user_model.User, repo *repo_model.Repository, wikiName WebPath, content, message string) error {
|
2022-01-19 23:26:57 +00:00
|
|
|
return updateWikiPage(ctx, doer, repo, "", wikiName, content, message, true)
|
2020-01-07 18:27:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// EditWikiPage updates a wiki page identified by its wikiPath,
|
|
|
|
// optionally also changing wikiPath.
|
2023-04-19 17:50:10 +00:00
|
|
|
func EditWikiPage(ctx context.Context, doer *user_model.User, repo *repo_model.Repository, oldWikiName, newWikiName WebPath, content, message string) error {
|
2022-01-19 23:26:57 +00:00
|
|
|
return updateWikiPage(ctx, doer, repo, oldWikiName, newWikiName, content, message, false)
|
2020-01-07 18:27:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// DeleteWikiPage deletes a wiki page identified by its path.
|
2023-04-19 17:50:10 +00:00
|
|
|
func DeleteWikiPage(ctx context.Context, doer *user_model.User, repo *repo_model.Repository, wikiName WebPath) (err error) {
|
2023-09-21 23:43:29 +00:00
|
|
|
err = repo.MustNotBeArchived()
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2024-09-06 10:12:41 +00:00
|
|
|
releaser, err := globallock.Lock(ctx, getWikiWorkingLockKey(repo.ID))
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
defer releaser()
|
2020-01-07 18:27:36 +00:00
|
|
|
|
2022-01-19 23:26:57 +00:00
|
|
|
if err = InitWiki(ctx, repo); err != nil {
|
2022-10-24 19:29:17 +00:00
|
|
|
return fmt.Errorf("InitWiki: %w", err)
|
2020-01-07 18:27:36 +00:00
|
|
|
}
|
|
|
|
|
2022-05-08 16:46:32 +00:00
|
|
|
basePath, err := repo_module.CreateTemporaryPath("update-wiki")
|
2020-01-07 18:27:36 +00:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
defer func() {
|
2022-05-08 16:46:32 +00:00
|
|
|
if err := repo_module.RemoveTemporaryPath(basePath); err != nil {
|
2020-01-07 18:27:36 +00:00
|
|
|
log.Error("Merge: RemoveTemporaryPath: %s", err)
|
|
|
|
}
|
|
|
|
}()
|
|
|
|
|
2022-01-19 23:26:57 +00:00
|
|
|
if err := git.Clone(ctx, repo.WikiPath(), basePath, git.CloneRepoOptions{
|
2020-01-07 18:27:36 +00:00
|
|
|
Bare: true,
|
|
|
|
Shared: true,
|
2024-03-06 06:26:32 +00:00
|
|
|
Branch: repo.DefaultWikiBranch,
|
2020-01-07 18:27:36 +00:00
|
|
|
}); err != nil {
|
|
|
|
log.Error("Failed to clone repository: %s (%v)", repo.FullName(), err)
|
2023-04-19 17:50:10 +00:00
|
|
|
return fmt.Errorf("failed to clone repository: %s (%w)", repo.FullName(), err)
|
2020-01-07 18:27:36 +00:00
|
|
|
}
|
|
|
|
|
2022-03-29 19:13:41 +00:00
|
|
|
gitRepo, err := git.OpenRepository(ctx, basePath)
|
2020-01-07 18:27:36 +00:00
|
|
|
if err != nil {
|
|
|
|
log.Error("Unable to open temporary repository: %s (%v)", basePath, err)
|
2023-04-19 17:50:10 +00:00
|
|
|
return fmt.Errorf("failed to open new temporary repository in: %s %w", basePath, err)
|
2020-01-07 18:27:36 +00:00
|
|
|
}
|
|
|
|
defer gitRepo.Close()
|
|
|
|
|
|
|
|
if err := gitRepo.ReadTreeToIndex("HEAD"); err != nil {
|
|
|
|
log.Error("Unable to read HEAD tree to index in: %s %v", basePath, err)
|
2023-04-19 17:50:10 +00:00
|
|
|
return fmt.Errorf("unable to read HEAD tree to index in: %s %w", basePath, err)
|
2020-01-07 18:27:36 +00:00
|
|
|
}
|
|
|
|
|
2024-03-06 06:26:32 +00:00
|
|
|
found, wikiPath, err := prepareGitPath(gitRepo, repo.DefaultWikiBranch, wikiName)
|
2021-07-19 16:14:00 +00:00
|
|
|
if err != nil {
|
|
|
|
return err
|
2020-01-07 18:27:36 +00:00
|
|
|
}
|
|
|
|
if found {
|
|
|
|
err := gitRepo.RemoveFilesFromIndex(wikiPath)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
return os.ErrNotExist
|
|
|
|
}
|
|
|
|
|
|
|
|
// FIXME: The wiki doesn't have lfs support at present - if this changes need to check attributes here
|
|
|
|
|
|
|
|
tree, err := gitRepo.WriteTree()
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
2023-04-19 17:50:10 +00:00
|
|
|
message := fmt.Sprintf("Delete page %q", wikiName)
|
2020-01-07 18:27:36 +00:00
|
|
|
commitTreeOpts := git.CommitTreeOpts{
|
|
|
|
Message: message,
|
|
|
|
Parents: []string{"HEAD"},
|
|
|
|
}
|
|
|
|
|
2020-09-19 16:44:55 +00:00
|
|
|
committer := doer.NewGitSig()
|
|
|
|
|
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.
## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:
Firstly, there are temporary repositories which do not change:
```go
git.OpenRepository(ctx, diskPath)
```
Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:
```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```
Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.
## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.
---------
Co-authored-by: delvh <dev.lh@web.de>
2024-01-27 20:09:51 +00:00
|
|
|
sign, signingKey, signer, _ := asymkey_service.SignWikiCommit(ctx, repo, doer)
|
2020-01-07 18:27:36 +00:00
|
|
|
if sign {
|
|
|
|
commitTreeOpts.KeyID = signingKey
|
2021-12-10 01:27:50 +00:00
|
|
|
if repo.GetTrustModel() == repo_model.CommitterTrustModel || repo.GetTrustModel() == repo_model.CollaboratorCommitterTrustModel {
|
2020-09-19 16:44:55 +00:00
|
|
|
committer = signer
|
|
|
|
}
|
2020-01-07 18:27:36 +00:00
|
|
|
} else {
|
|
|
|
commitTreeOpts.NoGPGSign = true
|
|
|
|
}
|
|
|
|
|
2020-09-19 16:44:55 +00:00
|
|
|
commitHash, err := gitRepo.CommitTree(doer.NewGitSig(), committer, tree, commitTreeOpts)
|
2020-01-07 18:27:36 +00:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2021-11-30 20:06:32 +00:00
|
|
|
if err := git.Push(gitRepo.Ctx, basePath, git.PushOptions{
|
2022-10-15 14:40:32 +00:00
|
|
|
Remote: DefaultRemote,
|
2024-03-06 06:26:32 +00:00
|
|
|
Branch: fmt.Sprintf("%s:%s%s", commitHash.String(), git.BranchPrefix, repo.DefaultWikiBranch),
|
2023-04-23 21:22:16 +00:00
|
|
|
Env: repo_module.FullPushingEnvironment(
|
|
|
|
doer,
|
|
|
|
doer,
|
|
|
|
repo,
|
|
|
|
repo.Name+".wiki",
|
|
|
|
0,
|
|
|
|
),
|
2020-01-07 18:27:36 +00:00
|
|
|
}); err != nil {
|
2020-03-28 04:13:18 +00:00
|
|
|
if git.IsErrPushOutOfDate(err) || git.IsErrPushRejected(err) {
|
|
|
|
return err
|
|
|
|
}
|
2022-10-24 19:29:17 +00:00
|
|
|
return fmt.Errorf("Push: %w", err)
|
2020-01-07 18:27:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
2021-09-08 15:19:30 +00:00
|
|
|
|
|
|
|
// DeleteWiki removes the actual and local copy of repository wiki.
|
2022-01-19 23:26:57 +00:00
|
|
|
func DeleteWiki(ctx context.Context, repo *repo_model.Repository) error {
|
2024-01-12 21:50:38 +00:00
|
|
|
if err := repo_service.UpdateRepositoryUnits(ctx, repo, nil, []unit.Type{unit.TypeWiki}); err != nil {
|
2021-09-08 15:19:30 +00:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2022-10-16 23:29:26 +00:00
|
|
|
system_model.RemoveAllWithNotice(ctx, "Delete repository wiki", repo.WikiPath())
|
2021-09-08 15:19:30 +00:00
|
|
|
return nil
|
|
|
|
}
|
2024-03-06 06:26:32 +00:00
|
|
|
|
|
|
|
func ChangeDefaultWikiBranch(ctx context.Context, repo *repo_model.Repository, newBranch string) error {
|
|
|
|
if !git.IsValidRefPattern(newBranch) {
|
|
|
|
return fmt.Errorf("invalid branch name: %s", newBranch)
|
|
|
|
}
|
|
|
|
return db.WithTx(ctx, func(ctx context.Context) error {
|
|
|
|
repo.DefaultWikiBranch = newBranch
|
|
|
|
if err := repo_model.UpdateRepositoryCols(ctx, repo, "default_wiki_branch"); err != nil {
|
|
|
|
return fmt.Errorf("unable to update database: %w", err)
|
|
|
|
}
|
|
|
|
|
2024-04-08 11:43:23 +00:00
|
|
|
if !repo.HasWiki() {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2024-03-08 07:30:10 +00:00
|
|
|
oldDefBranch, err := gitrepo.GetWikiDefaultBranch(ctx, repo)
|
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("unable to get default branch: %w", err)
|
|
|
|
}
|
|
|
|
if oldDefBranch == newBranch {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2024-03-06 06:26:32 +00:00
|
|
|
gitRepo, err := gitrepo.OpenWikiRepository(ctx, repo)
|
|
|
|
if errors.Is(err, util.ErrNotExist) {
|
|
|
|
return nil // no git repo on storage, no need to do anything else
|
|
|
|
} else if err != nil {
|
|
|
|
return fmt.Errorf("unable to open repository: %w", err)
|
|
|
|
}
|
|
|
|
defer gitRepo.Close()
|
|
|
|
|
|
|
|
err = gitRepo.RenameBranch(oldDefBranch, newBranch)
|
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("unable to rename default branch: %w", err)
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|