2019-09-27 00:22:36 +00:00
// Copyright 2019 The Gitea Authors. All rights reserved.
2022-11-27 18:20:29 +00:00
// SPDX-License-Identifier: MIT
2019-09-27 00:22:36 +00:00
package pull
import (
2024-01-09 02:32:14 +00:00
"bytes"
2019-12-15 09:51:28 +00:00
"context"
2019-09-27 00:22:36 +00:00
"fmt"
2022-01-19 23:26:57 +00:00
"io"
2023-01-28 15:54:40 +00:00
"os"
2021-06-25 17:01:43 +00:00
"regexp"
2020-01-09 01:47:45 +00:00
"strings"
2023-07-28 19:18:12 +00:00
"time"
2019-09-27 00:22:36 +00:00
"code.gitea.io/gitea/models"
2021-09-19 11:49:59 +00:00
"code.gitea.io/gitea/models/db"
2022-06-12 15:51:54 +00:00
git_model "code.gitea.io/gitea/models/git"
2022-06-13 09:37:59 +00:00
issues_model "code.gitea.io/gitea/models/issues"
2024-11-09 04:48:31 +00:00
"code.gitea.io/gitea/models/organization"
2024-07-29 02:21:22 +00:00
access_model "code.gitea.io/gitea/models/perm/access"
2021-12-10 01:27:50 +00:00
repo_model "code.gitea.io/gitea/models/repo"
2024-07-29 02:21:22 +00:00
"code.gitea.io/gitea/models/unit"
2021-11-24 09:49:20 +00:00
user_model "code.gitea.io/gitea/models/user"
2023-07-28 19:18:12 +00:00
"code.gitea.io/gitea/modules/base"
2022-10-12 05:18:26 +00:00
"code.gitea.io/gitea/modules/container"
2019-10-15 03:28:40 +00:00
"code.gitea.io/gitea/modules/git"
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.
## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:
Firstly, there are temporary repositories which do not change:
```go
git.OpenRepository(ctx, diskPath)
```
Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:
```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```
Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.
## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.
---------
Co-authored-by: delvh <dev.lh@web.de>
2024-01-27 20:09:51 +00:00
"code.gitea.io/gitea/modules/gitrepo"
2024-09-06 10:12:41 +00:00
"code.gitea.io/gitea/modules/globallock"
2019-12-15 09:51:28 +00:00
"code.gitea.io/gitea/modules/graceful"
2021-07-24 16:03:58 +00:00
"code.gitea.io/gitea/modules/json"
2019-09-27 00:22:36 +00:00
"code.gitea.io/gitea/modules/log"
2022-05-08 16:46:32 +00:00
repo_module "code.gitea.io/gitea/modules/repository"
2020-04-10 11:26:37 +00:00
"code.gitea.io/gitea/modules/setting"
2023-01-28 15:54:40 +00:00
"code.gitea.io/gitea/modules/util"
2024-02-27 07:12:22 +00:00
gitea_context "code.gitea.io/gitea/services/context"
2019-10-28 16:45:43 +00:00
issue_service "code.gitea.io/gitea/services/issue"
2023-09-05 18:37:47 +00:00
notify_service "code.gitea.io/gitea/services/notify"
2019-09-27 00:22:36 +00:00
)
2024-09-06 10:12:41 +00:00
func getPullWorkingLockKey ( prID int64 ) string {
return fmt . Sprintf ( "pull_working_%d" , prID )
}
2022-05-04 16:06:23 +00:00
2024-11-09 04:48:31 +00:00
type NewPullRequestOptions struct {
Repo * repo_model . Repository
Issue * issues_model . Issue
LabelIDs [ ] int64
AttachmentUUIDs [ ] string
PullRequest * issues_model . PullRequest
AssigneeIDs [ ] int64
Reviewers [ ] * user_model . User
TeamReviewers [ ] * organization . Team
}
2019-09-27 00:22:36 +00:00
// NewPullRequest creates new pull request with labels for repository.
2024-11-09 04:48:31 +00:00
func NewPullRequest ( ctx context . Context , opts * NewPullRequestOptions ) error {
repo , issue , labelIDs , uuids , pr , assigneeIDs := opts . Repo , opts . Issue , opts . LabelIDs , opts . AttachmentUUIDs , opts . PullRequest , opts . AssigneeIDs
2024-03-04 08:16:03 +00:00
if err := issue . LoadPoster ( ctx ) ; err != nil {
return err
}
if user_model . IsUserBlockedBy ( ctx , issue . Poster , repo . OwnerID ) || user_model . IsUserBlockedBy ( ctx , issue . Poster , assigneeIDs ... ) {
return user_model . ErrBlockedUser
}
2024-07-29 02:21:22 +00:00
// user should be a collaborator or a member of the organization for base repo
if ! issue . Poster . IsAdmin {
canCreate , err := repo_model . IsOwnerMemberCollaborator ( ctx , repo , issue . Poster . ID )
if err != nil {
return err
}
if ! canCreate {
// or user should have write permission in the head repo
if err := pr . LoadHeadRepo ( ctx ) ; err != nil {
return err
}
perm , err := access_model . GetUserRepoPermission ( ctx , pr . HeadRepo , issue . Poster )
if err != nil {
return err
}
if ! perm . CanWrite ( unit . TypeCode ) {
return issues_model . ErrMustCollaborator
}
}
}
2023-08-10 02:39:21 +00:00
prCtx , cancel , err := createTemporaryRepoForPR ( ctx , pr )
2020-04-14 13:53:34 +00:00
if err != nil {
2023-08-10 02:39:21 +00:00
if ! git_model . IsErrBranchNotExist ( err ) {
log . Error ( "CreateTemporaryRepoForPR %-v: %v" , pr , err )
2019-10-28 16:45:43 +00:00
}
2023-08-10 02:39:21 +00:00
return err
2019-10-28 16:45:43 +00:00
}
2023-08-10 02:39:21 +00:00
defer cancel ( )
2019-10-28 16:45:43 +00:00
2023-08-10 02:39:21 +00:00
if err := testPatch ( ctx , prCtx , pr ) ; err != nil {
2019-12-15 03:28:51 +00:00
return err
}
2023-08-10 02:39:21 +00:00
divergence , err := git . GetDivergingCommits ( ctx , prCtx . tmpBasePath , baseBranch , trackingBranch )
2021-01-02 17:04:02 +00:00
if err != nil {
return err
}
2023-08-10 02:39:21 +00:00
pr . CommitsAhead = divergence . Ahead
pr . CommitsBehind = divergence . Behind
2021-01-02 17:04:02 +00:00
2023-08-10 02:39:21 +00:00
assigneeCommentMap := make ( map [ int64 ] * issues_model . Comment )
2019-09-27 00:22:36 +00:00
2020-05-20 12:47:24 +00:00
// add first push codes comment
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.
## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:
Firstly, there are temporary repositories which do not change:
```go
git.OpenRepository(ctx, diskPath)
```
Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:
```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```
Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.
## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.
---------
Co-authored-by: delvh <dev.lh@web.de>
2024-01-27 20:09:51 +00:00
baseGitRepo , err := gitrepo . OpenRepository ( ctx , pr . BaseRepo )
2020-05-20 12:47:24 +00:00
if err != nil {
return err
}
defer baseGitRepo . Close ( )
2024-04-27 08:03:49 +00:00
var reviewNotifiers [ ] * issue_service . ReviewRequestNotifier
2023-08-10 02:39:21 +00:00
if err := db . WithTx ( ctx , func ( ctx context . Context ) error {
if err := issues_model . NewPullRequest ( ctx , repo , issue , labelIDs , uuids , pr ) ; err != nil {
return err
}
for _ , assigneeID := range assigneeIDs {
comment , err := issue_service . AddAssigneeIfNotAssigned ( ctx , issue , issue . Poster , assigneeID , false )
if err != nil {
return err
}
assigneeCommentMap [ assigneeID ] = comment
}
pr . Issue = issue
issue . PullRequest = pr
if pr . Flow == issues_model . PullRequestFlowGithub {
err = PushToBaseRepo ( ctx , pr )
} else {
err = UpdateRef ( ctx , pr )
}
if err != nil {
return err
}
compareInfo , err := baseGitRepo . GetCompareInfo ( pr . BaseRepo . RepoPath ( ) ,
git . BranchPrefix + pr . BaseBranch , pr . GetGitRefName ( ) , false , false )
if err != nil {
return err
}
if len ( compareInfo . Commits ) == 0 {
return nil
}
2020-05-20 12:47:24 +00:00
2022-06-13 09:37:59 +00:00
data := issues_model . PushActionContent { IsForcePush : false }
2021-08-09 18:08:51 +00:00
data . CommitIDs = make ( [ ] string , 0 , len ( compareInfo . Commits ) )
for i := len ( compareInfo . Commits ) - 1 ; i >= 0 ; i -- {
data . CommitIDs = append ( data . CommitIDs , compareInfo . Commits [ i ] . ID . String ( ) )
2020-05-20 12:47:24 +00:00
}
dataJSON , err := json . Marshal ( data )
if err != nil {
return err
}
2022-06-13 09:37:59 +00:00
ops := & issues_model . CreateCommentOptions {
Type : issues_model . CommentTypePullRequestPush ,
2023-08-10 02:39:21 +00:00
Doer : issue . Poster ,
2020-05-20 12:47:24 +00:00
Repo : repo ,
Issue : pr . Issue ,
IsForcePush : false ,
Content : string ( dataJSON ) ,
}
2023-08-10 02:39:21 +00:00
if _ , err = issues_model . CreateComment ( ctx , ops ) ; err != nil {
return err
}
2023-06-08 08:56:05 +00:00
2023-10-11 04:24:07 +00:00
if ! pr . IsWorkInProgress ( ctx ) {
2024-04-27 08:03:49 +00:00
reviewNotifiers , err = issue_service . PullRequestCodeOwnersReview ( ctx , issue , pr )
2024-03-19 05:28:43 +00:00
if err != nil {
2023-06-08 08:56:05 +00:00
return err
}
}
2023-08-10 02:39:21 +00:00
return nil
} ) ; err != nil {
// cleanup: this will only remove the reference, the real commit will be clean up when next GC
if err1 := baseGitRepo . RemoveReference ( pr . GetGitRefName ( ) ) ; err1 != nil {
log . Error ( "RemoveReference: %v" , err1 )
}
return err
}
baseGitRepo . Close ( ) // close immediately to avoid notifications will open the repository again
2023-06-08 08:56:05 +00:00
2024-04-27 08:03:49 +00:00
issue_service . ReviewRequestNotify ( ctx , issue , issue . Poster , reviewNotifiers )
2024-03-19 05:28:43 +00:00
2023-08-10 02:39:21 +00:00
mentions , err := issues_model . FindAndUpdateIssueMentions ( ctx , issue , issue . Poster , issue . Content )
if err != nil {
return err
}
2023-09-05 18:37:47 +00:00
notify_service . NewPullRequest ( ctx , pr , mentions )
2023-08-10 02:39:21 +00:00
if len ( issue . Labels ) > 0 {
2023-09-05 18:37:47 +00:00
notify_service . IssueChangeLabels ( ctx , issue . Poster , issue , issue . Labels , nil )
2023-08-10 02:39:21 +00:00
}
if issue . Milestone != nil {
2023-09-05 18:37:47 +00:00
notify_service . IssueChangeMilestone ( ctx , issue . Poster , issue , 0 )
2023-08-10 02:39:21 +00:00
}
2023-10-06 06:49:37 +00:00
for _ , assigneeID := range assigneeIDs {
assignee , err := user_model . GetUserByID ( ctx , assigneeID )
if err != nil {
return ErrDependenciesLeft
2023-08-10 02:39:21 +00:00
}
2023-10-06 06:49:37 +00:00
notify_service . IssueChangeAssignee ( ctx , issue . Poster , issue , assignee , false , assigneeCommentMap [ assigneeID ] )
2020-05-20 12:47:24 +00:00
}
2024-11-09 04:48:31 +00:00
permDoer , err := access_model . GetUserRepoPermission ( ctx , repo , issue . Poster )
for _ , reviewer := range opts . Reviewers {
if _ , err = issue_service . ReviewRequest ( ctx , pr . Issue , issue . Poster , & permDoer , reviewer , true ) ; err != nil {
return err
}
}
for _ , teamReviewer := range opts . TeamReviewers {
if _ , err = issue_service . TeamReviewRequest ( ctx , pr . Issue , issue . Poster , teamReviewer , true ) ; err != nil {
return err
}
}
2019-09-27 00:22:36 +00:00
return nil
}
2019-10-15 03:28:40 +00:00
2019-12-16 06:20:25 +00:00
// ChangeTargetBranch changes the target branch of this pull request, as the given user.
2022-06-13 09:37:59 +00:00
func ChangeTargetBranch ( ctx context . Context , pr * issues_model . PullRequest , doer * user_model . User , targetBranch string ) ( err error ) {
2024-09-06 10:12:41 +00:00
releaser , err := globallock . Lock ( ctx , getPullWorkingLockKey ( pr . ID ) )
if err != nil {
log . Error ( "lock.Lock(): %v" , err )
return fmt . Errorf ( "lock.Lock: %w" , err )
}
defer releaser ( )
2022-05-04 16:06:23 +00:00
2019-12-16 06:20:25 +00:00
// Current target branch is already the same
if pr . BaseBranch == targetBranch {
return nil
}
if pr . Issue . IsClosed {
2022-06-13 09:37:59 +00:00
return issues_model . ErrIssueIsClosed {
2019-12-16 06:20:25 +00:00
ID : pr . Issue . ID ,
RepoID : pr . Issue . RepoID ,
Index : pr . Issue . Index ,
}
}
if pr . HasMerged {
return models . ErrPullRequestHasMerged {
ID : pr . ID ,
IssueID : pr . Index ,
HeadRepoID : pr . HeadRepoID ,
BaseRepoID : pr . BaseRepoID ,
HeadBranch : pr . HeadBranch ,
BaseBranch : pr . BaseBranch ,
}
}
// Check if branches are equal
2022-01-19 23:26:57 +00:00
branchesEqual , err := IsHeadEqualWithBranch ( ctx , pr , targetBranch )
2019-12-16 06:20:25 +00:00
if err != nil {
return err
}
if branchesEqual {
2023-06-29 10:03:20 +00:00
return git_model . ErrBranchesEqual {
2019-12-16 06:20:25 +00:00
HeadBranchName : pr . HeadBranch ,
BaseBranchName : targetBranch ,
}
}
// Check if pull request for the new target branch already exists
2022-11-19 08:12:33 +00:00
existingPr , err := issues_model . GetUnmergedPullRequest ( ctx , pr . HeadRepoID , pr . BaseRepoID , pr . HeadBranch , targetBranch , issues_model . PullRequestFlowGithub )
2019-12-16 06:20:25 +00:00
if existingPr != nil {
2022-06-13 09:37:59 +00:00
return issues_model . ErrPullRequestAlreadyExists {
2019-12-16 06:20:25 +00:00
ID : existingPr . ID ,
IssueID : existingPr . Index ,
HeadRepoID : existingPr . HeadRepoID ,
BaseRepoID : existingPr . BaseRepoID ,
HeadBranch : existingPr . HeadBranch ,
BaseBranch : existingPr . BaseBranch ,
}
}
2022-06-13 09:37:59 +00:00
if err != nil && ! issues_model . IsErrPullRequestNotExist ( err ) {
2019-12-16 06:20:25 +00:00
return err
}
// Set new target branch
oldBranch := pr . BaseBranch
pr . BaseBranch = targetBranch
// Refresh patch
if err := TestPatch ( pr ) ; err != nil {
return err
}
// Update target branch, PR diff and status
// This is the same as checkAndUpdateStatus in check service, but also updates base_branch
2022-06-13 09:37:59 +00:00
if pr . Status == issues_model . PullRequestStatusChecking {
pr . Status = issues_model . PullRequestStatusMergeable
2019-12-16 06:20:25 +00:00
}
2020-06-16 17:52:33 +00:00
// Update Commit Divergence
2022-01-19 23:26:57 +00:00
divergence , err := GetDiverging ( ctx , pr )
2020-06-16 17:52:33 +00:00
if err != nil {
return err
}
pr . CommitsAhead = divergence . Ahead
pr . CommitsBehind = divergence . Behind
2022-11-19 08:12:33 +00:00
if err := pr . UpdateColsIfNotMerged ( ctx , "merge_base" , "status" , "conflicted_files" , "changed_protected_files" , "base_branch" , "commits_ahead" , "commits_behind" ) ; err != nil {
2019-12-16 06:20:25 +00:00
return err
}
// Create comment
2022-06-13 09:37:59 +00:00
options := & issues_model . CreateCommentOptions {
Type : issues_model . CommentTypeChangeTargetBranch ,
2019-12-16 06:20:25 +00:00
Doer : doer ,
Repo : pr . Issue . Repo ,
Issue : pr . Issue ,
OldRef : oldBranch ,
NewRef : targetBranch ,
}
2023-08-04 13:34:34 +00:00
if _ , err = issues_model . CreateComment ( ctx , options ) ; err != nil {
2022-10-24 19:29:17 +00:00
return fmt . Errorf ( "CreateChangeTargetBranchComment: %w" , err )
2019-12-16 06:20:25 +00:00
}
return nil
}
2022-06-13 09:37:59 +00:00
func checkForInvalidation ( ctx context . Context , requests issues_model . PullRequestList , repoID int64 , doer * user_model . User , branch string ) error {
2022-12-03 02:48:26 +00:00
repo , err := repo_model . GetRepositoryByID ( ctx , repoID )
2019-10-15 03:28:40 +00:00
if err != nil {
2022-11-19 08:12:33 +00:00
return fmt . Errorf ( "GetRepositoryByIDCtx: %w" , err )
2019-10-15 03:28:40 +00:00
}
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.
## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:
Firstly, there are temporary repositories which do not change:
```go
git.OpenRepository(ctx, diskPath)
```
Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:
```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```
Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.
## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.
---------
Co-authored-by: delvh <dev.lh@web.de>
2024-01-27 20:09:51 +00:00
gitRepo , err := gitrepo . OpenRepository ( ctx , repo )
2019-10-15 03:28:40 +00:00
if err != nil {
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.
## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:
Firstly, there are temporary repositories which do not change:
```go
git.OpenRepository(ctx, diskPath)
```
Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:
```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```
Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.
## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.
---------
Co-authored-by: delvh <dev.lh@web.de>
2024-01-27 20:09:51 +00:00
return fmt . Errorf ( "gitrepo.OpenRepository: %w" , err )
2019-10-15 03:28:40 +00:00
}
go func ( ) {
2019-12-15 09:51:28 +00:00
// FIXME: graceful: We need to tell the manager we're doing something...
2023-01-17 21:03:44 +00:00
err := InvalidateCodeComments ( ctx , requests , doer , gitRepo , branch )
2019-10-15 03:28:40 +00:00
if err != nil {
log . Error ( "PullRequestList.InvalidateCodeComments: %v" , err )
}
2019-11-13 07:01:19 +00:00
gitRepo . Close ( )
2019-10-15 03:28:40 +00:00
} ( )
return nil
}
// AddTestPullRequestTask adds new test tasks by given head/base repository and head/base branch,
// and generate new patch for testing as needed.
2021-11-24 09:49:20 +00:00
func AddTestPullRequestTask ( doer * user_model . User , repoID int64 , branch string , isSync bool , oldCommitID , newCommitID string ) {
2019-10-15 03:28:40 +00:00
log . Trace ( "AddTestPullRequestTask [head_repo_id: %d, head_branch: %s]: finding pull requests" , repoID , branch )
2019-12-15 09:51:28 +00:00
graceful . GetManager ( ) . RunWithShutdownContext ( func ( ctx context . Context ) {
// There is no sensible way to shut this down ":-("
// If you don't let it run all the way then you will lose data
2022-05-07 17:05:52 +00:00
// TODO: graceful: AddTestPullRequestTask needs to become a queue!
2019-10-15 03:28:40 +00:00
2023-05-08 06:39:32 +00:00
// GetUnmergedPullRequestsByHeadInfo() only return open and unmerged PR.
2023-07-22 14:14:27 +00:00
prs , err := issues_model . GetUnmergedPullRequestsByHeadInfo ( ctx , repoID , branch )
2019-12-15 09:51:28 +00:00
if err != nil {
log . Error ( "Find pull requests [head_repo_id: %d, head_branch: %s]: %v" , repoID , branch , err )
return
2019-10-15 03:28:40 +00:00
}
2019-12-15 09:51:28 +00:00
2023-02-05 11:57:38 +00:00
for _ , pr := range prs {
log . Trace ( "Updating PR[%d]: composing new test task" , pr . ID )
if pr . Flow == issues_model . PullRequestFlowGithub {
if err := PushToBaseRepo ( ctx , pr ) ; err != nil {
log . Error ( "PushToBaseRepo: %v" , err )
continue
}
} else {
continue
}
2023-07-22 14:14:27 +00:00
AddToTaskQueue ( ctx , pr )
2023-02-05 11:57:38 +00:00
comment , err := CreatePushPullComment ( ctx , doer , pr , oldCommitID , newCommitID )
2023-05-08 06:39:32 +00:00
if err == nil && comment != nil {
2023-09-05 18:37:47 +00:00
notify_service . PullRequestPushCommits ( ctx , doer , pr , comment )
2023-02-05 11:57:38 +00:00
}
}
2019-12-15 09:51:28 +00:00
if isSync {
2022-06-13 09:37:59 +00:00
requests := issues_model . PullRequestList ( prs )
2023-07-22 14:14:27 +00:00
if err = requests . LoadAttributes ( ctx ) ; err != nil {
2019-12-15 09:51:28 +00:00
log . Error ( "PullRequestList.LoadAttributes: %v" , err )
}
2022-01-19 23:26:57 +00:00
if invalidationErr := checkForInvalidation ( ctx , requests , repoID , doer , branch ) ; invalidationErr != nil {
2019-12-15 09:51:28 +00:00
log . Error ( "checkForInvalidation: %v" , invalidationErr )
}
if err == nil {
for _ , pr := range prs {
2024-03-10 21:30:36 +00:00
objectFormat := git . ObjectFormatFromName ( pr . BaseRepo . ObjectFormatName )
2023-12-17 11:56:08 +00:00
if newCommitID != "" && newCommitID != objectFormat . EmptyObjectID ( ) . String ( ) {
2022-01-19 23:26:57 +00:00
changed , err := checkIfPRContentChanged ( ctx , pr , oldCommitID , newCommitID )
2020-01-09 01:47:45 +00:00
if err != nil {
log . Error ( "checkIfPRContentChanged: %v" , err )
}
if changed {
// Mark old reviews as stale if diff to mergebase has changed
2023-09-29 12:12:54 +00:00
if err := issues_model . MarkReviewsAsStale ( ctx , pr . IssueID ) ; err != nil {
2020-01-09 01:47:45 +00:00
log . Error ( "MarkReviewsAsStale: %v" , err )
}
2023-07-20 07:18:52 +00:00
// dismiss all approval reviews if protected branch rule item enabled.
pb , err := git_model . GetFirstMatchProtectedBranchRule ( ctx , pr . BaseRepoID , pr . BaseBranch )
if err != nil {
log . Error ( "GetFirstMatchProtectedBranchRule: %v" , err )
}
if pb != nil && pb . DismissStaleApprovals {
if err := DismissApprovalReviews ( ctx , doer , pr ) ; err != nil {
log . Error ( "DismissApprovalReviews: %v" , err )
}
}
2020-01-09 01:47:45 +00:00
}
2023-09-29 12:12:54 +00:00
if err := issues_model . MarkReviewsAsNotStale ( ctx , pr . IssueID , newCommitID ) ; err != nil {
2020-01-09 01:47:45 +00:00
log . Error ( "MarkReviewsAsNotStale: %v" , err )
}
2022-01-19 23:26:57 +00:00
divergence , err := GetDiverging ( ctx , pr )
2020-04-14 13:53:34 +00:00
if err != nil {
log . Error ( "GetDiverging: %v" , err )
} else {
2022-05-20 14:08:52 +00:00
err = pr . UpdateCommitDivergence ( ctx , divergence . Ahead , divergence . Behind )
2020-04-14 13:53:34 +00:00
if err != nil {
log . Error ( "UpdateCommitDivergence: %v" , err )
}
}
2020-01-09 01:47:45 +00:00
}
2023-09-05 18:37:47 +00:00
notify_service . PullRequestSynchronized ( ctx , doer , pr )
2019-12-15 09:51:28 +00:00
}
2019-10-15 03:28:40 +00:00
}
}
2019-12-15 09:51:28 +00:00
log . Trace ( "AddTestPullRequestTask [base_repo_id: %d, base_branch: %s]: finding pull requests" , repoID , branch )
2023-07-22 14:14:27 +00:00
prs , err = issues_model . GetUnmergedPullRequestsByBaseInfo ( ctx , repoID , branch )
2019-12-15 09:51:28 +00:00
if err != nil {
log . Error ( "Find pull requests [base_repo_id: %d, base_branch: %s]: %v" , repoID , branch , err )
return
}
for _ , pr := range prs {
2022-01-19 23:26:57 +00:00
divergence , err := GetDiverging ( ctx , pr )
2020-04-14 13:53:34 +00:00
if err != nil {
2023-06-29 10:03:20 +00:00
if git_model . IsErrBranchNotExist ( err ) && ! git . IsBranchExist ( ctx , pr . HeadRepo . RepoPath ( ) , pr . HeadBranch ) {
2021-07-12 23:26:25 +00:00
log . Warn ( "Cannot test PR %s/%d: head_branch %s no longer exists" , pr . BaseRepo . Name , pr . IssueID , pr . HeadBranch )
} else {
log . Error ( "GetDiverging: %v" , err )
}
2020-04-14 13:53:34 +00:00
} else {
2022-05-20 14:08:52 +00:00
err = pr . UpdateCommitDivergence ( ctx , divergence . Ahead , divergence . Behind )
2020-04-14 13:53:34 +00:00
if err != nil {
log . Error ( "UpdateCommitDivergence: %v" , err )
}
}
2023-07-22 14:14:27 +00:00
AddToTaskQueue ( ctx , pr )
2019-12-15 09:51:28 +00:00
}
} )
2019-10-15 03:28:40 +00:00
}
2019-12-15 03:28:51 +00:00
2020-01-09 01:47:45 +00:00
// checkIfPRContentChanged checks if diff to target branch has changed by push
// A commit can be considered to leave the PR untouched if the patch/diff with its merge base is unchanged
2022-06-13 09:37:59 +00:00
func checkIfPRContentChanged ( ctx context . Context , pr * issues_model . PullRequest , oldCommitID , newCommitID string ) ( hasChanged bool , err error ) {
2023-03-07 20:07:35 +00:00
prCtx , cancel , err := createTemporaryRepoForPR ( ctx , pr )
2020-01-09 01:47:45 +00:00
if err != nil {
2023-03-07 20:07:35 +00:00
log . Error ( "CreateTemporaryRepoForPR %-v: %v" , pr , err )
2023-01-28 15:54:40 +00:00
return false , err
2020-01-09 01:47:45 +00:00
}
2023-03-07 20:07:35 +00:00
defer cancel ( )
2023-01-28 15:54:40 +00:00
2023-03-07 20:07:35 +00:00
tmpRepo , err := git . OpenRepository ( ctx , prCtx . tmpBasePath )
2020-01-09 01:47:45 +00:00
if err != nil {
2023-01-28 15:54:40 +00:00
return false , fmt . Errorf ( "OpenRepository: %w" , err )
2020-01-09 01:47:45 +00:00
}
2023-01-28 15:54:40 +00:00
defer tmpRepo . Close ( )
2020-01-09 01:47:45 +00:00
2023-01-28 15:54:40 +00:00
// Find the merge-base
_ , base , err := tmpRepo . GetMergeBase ( "" , "base" , "tracking" )
if err != nil {
return false , fmt . Errorf ( "GetMergeBase: %w" , err )
2020-01-09 01:47:45 +00:00
}
2023-01-28 15:54:40 +00:00
cmd := git . NewCommand ( ctx , "diff" , "--name-only" , "-z" ) . AddDynamicArguments ( newCommitID , oldCommitID , base )
stdoutReader , stdoutWriter , err := os . Pipe ( )
if err != nil {
return false , fmt . Errorf ( "unable to open pipe for to run diff: %w" , err )
}
2024-01-09 02:32:14 +00:00
stderr := new ( bytes . Buffer )
2023-01-28 15:54:40 +00:00
if err := cmd . Run ( & git . RunOpts {
2023-03-07 20:07:35 +00:00
Dir : prCtx . tmpBasePath ,
2023-01-28 15:54:40 +00:00
Stdout : stdoutWriter ,
2024-01-09 02:32:14 +00:00
Stderr : stderr ,
2023-01-28 15:54:40 +00:00
PipelineFunc : func ( ctx context . Context , cancel context . CancelFunc ) error {
_ = stdoutWriter . Close ( )
defer func ( ) {
_ = stdoutReader . Close ( )
} ( )
return util . IsEmptyReader ( stdoutReader )
} ,
} ) ; err != nil {
if err == util . ErrNotEmpty {
2020-01-09 01:47:45 +00:00
return true , nil
}
2024-01-09 02:32:14 +00:00
err = git . ConcatenateError ( err , stderr . String ( ) )
2020-01-09 01:47:45 +00:00
2023-01-28 15:54:40 +00:00
log . Error ( "Unable to run diff on %s %s %s in tempRepo for PR[%d]%s/%s...%s/%s: Error: %v" ,
newCommitID , oldCommitID , base ,
pr . ID , pr . BaseRepo . FullName ( ) , pr . BaseBranch , pr . HeadRepo . FullName ( ) , pr . HeadBranch ,
err )
return false , fmt . Errorf ( "Unable to run git diff --name-only -z %s %s %s: %w" , newCommitID , oldCommitID , base , err )
2020-01-09 01:47:45 +00:00
}
return false , nil
}
2019-12-15 03:28:51 +00:00
// PushToBaseRepo pushes commits from branches of head repository to
// corresponding branches of base repository.
// FIXME: Only push branches that are actually updates?
2022-06-13 09:37:59 +00:00
func PushToBaseRepo ( ctx context . Context , pr * issues_model . PullRequest ) ( err error ) {
2022-01-19 23:26:57 +00:00
return pushToBaseRepoHelper ( ctx , pr , "" )
2021-06-23 21:08:26 +00:00
}
2022-06-13 09:37:59 +00:00
func pushToBaseRepoHelper ( ctx context . Context , pr * issues_model . PullRequest , prefixHeadBranch string ) ( err error ) {
2019-12-15 03:28:51 +00:00
log . Trace ( "PushToBaseRepo[%d]: pushing commits to base repo '%s'" , pr . BaseRepoID , pr . GetGitRefName ( ) )
2022-11-19 08:12:33 +00:00
if err := pr . LoadHeadRepo ( ctx ) ; err != nil {
2020-02-21 18:18:13 +00:00
log . Error ( "Unable to load head repository for PR[%d] Error: %v" , pr . ID , err )
return err
}
2019-12-15 03:28:51 +00:00
headRepoPath := pr . HeadRepo . RepoPath ( )
2020-01-28 10:23:58 +00:00
2022-11-19 08:12:33 +00:00
if err := pr . LoadBaseRepo ( ctx ) ; err != nil {
2020-02-21 18:18:13 +00:00
log . Error ( "Unable to load base repository for PR[%d] Error: %v" , pr . ID , err )
return err
}
2020-09-15 03:32:31 +00:00
baseRepoPath := pr . BaseRepo . RepoPath ( )
2019-12-15 03:28:51 +00:00
2022-11-19 08:12:33 +00:00
if err = pr . LoadIssue ( ctx ) ; err != nil {
2022-10-24 19:29:17 +00:00
return fmt . Errorf ( "unable to load issue %d for pr %d: %w" , pr . IssueID , pr . ID , err )
2019-12-27 21:15:04 +00:00
}
2022-11-19 08:12:33 +00:00
if err = pr . Issue . LoadPoster ( ctx ) ; err != nil {
2022-10-24 19:29:17 +00:00
return fmt . Errorf ( "unable to load poster %d for pr %d: %w" , pr . Issue . PosterID , pr . ID , err )
2019-12-27 21:15:04 +00:00
}
2020-09-15 03:32:31 +00:00
gitRefName := pr . GetGitRefName ( )
2022-01-19 23:26:57 +00:00
if err := git . Push ( ctx , headRepoPath , git . PushOptions {
2020-09-15 03:32:31 +00:00
Remote : baseRepoPath ,
2021-06-23 21:08:26 +00:00
Branch : prefixHeadBranch + pr . HeadBranch + ":" + gitRefName ,
2019-12-15 03:28:51 +00:00
Force : true ,
2019-12-27 21:15:04 +00:00
// Use InternalPushingEnvironment here because we know that pre-receive and post-receive do not run on a refs/pulls/...
2022-05-08 16:46:32 +00:00
Env : repo_module . InternalPushingEnvironment ( pr . Issue . Poster , pr . BaseRepo ) ,
2019-12-15 03:28:51 +00:00
} ) ; err != nil {
2020-06-08 18:07:41 +00:00
if git . IsErrPushOutOfDate ( err ) {
// This should not happen as we're using force!
2020-09-15 03:32:31 +00:00
log . Error ( "Unable to push PR head for %s#%d (%-v:%s) due to ErrPushOfDate: %v" , pr . BaseRepo . FullName ( ) , pr . Index , pr . BaseRepo , gitRefName , err )
2020-06-08 18:07:41 +00:00
return err
} else if git . IsErrPushRejected ( err ) {
rejectErr := err . ( * git . ErrPushRejected )
2020-09-15 03:32:31 +00:00
log . Info ( "Unable to push PR head for %s#%d (%-v:%s) due to rejection:\nStdout: %s\nStderr: %s\nError: %v" , pr . BaseRepo . FullName ( ) , pr . Index , pr . BaseRepo , gitRefName , rejectErr . StdOut , rejectErr . StdErr , rejectErr . Err )
2020-06-08 18:07:41 +00:00
return err
2021-06-23 21:08:26 +00:00
} else if git . IsErrMoreThanOne ( err ) {
if prefixHeadBranch != "" {
log . Info ( "Can't push with %s%s" , prefixHeadBranch , pr . HeadBranch )
return err
}
2022-01-19 23:26:57 +00:00
log . Info ( "Retrying to push with %s%s" , git . BranchPrefix , pr . HeadBranch )
err = pushToBaseRepoHelper ( ctx , pr , git . BranchPrefix )
2021-06-23 21:08:26 +00:00
return err
2020-06-08 18:07:41 +00:00
}
2020-09-15 03:32:31 +00:00
log . Error ( "Unable to push PR head for %s#%d (%-v:%s) due to Error: %v" , pr . BaseRepo . FullName ( ) , pr . Index , pr . BaseRepo , gitRefName , err )
2022-10-24 19:29:17 +00:00
return fmt . Errorf ( "Push: %s:%s %s:%s %w" , pr . HeadRepo . FullName ( ) , pr . HeadBranch , pr . BaseRepo . FullName ( ) , gitRefName , err )
2019-12-15 03:28:51 +00:00
}
return nil
}
2020-01-25 02:48:22 +00:00
2024-03-27 02:34:10 +00:00
// UpdatePullsRefs update all the PRs head file pointers like /refs/pull/1/head so that it will be dependent by other operations
func UpdatePullsRefs ( ctx context . Context , repo * repo_model . Repository , update * repo_module . PushUpdateOptions ) {
branch := update . RefFullName . BranchName ( )
// GetUnmergedPullRequestsByHeadInfo() only return open and unmerged PR.
prs , err := issues_model . GetUnmergedPullRequestsByHeadInfo ( ctx , repo . ID , branch )
if err != nil {
log . Error ( "Find pull requests [head_repo_id: %d, head_branch: %s]: %v" , repo . ID , branch , err )
} else {
for _ , pr := range prs {
log . Trace ( "Updating PR[%d]: composing new test task" , pr . ID )
if pr . Flow == issues_model . PullRequestFlowGithub {
if err := PushToBaseRepo ( ctx , pr ) ; err != nil {
log . Error ( "PushToBaseRepo: %v" , err )
}
}
}
}
}
2021-07-28 09:42:56 +00:00
// UpdateRef update refs/pull/id/head directly for agit flow pull request
2022-06-13 09:37:59 +00:00
func UpdateRef ( ctx context . Context , pr * issues_model . PullRequest ) ( err error ) {
2021-07-28 09:42:56 +00:00
log . Trace ( "UpdateRef[%d]: upgate pull request ref in base repo '%s'" , pr . ID , pr . GetGitRefName ( ) )
2022-11-19 08:12:33 +00:00
if err := pr . LoadBaseRepo ( ctx ) ; err != nil {
2021-07-28 09:42:56 +00:00
log . Error ( "Unable to load base repository for PR[%d] Error: %v" , pr . ID , err )
return err
}
2022-10-23 14:44:45 +00:00
_ , _ , err = git . NewCommand ( ctx , "update-ref" ) . AddDynamicArguments ( pr . GetGitRefName ( ) , pr . HeadCommitID ) . RunStdString ( & git . RunOpts { Dir : pr . BaseRepo . RepoPath ( ) } )
2021-07-28 09:42:56 +00:00
if err != nil {
log . Error ( "Unable to update ref in base repository for PR[%d] Error: %v" , pr . ID , err )
}
return err
}
2020-01-25 02:48:22 +00:00
type errlist [ ] error
func ( errs errlist ) Error ( ) string {
if len ( errs ) > 0 {
var buf strings . Builder
for i , err := range errs {
if i > 0 {
buf . WriteString ( ", " )
}
buf . WriteString ( err . Error ( ) )
}
return buf . String ( )
}
return ""
}
2024-01-17 00:44:56 +00:00
// RetargetChildrenOnMerge retarget children pull requests on merge if possible
func RetargetChildrenOnMerge ( ctx context . Context , doer * user_model . User , pr * issues_model . PullRequest ) error {
if setting . Repository . PullRequest . RetargetChildrenOnMerge && pr . BaseRepoID == pr . HeadRepoID {
return RetargetBranchPulls ( ctx , doer , pr . HeadRepoID , pr . HeadBranch , pr . BaseBranch )
}
return nil
}
// RetargetBranchPulls change target branch for all pull requests whose base branch is the branch
// Both branch and targetBranch must be in the same repo (for security reasons)
func RetargetBranchPulls ( ctx context . Context , doer * user_model . User , repoID int64 , branch , targetBranch string ) error {
prs , err := issues_model . GetUnmergedPullRequestsByBaseInfo ( ctx , repoID , branch )
if err != nil {
return err
}
if err := issues_model . PullRequestList ( prs ) . LoadAttributes ( ctx ) ; err != nil {
return err
}
var errs errlist
for _ , pr := range prs {
if err = pr . Issue . LoadRepo ( ctx ) ; err != nil {
errs = append ( errs , err )
} else if err = ChangeTargetBranch ( ctx , pr , doer , targetBranch ) ; err != nil &&
! issues_model . IsErrIssueIsClosed ( err ) && ! models . IsErrPullRequestHasMerged ( err ) &&
! issues_model . IsErrPullRequestAlreadyExists ( err ) {
errs = append ( errs , err )
}
}
if len ( errs ) > 0 {
return errs
}
return nil
}
2020-01-25 02:48:22 +00:00
// CloseBranchPulls close all the pull requests who's head branch is the branch
2023-07-22 14:14:27 +00:00
func CloseBranchPulls ( ctx context . Context , doer * user_model . User , repoID int64 , branch string ) error {
prs , err := issues_model . GetUnmergedPullRequestsByHeadInfo ( ctx , repoID , branch )
2020-01-25 02:48:22 +00:00
if err != nil {
return err
}
2023-07-22 14:14:27 +00:00
prs2 , err := issues_model . GetUnmergedPullRequestsByBaseInfo ( ctx , repoID , branch )
2020-01-25 02:48:22 +00:00
if err != nil {
return err
}
prs = append ( prs , prs2 ... )
2023-07-22 14:14:27 +00:00
if err := issues_model . PullRequestList ( prs ) . LoadAttributes ( ctx ) ; err != nil {
2020-01-25 02:48:22 +00:00
return err
}
var errs errlist
for _ , pr := range prs {
2023-07-22 14:14:27 +00:00
if err = issue_service . ChangeStatus ( ctx , pr . Issue , doer , "" , true ) ; err != nil && ! issues_model . IsErrPullWasClosed ( err ) && ! issues_model . IsErrDependenciesLeft ( err ) {
2020-01-25 02:48:22 +00:00
errs = append ( errs , err )
}
}
if len ( errs ) > 0 {
return errs
}
return nil
}
2021-03-01 17:39:44 +00:00
// CloseRepoBranchesPulls close all pull requests which head branches are in the given repository, but only whose base repo is not in the given repository
2022-01-19 23:26:57 +00:00
func CloseRepoBranchesPulls ( ctx context . Context , doer * user_model . User , repo * repo_model . Repository ) error {
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.
## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:
Firstly, there are temporary repositories which do not change:
```go
git.OpenRepository(ctx, diskPath)
```
Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:
```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```
Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.
## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.
---------
Co-authored-by: delvh <dev.lh@web.de>
2024-01-27 20:09:51 +00:00
branches , _ , err := gitrepo . GetBranchesByPath ( ctx , repo , 0 , 0 )
2020-01-25 02:48:22 +00:00
if err != nil {
return err
}
var errs errlist
for _ , branch := range branches {
2023-07-22 14:14:27 +00:00
prs , err := issues_model . GetUnmergedPullRequestsByHeadInfo ( ctx , repo . ID , branch . Name )
2020-01-25 02:48:22 +00:00
if err != nil {
return err
}
2023-07-22 14:14:27 +00:00
if err = issues_model . PullRequestList ( prs ) . LoadAttributes ( ctx ) ; err != nil {
2020-01-25 02:48:22 +00:00
return err
}
for _ , pr := range prs {
2021-03-01 17:39:44 +00:00
// If the base repository for this pr is this repository there is no need to close it
// as it is going to be deleted anyway
if pr . BaseRepoID == repo . ID {
continue
}
2023-07-22 14:14:27 +00:00
if err = issue_service . ChangeStatus ( ctx , pr . Issue , doer , "" , true ) ; err != nil && ! issues_model . IsErrPullWasClosed ( err ) {
2020-01-25 02:48:22 +00:00
errs = append ( errs , err )
}
}
}
if len ( errs ) > 0 {
return errs
}
return nil
}
2020-04-10 11:26:37 +00:00
2021-06-25 17:01:43 +00:00
var commitMessageTrailersPattern = regexp . MustCompile ( ` (?:^|\n\n)(?:[\w-]+[ \t]*:[^\n]+\n*(?:[ \t]+[^\n]+\n*)*)+$ ` )
2020-12-21 16:46:14 +00:00
// GetSquashMergeCommitMessages returns the commit messages between head and merge base (if there is one)
2022-06-13 09:37:59 +00:00
func GetSquashMergeCommitMessages ( ctx context . Context , pr * issues_model . PullRequest ) string {
2022-11-19 08:12:33 +00:00
if err := pr . LoadIssue ( ctx ) ; err != nil {
2020-04-10 11:26:37 +00:00
log . Error ( "Cannot load issue %d for PR id %d: Error: %v" , pr . IssueID , pr . ID , err )
return ""
}
2022-11-19 08:12:33 +00:00
if err := pr . Issue . LoadPoster ( ctx ) ; err != nil {
2020-04-10 11:26:37 +00:00
log . Error ( "Cannot load poster %d for pr id %d, index %d Error: %v" , pr . Issue . PosterID , pr . ID , pr . Index , err )
return ""
}
if pr . HeadRepo == nil {
var err error
2022-12-03 02:48:26 +00:00
pr . HeadRepo , err = repo_model . GetRepositoryByID ( ctx , pr . HeadRepoID )
2020-04-10 11:26:37 +00:00
if err != nil {
2022-11-19 08:12:33 +00:00
log . Error ( "GetRepositoryByIdCtx[%d]: %v" , pr . HeadRepoID , err )
2020-04-10 11:26:37 +00:00
return ""
}
}
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.
## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:
Firstly, there are temporary repositories which do not change:
```go
git.OpenRepository(ctx, diskPath)
```
Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:
```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```
Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.
## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.
---------
Co-authored-by: delvh <dev.lh@web.de>
2024-01-27 20:09:51 +00:00
gitRepo , closer , err := gitrepo . RepositoryFromContextOrOpen ( ctx , pr . HeadRepo )
2020-04-10 11:26:37 +00:00
if err != nil {
log . Error ( "Unable to open head repository: Error: %v" , err )
return ""
}
2022-01-19 23:26:57 +00:00
defer closer . Close ( )
2020-04-10 11:26:37 +00:00
2021-07-28 09:42:56 +00:00
var headCommit * git . Commit
2022-06-13 09:37:59 +00:00
if pr . Flow == issues_model . PullRequestFlowGithub {
2021-07-28 09:42:56 +00:00
headCommit , err = gitRepo . GetBranchCommit ( pr . HeadBranch )
} else {
pr . HeadCommitID , err = gitRepo . GetRefCommitID ( pr . GetGitRefName ( ) )
if err != nil {
log . Error ( "Unable to get head commit: %s Error: %v" , pr . GetGitRefName ( ) , err )
return ""
}
headCommit , err = gitRepo . GetCommit ( pr . HeadCommitID )
}
2020-04-10 11:26:37 +00:00
if err != nil {
log . Error ( "Unable to get head commit: %s Error: %v" , pr . HeadBranch , err )
return ""
}
mergeBase , err := gitRepo . GetCommit ( pr . MergeBase )
if err != nil {
log . Error ( "Unable to get merge base commit: %s Error: %v" , pr . MergeBase , err )
return ""
}
limit := setting . Repository . PullRequest . DefaultMergeMessageCommitsLimit
2021-08-09 18:08:51 +00:00
commits , err := gitRepo . CommitsBetweenLimit ( headCommit , mergeBase , limit , 0 )
2020-04-10 11:26:37 +00:00
if err != nil {
log . Error ( "Unable to get commits between: %s %s Error: %v" , pr . HeadBranch , pr . MergeBase , err )
return ""
}
posterSig := pr . Issue . Poster . NewGitSig ( ) . String ( )
2022-10-12 05:18:26 +00:00
uniqueAuthors := make ( container . Set [ string ] )
2021-08-09 18:08:51 +00:00
authors := make ( [ ] string , 0 , len ( commits ) )
2020-04-10 11:26:37 +00:00
stringBuilder := strings . Builder { }
2020-12-21 16:46:14 +00:00
2021-06-18 22:08:22 +00:00
if ! setting . Repository . PullRequest . PopulateSquashCommentWithCommitMessages {
2021-06-25 17:01:43 +00:00
message := strings . TrimSpace ( pr . Issue . Content )
stringBuilder . WriteString ( message )
2021-06-18 22:08:22 +00:00
if stringBuilder . Len ( ) > 0 {
stringBuilder . WriteRune ( '\n' )
2021-06-25 17:01:43 +00:00
if ! commitMessageTrailersPattern . MatchString ( message ) {
stringBuilder . WriteRune ( '\n' )
}
2021-06-18 22:08:22 +00:00
}
2020-12-21 16:46:14 +00:00
}
2020-11-25 20:08:17 +00:00
// commits list is in reverse chronological order
2021-08-09 18:08:51 +00:00
first := true
for i := len ( commits ) - 1 ; i >= 0 ; i -- {
commit := commits [ i ]
2021-06-18 22:08:22 +00:00
if setting . Repository . PullRequest . PopulateSquashCommentWithCommitMessages {
maxSize := setting . Repository . PullRequest . DefaultMergeMessageSize
if maxSize < 0 || stringBuilder . Len ( ) < maxSize {
var toWrite [ ] byte
2021-08-09 18:08:51 +00:00
if first {
first = false
2021-06-18 22:08:22 +00:00
toWrite = [ ] byte ( strings . TrimPrefix ( commit . CommitMessage , pr . Issue . Title ) )
} else {
toWrite = [ ] byte ( commit . CommitMessage )
}
if len ( toWrite ) > maxSize - stringBuilder . Len ( ) && maxSize > - 1 {
toWrite = append ( toWrite [ : maxSize - stringBuilder . Len ( ) ] , "..." ... )
}
if _ , err := stringBuilder . Write ( toWrite ) ; err != nil {
log . Error ( "Unable to write commit message Error: %v" , err )
return ""
}
if _ , err := stringBuilder . WriteRune ( '\n' ) ; err != nil {
log . Error ( "Unable to write commit message Error: %v" , err )
return ""
}
}
}
2020-04-10 11:26:37 +00:00
authorString := commit . Author . String ( )
2022-10-12 05:18:26 +00:00
if uniqueAuthors . Add ( authorString ) && authorString != posterSig {
2023-03-10 03:17:04 +00:00
// Compare use account as well to avoid adding the same author multiple times
// times when email addresses are private or multiple emails are used.
commitUser , _ := user_model . GetUserByEmail ( ctx , commit . Author . Email )
if commitUser == nil || commitUser . ID != pr . Issue . Poster . ID {
authors = append ( authors , authorString )
}
2020-04-10 11:26:37 +00:00
}
}
// Consider collecting the remaining authors
if limit >= 0 && setting . Repository . PullRequest . DefaultMergeMessageAllAuthors {
skip := limit
limit = 30
for {
2021-08-09 18:08:51 +00:00
commits , err := gitRepo . CommitsBetweenLimit ( headCommit , mergeBase , limit , skip )
2020-04-10 11:26:37 +00:00
if err != nil {
log . Error ( "Unable to get commits between: %s %s Error: %v" , pr . HeadBranch , pr . MergeBase , err )
return ""
}
2021-08-09 18:08:51 +00:00
if len ( commits ) == 0 {
2020-04-10 11:26:37 +00:00
break
}
2021-08-09 18:08:51 +00:00
for _ , commit := range commits {
2020-04-10 11:26:37 +00:00
authorString := commit . Author . String ( )
2022-10-12 05:18:26 +00:00
if uniqueAuthors . Add ( authorString ) && authorString != posterSig {
2023-03-10 03:17:04 +00:00
commitUser , _ := user_model . GetUserByEmail ( ctx , commit . Author . Email )
if commitUser == nil || commitUser . ID != pr . Issue . Poster . ID {
authors = append ( authors , authorString )
}
2020-04-10 11:26:37 +00:00
}
}
2020-11-27 20:00:52 +00:00
skip += limit
2020-04-10 11:26:37 +00:00
}
}
for _ , author := range authors {
2023-08-28 16:43:16 +00:00
if _ , err := stringBuilder . WriteString ( "Co-authored-by: " ) ; err != nil {
2020-04-10 11:26:37 +00:00
log . Error ( "Unable to write to string builder Error: %v" , err )
return ""
}
2023-08-28 16:43:16 +00:00
if _ , err := stringBuilder . WriteString ( author ) ; err != nil {
2020-04-10 11:26:37 +00:00
log . Error ( "Unable to write to string builder Error: %v" , err )
return ""
}
if _ , err := stringBuilder . WriteRune ( '\n' ) ; err != nil {
log . Error ( "Unable to write to string builder Error: %v" , err )
return ""
}
}
return stringBuilder . String ( )
}
2022-04-26 22:40:01 +00:00
// GetIssuesLastCommitStatus returns a map of issue ID to the most recent commit's latest status
2022-06-13 09:37:59 +00:00
func GetIssuesLastCommitStatus ( ctx context . Context , issues issues_model . IssueList ) ( map [ int64 ] * git_model . CommitStatus , error ) {
2022-04-26 22:40:01 +00:00
_ , lastStatus , err := GetIssuesAllCommitStatus ( ctx , issues )
return lastStatus , err
}
// GetIssuesAllCommitStatus returns a map of issue ID to a list of all statuses for the most recent commit as well as a map of issue ID to only the commit's latest status
2022-06-13 09:37:59 +00:00
func GetIssuesAllCommitStatus ( ctx context . Context , issues issues_model . IssueList ) ( map [ int64 ] [ ] * git_model . CommitStatus , map [ int64 ] * git_model . CommitStatus , error ) {
2022-11-19 08:12:33 +00:00
if err := issues . LoadPullRequests ( ctx ) ; err != nil {
2022-04-26 22:40:01 +00:00
return nil , nil , err
2021-04-15 17:34:43 +00:00
}
2022-11-19 08:12:33 +00:00
if _ , err := issues . LoadRepositories ( ctx ) ; err != nil {
2022-04-26 22:40:01 +00:00
return nil , nil , err
2021-04-15 17:34:43 +00:00
}
var (
gitRepos = make ( map [ int64 ] * git . Repository )
2022-06-12 15:51:54 +00:00
res = make ( map [ int64 ] [ ] * git_model . CommitStatus )
lastRes = make ( map [ int64 ] * git_model . CommitStatus )
2021-04-15 17:34:43 +00:00
err error
)
defer func ( ) {
for _ , gitRepo := range gitRepos {
gitRepo . Close ( )
}
} ( )
for _ , issue := range issues {
if ! issue . IsPull {
continue
}
gitRepo , ok := gitRepos [ issue . RepoID ]
if ! ok {
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.
## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:
Firstly, there are temporary repositories which do not change:
```go
git.OpenRepository(ctx, diskPath)
```
Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:
```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```
Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.
## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.
---------
Co-authored-by: delvh <dev.lh@web.de>
2024-01-27 20:09:51 +00:00
gitRepo , err = gitrepo . OpenRepository ( ctx , issue . Repo )
2021-04-15 17:34:43 +00:00
if err != nil {
2021-12-16 19:01:14 +00:00
log . Error ( "Cannot open git repository %-v for issue #%d[%d]. Error: %v" , issue . Repo , issue . Index , issue . ID , err )
continue
2021-04-15 17:34:43 +00:00
}
gitRepos [ issue . RepoID ] = gitRepo
}
2023-10-14 08:37:24 +00:00
statuses , lastStatus , err := getAllCommitStatus ( ctx , gitRepo , issue . PullRequest )
2021-04-15 17:34:43 +00:00
if err != nil {
2022-04-26 22:40:01 +00:00
log . Error ( "getAllCommitStatus: cant get commit statuses of pull [%d]: %v" , issue . PullRequest . ID , err )
2021-05-04 12:03:02 +00:00
continue
2021-04-15 17:34:43 +00:00
}
2022-04-26 22:40:01 +00:00
res [ issue . PullRequest . ID ] = statuses
lastRes [ issue . PullRequest . ID ] = lastStatus
2021-04-15 17:34:43 +00:00
}
2022-04-26 22:40:01 +00:00
return res , lastRes , nil
2021-04-15 17:34:43 +00:00
}
2022-04-26 22:40:01 +00:00
// getAllCommitStatus get pr's commit statuses.
2023-10-14 08:37:24 +00:00
func getAllCommitStatus ( ctx context . Context , gitRepo * git . Repository , pr * issues_model . PullRequest ) ( statuses [ ] * git_model . CommitStatus , lastStatus * git_model . CommitStatus , err error ) {
2022-04-26 22:40:01 +00:00
sha , shaErr := gitRepo . GetRefCommitID ( pr . GetGitRefName ( ) )
if shaErr != nil {
return nil , nil , shaErr
2020-04-10 11:26:37 +00:00
}
2024-03-22 12:53:52 +00:00
statuses , _ , err = git_model . GetLatestCommitStatus ( ctx , pr . BaseRepo . ID , sha , db . ListOptionsAll )
2022-06-12 15:51:54 +00:00
lastStatus = git_model . CalcCommitStatus ( statuses )
2022-04-26 22:40:01 +00:00
return statuses , lastStatus , err
2020-04-10 11:26:37 +00:00
}
// IsHeadEqualWithBranch returns if the commits of branchName are available in pull request head
2022-06-13 09:37:59 +00:00
func IsHeadEqualWithBranch ( ctx context . Context , pr * issues_model . PullRequest , branchName string ) ( bool , error ) {
2020-04-10 11:26:37 +00:00
var err error
2022-11-19 08:12:33 +00:00
if err = pr . LoadBaseRepo ( ctx ) ; err != nil {
2020-04-10 11:26:37 +00:00
return false , err
}
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.
## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:
Firstly, there are temporary repositories which do not change:
```go
git.OpenRepository(ctx, diskPath)
```
Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:
```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```
Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.
## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.
---------
Co-authored-by: delvh <dev.lh@web.de>
2024-01-27 20:09:51 +00:00
baseGitRepo , closer , err := gitrepo . RepositoryFromContextOrOpen ( ctx , pr . BaseRepo )
2020-04-10 11:26:37 +00:00
if err != nil {
return false , err
}
2022-01-19 23:26:57 +00:00
defer closer . Close ( )
2021-01-06 19:23:57 +00:00
2020-04-10 11:26:37 +00:00
baseCommit , err := baseGitRepo . GetBranchCommit ( branchName )
if err != nil {
return false , err
}
2022-11-19 08:12:33 +00:00
if err = pr . LoadHeadRepo ( ctx ) ; err != nil {
2020-04-10 11:26:37 +00:00
return false , err
}
2022-01-19 23:26:57 +00:00
var headGitRepo * git . Repository
if pr . HeadRepoID == pr . BaseRepoID {
headGitRepo = baseGitRepo
} else {
var closer io . Closer
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.
## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:
Firstly, there are temporary repositories which do not change:
```go
git.OpenRepository(ctx, diskPath)
```
Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:
```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```
Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.
## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.
---------
Co-authored-by: delvh <dev.lh@web.de>
2024-01-27 20:09:51 +00:00
headGitRepo , closer , err = gitrepo . RepositoryFromContextOrOpen ( ctx , pr . HeadRepo )
2022-01-19 23:26:57 +00:00
if err != nil {
return false , err
}
defer closer . Close ( )
2020-04-10 11:26:37 +00:00
}
2021-01-06 19:23:57 +00:00
2021-07-28 09:42:56 +00:00
var headCommit * git . Commit
2022-06-13 09:37:59 +00:00
if pr . Flow == issues_model . PullRequestFlowGithub {
2021-07-28 09:42:56 +00:00
headCommit , err = headGitRepo . GetBranchCommit ( pr . HeadBranch )
if err != nil {
return false , err
}
} else {
pr . HeadCommitID , err = baseGitRepo . GetRefCommitID ( pr . GetGitRefName ( ) )
if err != nil {
return false , err
}
if headCommit , err = baseGitRepo . GetCommit ( pr . HeadCommitID ) ; err != nil {
return false , err
}
2020-04-10 11:26:37 +00:00
}
return baseCommit . HasPreviousCommit ( headCommit . ID )
}
2023-07-28 19:18:12 +00:00
type CommitInfo struct {
Summary string ` json:"summary" `
CommitterOrAuthorName string ` json:"committer_or_author_name" `
ID string ` json:"id" `
ShortSha string ` json:"short_sha" `
Time string ` json:"time" `
}
// GetPullCommits returns all commits on given pull request and the last review commit sha
2024-10-01 01:58:55 +00:00
// Attention: The last review commit sha must be from the latest review whose commit id is not empty.
// So the type of the latest review cannot be "ReviewTypeRequest".
2023-07-28 19:18:12 +00:00
func GetPullCommits ( ctx * gitea_context . Context , issue * issues_model . Issue ) ( [ ] CommitInfo , string , error ) {
pull := issue . PullRequest
baseGitRepo := ctx . Repo . GitRepo
if err := pull . LoadBaseRepo ( ctx ) ; err != nil {
return nil , "" , err
}
baseBranch := pull . BaseBranch
if pull . HasMerged {
baseBranch = pull . MergeBase
}
prInfo , err := baseGitRepo . GetCompareInfo ( pull . BaseRepo . RepoPath ( ) , baseBranch , pull . GetGitRefName ( ) , true , false )
if err != nil {
return nil , "" , err
}
commits := make ( [ ] CommitInfo , 0 , len ( prInfo . Commits ) )
for _ , commit := range prInfo . Commits {
var committerOrAuthorName string
var commitTime time . Time
2024-04-05 00:51:53 +00:00
if commit . Author != nil {
2023-07-28 19:18:12 +00:00
committerOrAuthorName = commit . Author . Name
commitTime = commit . Author . When
2024-04-05 00:51:53 +00:00
} else {
committerOrAuthorName = commit . Committer . Name
commitTime = commit . Committer . When
2023-07-28 19:18:12 +00:00
}
commits = append ( commits , CommitInfo {
Summary : commit . Summary ( ) ,
CommitterOrAuthorName : committerOrAuthorName ,
ID : commit . ID . String ( ) ,
ShortSha : base . ShortSha ( commit . ID . String ( ) ) ,
Time : commitTime . Format ( time . RFC3339 ) ,
} )
}
var lastReviewCommitID string
if ctx . IsSigned {
// get last review of current user and store information in context (if available)
lastreview , err := issues_model . FindLatestReviews ( ctx , issues_model . FindReviewOptions {
IssueID : issue . ID ,
ReviewerID : ctx . Doer . ID ,
2024-10-01 01:58:55 +00:00
Types : [ ] issues_model . ReviewType {
issues_model . ReviewTypeApprove ,
issues_model . ReviewTypeComment ,
issues_model . ReviewTypeReject ,
} ,
2023-07-28 19:18:12 +00:00
} )
if err != nil && ! issues_model . IsErrReviewNotExist ( err ) {
return nil , "" , err
}
if len ( lastreview ) > 0 {
lastReviewCommitID = lastreview [ 0 ] . CommitID
}
}
return commits , lastReviewCommitID , nil
}