From 0abb5633e34fd14c2d49de0b4c98f7ba7d98a37e Mon Sep 17 00:00:00 2001 From: yp05327 <576951401@qq.com> Date: Mon, 11 Dec 2023 15:19:57 +0900 Subject: [PATCH] Fix commit status in repo list (#28412) Before: ![image](https://github.com/go-gitea/gitea/assets/18380374/00edf23a-aee1-4177-a12c-bd03ae14e65e) ![image](https://github.com/go-gitea/gitea/assets/18380374/0663e443-682c-4a68-b14e-a0fa0e4c3716) `TestOrg/testactions` does have commit status, but won't display in `All` After: ![image](https://github.com/go-gitea/gitea/assets/18380374/7231db29-9c4e-484f-afa2-87db19be19b8) Same to #26179. --- models/git/commit_status.go | 4 +++- routers/web/repo/repo.go | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/models/git/commit_status.go b/models/git/commit_status.go index acb0110200..097ce01c14 100644 --- a/models/git/commit_status.go +++ b/models/git/commit_status.go @@ -323,7 +323,9 @@ func GetLatestCommitStatusForPairs(ctx context.Context, repoIDsToLatestCommitSHA Select("max( id ) as id, repo_id"). GroupBy("context_hash, repo_id").OrderBy("max( id ) desc") - sess = db.SetSessionPagination(sess, &listOptions) + if !listOptions.IsListAll() { + sess = db.SetSessionPagination(sess, &listOptions) + } err := sess.Find(&results) if err != nil { diff --git a/routers/web/repo/repo.go b/routers/web/repo/repo.go index b3b6b48871..482fbaac2b 100644 --- a/routers/web/repo/repo.go +++ b/routers/web/repo/repo.go @@ -606,7 +606,7 @@ func SearchRepo(ctx *context.Context) { } // call the database O(1) times to get the commit statuses for all repos - repoToItsLatestCommitStatuses, err := git_model.GetLatestCommitStatusForPairs(ctx, repoIDsToLatestCommitSHAs, db.ListOptions{}) + repoToItsLatestCommitStatuses, err := git_model.GetLatestCommitStatusForPairs(ctx, repoIDsToLatestCommitSHAs, db.ListOptionsAll) if err != nil { log.Error("GetLatestCommitStatusForPairs: %v", err) return