mirror of
				https://github.com/go-gitea/gitea
				synced 2025-10-31 19:38:23 +00:00 
			
		
		
		
	Remove git.Command.Run and git.Command.RunInDir* (#19280)
				
					
				
			Follows #19266, #8553, Close #18553, now there are only three `Run..(&RunOpts{})` functions. * before: `stdout, err := RunInDir(path)` * now: `stdout, _, err := RunStdString(&git.RunOpts{Dir:path})`
This commit is contained in:
		| @@ -111,7 +111,7 @@ func ForkRepository(ctx context.Context, doer, owner *user_model.User, opts Fork | ||||
| 		if stdout, _, err := git.NewCommand(txCtx, | ||||
| 			"clone", "--bare", oldRepoPath, repoPath). | ||||
| 			SetDescription(fmt.Sprintf("ForkRepository(git clone): %s to %s", opts.BaseRepo.FullName(), repo.FullName())). | ||||
| 			RunWithContextBytes(&git.RunContext{Timeout: 10 * time.Minute}); err != nil { | ||||
| 			RunStdBytes(&git.RunOpts{Timeout: 10 * time.Minute}); err != nil { | ||||
| 			log.Error("Fork Repository (git clone) Failed for %v (from %v):\nStdout: %s\nError: %v", repo, opts.BaseRepo, stdout, err) | ||||
| 			return fmt.Errorf("git clone: %v", err) | ||||
| 		} | ||||
| @@ -120,9 +120,9 @@ func ForkRepository(ctx context.Context, doer, owner *user_model.User, opts Fork | ||||
| 			return fmt.Errorf("checkDaemonExportOK: %v", err) | ||||
| 		} | ||||
|  | ||||
| 		if stdout, err := git.NewCommand(txCtx, "update-server-info"). | ||||
| 		if stdout, _, err := git.NewCommand(txCtx, "update-server-info"). | ||||
| 			SetDescription(fmt.Sprintf("ForkRepository(git update-server-info): %s", repo.FullName())). | ||||
| 			RunInDir(repoPath); err != nil { | ||||
| 			RunStdString(&git.RunOpts{Dir: repoPath}); err != nil { | ||||
| 			log.Error("Fork Repository (git update-server-info) failed for %v:\nStdout: %s\nError: %v", repo, stdout, err) | ||||
| 			return fmt.Errorf("git update-server-info: %v", err) | ||||
| 		} | ||||
|   | ||||
		Reference in New Issue
	
	Block a user