tdsds.com/gitea
1
1
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2025-08-01 07:08:36 +00:00
Code Releases Activity

[Backport] [API] Allow only specific Colums to be updated on Issue (#9539) (#9580)

Browse Source 
* Fix #9189 - API Allow only specific Colums to be updated on Issue (#9539)

* dont insert "-1" in any case to issue.poster_id

* Make sure API cant override importand fields

* code format

* add Test for IssueEdit

* load milestone and return it on IssueEdit via API

* extend Test for TestAPIEditIssue

* fix TEST

* make sure Poster is loaded

* keep code format on backport as it is
This commit is contained in:
6543
2020-01-02 08:38:42 +01:00
committed by techknowlogick
parent cb3fe4cbf1
commit 17c691f8aa
7 changed files with 116 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
routers/api/v1/repo/issue.go
View File

@@ -352,8 +352,8 @@ func EditIssue(ctx *context.APIContext, form api.EditIssueOption) {
}
}
if err = models.UpdateIssue(issue); err != nil {
ctx.Error(500, "UpdateIssue", err)
if err = models.UpdateIssueByAPI(issue); err != nil {
ctx.InternalServerError(err)
return
}
if form.State != nil {
@@ -372,7 +372,11 @@ func EditIssue(ctx *context.APIContext, form api.EditIssueOption) {
// Refetch from database to assign some automatic values
issue, err = models.GetIssueByID(issue.ID)
if err != nil {
ctx.Error(500, "GetIssueByID", err)
ctx.InternalServerError(err)
return
}
if err = issue.LoadMilestone(); err != nil {
ctx.InternalServerError(err)
return
}
ctx.JSON(201, issue.APIFormat())

4
routers/api/v1/repo/pull.go
View File

@@ -420,8 +420,8 @@ func EditPullRequest(ctx *context.APIContext, form api.EditPullRequestOption) {
}
}
if err = models.UpdateIssue(issue); err != nil {
ctx.Error(500, "UpdateIssue", err)
if err = models.UpdateIssueByAPI(issue); err != nil {
ctx.InternalServerError(err)
return
}
if form.State != nil {