From 18dd49a4abadb62c1cc686cbfb8aacfe95b47001 Mon Sep 17 00:00:00 2001 From: zeripath Date: Fri, 6 May 2022 12:01:08 +0200 Subject: [PATCH] Prevent NPE when checking repo units if the user is nil (#19625) (#19630) Backport #19625 CheckRepoUnitUser should tolerate nil users. Fix #19613 Signed-off-by: Andrew Thornton Co-authored-by: wxiaoguang --- models/repo.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/models/repo.go b/models/repo.go index e82fd5dedf..29bb196e8e 100644 --- a/models/repo.go +++ b/models/repo.go @@ -132,7 +132,7 @@ func CheckRepoUnitUser(repo *repo_model.Repository, user *user_model.User, unitT } func checkRepoUnitUser(ctx context.Context, repo *repo_model.Repository, user *user_model.User, unitType unit.Type) bool { - if user.IsAdmin { + if user != nil && user.IsAdmin { return true } perm, err := getUserRepoPermission(ctx, repo, user)