tdsds.com/gitea
1
1
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2025-07-09 20:17:21 +00:00
Code Releases Activity

Fix stange behavior of DownloadPullDiffOrPatch in incorect index (#17223)

Browse Source 
Fix GetPullRequestByIndex by validate index > 1

Signed-off-by: Danila Kryukov <pricly_yellow@dismail.de>

Co-authored-by: a1012112796 <1012112796@qq.com>
This commit is contained in:
pricly-yellow
2021-10-05 21:41:48 +07:00
committed by GitHub
parent f4ea6cc4b4
commit 20eaca6d05
3 changed files with 11 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
models/pull.go
View File

@ -522,6 +522,9 @@ func GetLatestPullRequestByHeadInfo(repoID int64, branch string) (*PullRequest,
// GetPullRequestByIndex returns a pull request by the given index
func GetPullRequestByIndex(repoID, index int64) (*PullRequest, error) {
if index < 1 {
return nil, ErrPullRequestNotExist{}
}
pr := &PullRequest{
BaseRepoID: repoID,
Index: index,