mirror of
https://github.com/go-gitea/gitea
synced 2025-07-22 18:28:37 +00:00
[API] generalize list header (#16551)
* Add info about list endpoints to CONTRIBUTING.md * Let all list endpoints return X-Total-Count header * Add TODOs for GetCombinedCommitStatusByRef * Fix models/issue_stopwatch.go * Rrefactor models.ListDeployKeys * Introduce helper func and use them for SetLinkHeader related func
This commit is contained in:
@@ -378,7 +378,7 @@ func Issues(ctx *context.Context) {
|
||||
|
||||
var err error
|
||||
// Get milestones
|
||||
ctx.Data["Milestones"], err = models.GetMilestones(models.GetMilestonesOption{
|
||||
ctx.Data["Milestones"], _, err = models.GetMilestones(models.GetMilestonesOption{
|
||||
RepoID: ctx.Repo.Repository.ID,
|
||||
State: api.StateType(ctx.FormString("state")),
|
||||
})
|
||||
@@ -395,7 +395,7 @@ func Issues(ctx *context.Context) {
|
||||
// RetrieveRepoMilestonesAndAssignees find all the milestones and assignees of a repository
|
||||
func RetrieveRepoMilestonesAndAssignees(ctx *context.Context, repo *models.Repository) {
|
||||
var err error
|
||||
ctx.Data["OpenMilestones"], err = models.GetMilestones(models.GetMilestonesOption{
|
||||
ctx.Data["OpenMilestones"], _, err = models.GetMilestones(models.GetMilestonesOption{
|
||||
RepoID: repo.ID,
|
||||
State: api.StateOpen,
|
||||
})
|
||||
@@ -403,7 +403,7 @@ func RetrieveRepoMilestonesAndAssignees(ctx *context.Context, repo *models.Repos
|
||||
ctx.ServerError("GetMilestones", err)
|
||||
return
|
||||
}
|
||||
ctx.Data["ClosedMilestones"], err = models.GetMilestones(models.GetMilestonesOption{
|
||||
ctx.Data["ClosedMilestones"], _, err = models.GetMilestones(models.GetMilestonesOption{
|
||||
RepoID: repo.ID,
|
||||
State: api.StateClosed,
|
||||
})
|
||||
@@ -1265,7 +1265,7 @@ func ViewIssue(ctx *context.Context) {
|
||||
} else {
|
||||
ctx.Data["CanUseTimetracker"] = false
|
||||
}
|
||||
if ctx.Data["WorkingUsers"], err = models.TotalTimes(models.FindTrackedTimesOptions{IssueID: issue.ID}); err != nil {
|
||||
if ctx.Data["WorkingUsers"], err = models.TotalTimes(&models.FindTrackedTimesOptions{IssueID: issue.ID}); err != nil {
|
||||
ctx.ServerError("TotalTimes", err)
|
||||
return
|
||||
}
|
||||
@@ -2584,8 +2584,8 @@ func handleTeamMentions(ctx *context.Context) {
|
||||
}
|
||||
|
||||
if isAdmin {
|
||||
if err := ctx.Repo.Owner.GetTeams(&models.SearchTeamOptions{}); err != nil {
|
||||
ctx.ServerError("GetTeams", err)
|
||||
if err := ctx.Repo.Owner.LoadTeams(); err != nil {
|
||||
ctx.ServerError("LoadTeams", err)
|
||||
return
|
||||
}
|
||||
} else {
|
||||
|
Reference in New Issue
Block a user