tdsds.com/gitea
1
1
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2025-10-31 03:18:24 +00:00
Code Releases Activity

make commit-statuses popup can be shown correctly. (#17447)

Browse Source 
Close #17443

Maybe we do not need to backport this PR, the bug doesn't break daily usage.

After the fix, the commit statuses popup can show a lot of lines with scroll bars:

![image](https://user-images.githubusercontent.com/2114189/139026160-f01b484c-6207-494a-a190-a6dd184ceb2b.png)
This commit is contained in:
wxiaoguang
2021-10-28 09:34:18 +08:00
committed by GitHub
parent 4f00de1458
commit 2b2eb5d0ad
2 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
web_src/js/features/repo-legacy.js
View File

@@ -267,10 +267,13 @@ export async function initRepository() {
// Commit statuses // Commit statuses
$('.commit-statuses-trigger').each(function () { $('.commit-statuses-trigger').each(function () {
const positionRight = $('.repository.file.list').length > 0 || $('.repository.diff').length > 0;
const popupPosition = positionRight ? 'right center' : 'left center';
$(this) $(this)
.popup({ .popup({
on: 'click', on: 'click',
position: ($('.repository.file.list').length > 0 ? 'right center' : 'left center'), lastResort: popupPosition, // prevent error message "Popup does not fit within the boundaries of the viewport"
position: popupPosition,
}); });
}); });

17
web_src/less/_repository.less
View File

@@ -1,6 +1,19 @@
.repository { .repository {
.commit-statuses .list > .item { .popup.commit-statuses {
line-height: 2; // we had better limit the max size of the popup, and add scroll bars if the content size is too large.
// otherwise some part of the popup will be hidden by viewport boundary
max-height: 45vh;
max-width: 60vw;
overflow: auto;
padding: 0;
.list {
padding: .8em; // to make the scrollbar align to the border, we move the padding from outer `.popup` to this inside `.list`
> .item {
line-height: 2;
}
}
} }
.repo-header { .repo-header {