mirror of
				https://github.com/go-gitea/gitea
				synced 2025-10-31 03:18:24 +00:00 
			
		
		
		
	Fix various bugs (#35684)
1. Fix incorrect column in `applySubscribedCondition`, add a test 2. Fix debian version parsing, add more tests fix #35695 3. Fix log level for HTTP errors, fix #35651 4. Fix abused "panic" handler in API `Migrate` 5. Fix the redirection from PR to issue, add a test 6. Fix Actions variable & secret name validation, add more tests * envNameCIRegexMatch is unnecessary, removed * validating in "delete" function doesn't make sense, removed 7. Fix incorrect link in release email --------- Signed-off-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: delvh <dev.lh@web.de>
This commit is contained in:
		
							
								
								
									
										29
									
								
								services/secrets/validation_test.go
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										29
									
								
								services/secrets/validation_test.go
									
									
									
									
									
										Normal file
									
								
							| @@ -0,0 +1,29 @@ | ||||
| // Copyright 2025 The Gitea Authors. All rights reserved. | ||||
| // SPDX-License-Identifier: MIT | ||||
|  | ||||
| package secrets | ||||
|  | ||||
| import ( | ||||
| 	"testing" | ||||
|  | ||||
| 	"github.com/stretchr/testify/assert" | ||||
| ) | ||||
|  | ||||
| func TestValidateName(t *testing.T) { | ||||
| 	cases := []struct { | ||||
| 		name  string | ||||
| 		valid bool | ||||
| 	}{ | ||||
| 		{"FOO", true}, | ||||
| 		{"FOO1_BAR2", true}, | ||||
| 		{"_FOO", true}, // really? why support this | ||||
| 		{"1FOO", false}, | ||||
| 		{"giteA_xx", false}, | ||||
| 		{"githuB_xx", false}, | ||||
| 		{"cI", false}, | ||||
| 	} | ||||
| 	for _, c := range cases { | ||||
| 		err := ValidateName(c.name) | ||||
| 		assert.Equal(t, c.valid, err == nil, "ValidateName(%q)", c.name) | ||||
| 	} | ||||
| } | ||||
		Reference in New Issue
	
	Block a user