mirror of
				https://github.com/go-gitea/gitea
				synced 2025-11-04 05:18:25 +00:00 
			
		
		
		
	Improve <SvgIcon> to make it output svg node and optimize performance (#23570)
				
					
				
			Before, the Vue `<SvgIcon>` always outputs DOM nodes like: 
```html
<span class="outer-class">
    <svg class="class-name-defined" ...></svg>
</span>
```
The `span` is redundant and I guess such layout and the inconsistent
`class/class-name` attributes would cause bugs sooner or later.
This PR makes the `<SvgIcon>` clear, and it's faster than before,
because it doesn't need to parse the whole SVG string.
Before: 
<details>

</details>
After:

---------
Co-authored-by: silverwind <me@silverwind.io>
			
			
This commit is contained in:
		@@ -3,7 +3,7 @@
 | 
			
		||||
    <div v-if="loading" class="ui active centered inline loader"/>
 | 
			
		||||
    <div v-if="!loading && issue !== null">
 | 
			
		||||
      <p><small>{{ issue.repository.full_name }} on {{ createdAt }}</small></p>
 | 
			
		||||
      <p><svg-icon :name="icon" :class="[color]" /> <strong>{{ issue.title }}</strong> #{{ issue.number }}</p>
 | 
			
		||||
      <p><svg-icon :name="icon" :class="['text', color]" /> <strong>{{ issue.title }}</strong> #{{ issue.number }}</p>
 | 
			
		||||
      <p>{{ body }}</p>
 | 
			
		||||
      <div>
 | 
			
		||||
        <div
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user