mirror of
				https://github.com/go-gitea/gitea
				synced 2025-11-03 21:08:25 +00:00 
			
		
		
		
	Refactor render system (#32492)
There were too many patches to the Render system, it's really difficult to make further improvements. This PR clears the legacy problems and fix TODOs. 1. Rename `RenderContext.Type` to `RenderContext.MarkupType` to clarify its usage. 2. Use `ContentMode` to replace `meta["mode"]` and `IsWiki`, to clarify the rendering behaviors. 3. Use "wiki" mode instead of "mode=gfm + wiki=true" 4. Merge `renderByType` and `renderByFile` 5. Add more comments ---- The problem of "mode=document": in many cases it is not set, so many non-comment places use comment's hard line break incorrectly
This commit is contained in:
		@@ -20,7 +20,7 @@ func ResolveLink(ctx *RenderContext, link, userContentAnchorPrefix string) (resu
 | 
			
		||||
	isAnchorFragment := link != "" && link[0] == '#'
 | 
			
		||||
	if !isAnchorFragment && !IsFullURLString(link) {
 | 
			
		||||
		linkBase := ctx.Links.Base
 | 
			
		||||
		if ctx.IsWiki {
 | 
			
		||||
		if ctx.ContentMode == RenderContentAsWiki {
 | 
			
		||||
			// no need to check if the link should be resolved as a wiki link or a wiki raw link
 | 
			
		||||
			// just use wiki link here and it will be redirected to a wiki raw link if necessary
 | 
			
		||||
			linkBase = ctx.Links.WikiLink()
 | 
			
		||||
@@ -147,7 +147,7 @@ func shortLinkProcessor(ctx *RenderContext, node *html.Node) {
 | 
			
		||||
		}
 | 
			
		||||
		if image {
 | 
			
		||||
			if !absoluteLink {
 | 
			
		||||
				link = util.URLJoin(ctx.Links.ResolveMediaLink(ctx.IsWiki), link)
 | 
			
		||||
				link = util.URLJoin(ctx.Links.ResolveMediaLink(ctx.ContentMode == RenderContentAsWiki), link)
 | 
			
		||||
			}
 | 
			
		||||
			title := props["title"]
 | 
			
		||||
			if title == "" {
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user