mirror of
				https://github.com/go-gitea/gitea
				synced 2025-11-03 21:08:25 +00:00 
			
		
		
		
	Refactor names (#31405)
This PR only does "renaming": * `Route` should be `Router` (and chi router is also called "router") * `Params` should be `PathParam` (to distingush it from URL query param, and to match `FormString`) * Use lower case for private functions to avoid exposing or abusing
This commit is contained in:
		@@ -226,7 +226,7 @@ func SearchServiceV3(ctx *context.Context) {
 | 
			
		||||
 | 
			
		||||
// https://docs.microsoft.com/en-us/nuget/api/registration-base-url-resource#registration-index
 | 
			
		||||
func RegistrationIndex(ctx *context.Context) {
 | 
			
		||||
	packageName := ctx.Params("id")
 | 
			
		||||
	packageName := ctx.PathParam("id")
 | 
			
		||||
 | 
			
		||||
	pvs, err := packages_model.GetVersionsByPackageName(ctx, ctx.Package.Owner.ID, packages_model.TypeNuGet, packageName)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
@@ -254,8 +254,8 @@ func RegistrationIndex(ctx *context.Context) {
 | 
			
		||||
 | 
			
		||||
// https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Core/NuGet.Protocol/LegacyFeed/V2FeedQueryBuilder.cs
 | 
			
		||||
func RegistrationLeafV2(ctx *context.Context) {
 | 
			
		||||
	packageName := ctx.Params("id")
 | 
			
		||||
	packageVersion := ctx.Params("version")
 | 
			
		||||
	packageName := ctx.PathParam("id")
 | 
			
		||||
	packageVersion := ctx.PathParam("version")
 | 
			
		||||
 | 
			
		||||
	pv, err := packages_model.GetVersionByNameAndVersion(ctx, ctx.Package.Owner.ID, packages_model.TypeNuGet, packageName, packageVersion)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
@@ -283,8 +283,8 @@ func RegistrationLeafV2(ctx *context.Context) {
 | 
			
		||||
 | 
			
		||||
// https://docs.microsoft.com/en-us/nuget/api/registration-base-url-resource#registration-leaf
 | 
			
		||||
func RegistrationLeafV3(ctx *context.Context) {
 | 
			
		||||
	packageName := ctx.Params("id")
 | 
			
		||||
	packageVersion := strings.TrimSuffix(ctx.Params("version"), ".json")
 | 
			
		||||
	packageName := ctx.PathParam("id")
 | 
			
		||||
	packageVersion := strings.TrimSuffix(ctx.PathParam("version"), ".json")
 | 
			
		||||
 | 
			
		||||
	pv, err := packages_model.GetVersionByNameAndVersion(ctx, ctx.Package.Owner.ID, packages_model.TypeNuGet, packageName, packageVersion)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
@@ -381,7 +381,7 @@ func EnumeratePackageVersionsV2Count(ctx *context.Context) {
 | 
			
		||||
 | 
			
		||||
// https://docs.microsoft.com/en-us/nuget/api/package-base-address-resource#enumerate-package-versions
 | 
			
		||||
func EnumeratePackageVersionsV3(ctx *context.Context) {
 | 
			
		||||
	packageName := ctx.Params("id")
 | 
			
		||||
	packageName := ctx.PathParam("id")
 | 
			
		||||
 | 
			
		||||
	pvs, err := packages_model.GetVersionsByPackageName(ctx, ctx.Package.Owner.ID, packages_model.TypeNuGet, packageName)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
@@ -401,9 +401,9 @@ func EnumeratePackageVersionsV3(ctx *context.Context) {
 | 
			
		||||
// https://learn.microsoft.com/en-us/nuget/api/package-base-address-resource#download-package-manifest-nuspec
 | 
			
		||||
// https://learn.microsoft.com/en-us/nuget/api/package-base-address-resource#download-package-content-nupkg
 | 
			
		||||
func DownloadPackageFile(ctx *context.Context) {
 | 
			
		||||
	packageName := ctx.Params("id")
 | 
			
		||||
	packageVersion := ctx.Params("version")
 | 
			
		||||
	filename := ctx.Params("filename")
 | 
			
		||||
	packageName := ctx.PathParam("id")
 | 
			
		||||
	packageVersion := ctx.PathParam("version")
 | 
			
		||||
	filename := ctx.PathParam("filename")
 | 
			
		||||
 | 
			
		||||
	s, u, pf, err := packages_service.GetFileStreamByPackageNameAndVersion(
 | 
			
		||||
		ctx,
 | 
			
		||||
@@ -643,9 +643,9 @@ func processUploadedFile(ctx *context.Context, expectedType nuget_module.Package
 | 
			
		||||
 | 
			
		||||
// https://github.com/dotnet/symstore/blob/main/docs/specs/Simple_Symbol_Query_Protocol.md#request
 | 
			
		||||
func DownloadSymbolFile(ctx *context.Context) {
 | 
			
		||||
	filename := ctx.Params("filename")
 | 
			
		||||
	guid := ctx.Params("guid")[:32]
 | 
			
		||||
	filename2 := ctx.Params("filename2")
 | 
			
		||||
	filename := ctx.PathParam("filename")
 | 
			
		||||
	guid := ctx.PathParam("guid")[:32]
 | 
			
		||||
	filename2 := ctx.PathParam("filename2")
 | 
			
		||||
 | 
			
		||||
	if filename != filename2 {
 | 
			
		||||
		apiError(ctx, http.StatusBadRequest, nil)
 | 
			
		||||
@@ -685,8 +685,8 @@ func DownloadSymbolFile(ctx *context.Context) {
 | 
			
		||||
// DeletePackage hard deletes the package
 | 
			
		||||
// https://docs.microsoft.com/en-us/nuget/api/package-publish-resource#delete-a-package
 | 
			
		||||
func DeletePackage(ctx *context.Context) {
 | 
			
		||||
	packageName := ctx.Params("id")
 | 
			
		||||
	packageVersion := ctx.Params("version")
 | 
			
		||||
	packageName := ctx.PathParam("id")
 | 
			
		||||
	packageVersion := ctx.PathParam("version")
 | 
			
		||||
 | 
			
		||||
	err := packages_service.RemovePackageVersionByNameAndVersion(
 | 
			
		||||
		ctx,
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user