mirror of
https://github.com/go-gitea/gitea
synced 2025-07-07 02:57:20 +00:00
Refactor names (#31405)
This PR only does "renaming": * `Route` should be `Router` (and chi router is also called "router") * `Params` should be `PathParam` (to distingush it from URL query param, and to match `FormString`) * Use lower case for private functions to avoid exposing or abusing
This commit is contained in:
@ -73,7 +73,7 @@ func GetHook(ctx *context.APIContext) {
|
||||
// "200":
|
||||
// "$ref": "#/responses/Hook"
|
||||
|
||||
hookID := ctx.ParamsInt64(":id")
|
||||
hookID := ctx.PathParamInt64(":id")
|
||||
hook, err := webhook.GetSystemOrDefaultWebhook(ctx, hookID)
|
||||
if err != nil {
|
||||
if errors.Is(err, util.ErrNotExist) {
|
||||
@ -142,7 +142,7 @@ func EditHook(ctx *context.APIContext) {
|
||||
form := web.GetForm(ctx).(*api.EditHookOption)
|
||||
|
||||
// TODO in body params
|
||||
hookID := ctx.ParamsInt64(":id")
|
||||
hookID := ctx.PathParamInt64(":id")
|
||||
utils.EditSystemHook(ctx, form, hookID)
|
||||
}
|
||||
|
||||
@ -164,7 +164,7 @@ func DeleteHook(ctx *context.APIContext) {
|
||||
// "204":
|
||||
// "$ref": "#/responses/empty"
|
||||
|
||||
hookID := ctx.ParamsInt64(":id")
|
||||
hookID := ctx.PathParamInt64(":id")
|
||||
if err := webhook.DeleteDefaultSystemWebhook(ctx, hookID); err != nil {
|
||||
if errors.Is(err, util.ErrNotExist) {
|
||||
ctx.NotFound()
|
||||
|
Reference in New Issue
Block a user