Fix public activity showing private repos (#892)

* Fix public activity showing private repos (#811)

Signed-off-by: Morgan Bazalgette <the@howl.moe>

* error check after setting is_private to true

* Add test for UpdateRepository w/ visibility change

models/fixtures/action.yml

@@ -20,3 +20,14 @@
   repo_name: repo3 # TODO old or new name?
   is_private: false
   content: oldRepoName
+
+-
+  id: 3
+  user_id: 11
+  op_type: 1 # create repo
+  act_user_id: 11
+  act_user_name: user11
+  repo_id: 9
+  repo_user_name: user11
+  repo_name: repo9
+  is_private: false

models/fixtures/repository.yml

@@ -93,3 +93,15 @@
   num_pulls: 0
   num_closed_pulls: 0
   is_mirror: false
+
+-
+  id: 9
+  owner_id: 11
+  lower_name: repo9
+  name: repo9
+  is_private: false
+  num_issues: 0
+  num_closed_issues: 0
+  num_pulls: 0
+  num_closed_pulls: 0
+  is_mirror: false

models/fixtures/user.yml

@@ -149,3 +149,18 @@
   avatar_email: user10@example.com
   num_repos: 3
   is_active: true
+
+-
+  id: 11
+  lower_name: user11
+  name: user11
+  full_name: User Eleven
+  email: user11@example.com
+  passwd: password
+  type: 0 # individual
+  salt: salt
+  is_admin: false
+  avatar: avatar11
+  avatar_email: user11@example.com
+  num_repos: 1
+  is_active: true