tdsds.com/gitea
1
1
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2025-07-09 20:17:21 +00:00
Code Releases Activity

Validate hex colors when creating/editing labels (#34623)

Browse Source 
Resolves #34618.

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
Kemal Zebari
2025-06-07 01:25:08 -07:00
committed by GitHub
parent b38f2d31fd
commit 47d69b7749
9 changed files with 151 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
modules/label/label.go
View File

@ -7,10 +7,10 @@ import (
"fmt"
"regexp"
"strings"
)
"sync"
// colorPattern is a regexp which can validate label color
var colorPattern = regexp.MustCompile("^#?(?:[0-9a-fA-F]{6}|[0-9a-fA-F]{3})$")
"code.gitea.io/gitea/modules/util"
)
// Label represents label information loaded from template
type Label struct {
@ -21,6 +21,10 @@ type Label struct {
ExclusiveOrder int `yaml:"exclusive_order,omitempty"`
}
var colorPattern = sync.OnceValue(func() *regexp.Regexp {
return regexp.MustCompile(`^#([\da-fA-F]{3}|[\da-fA-F]{6})$`)
})
// NormalizeColor normalizes a color string to a 6-character hex code
func NormalizeColor(color string) (string, error) {
// normalize case
@ -31,8 +35,8 @@ func NormalizeColor(color string) (string, error) {
color = "#" + color
}
if !colorPattern.MatchString(color) {
return "", fmt.Errorf("bad color code: %s", color)
if !colorPattern().MatchString(color) {
return "", util.NewInvalidArgumentErrorf("invalid color: %s", color)
}
// convert 3-character shorthand into 6-character version