fix lints

modules/validation/binding.go

@@ -26,8 +26,8 @@ const (
 	ErrUsername = "UsernameError"
 	// ErrInvalidGroupTeamMap is returned when a group team mapping is invalid
 	ErrInvalidGroupTeamMap = "InvalidGroupTeamMap"
-	ErrInvalidImageURL     = "InvalidImageURL"
-	ErrInvalidSlug         = "InvalidSlug"
+	// ErrInvalidSlug is returned when a slug is invalid
+	ErrInvalidSlug = "InvalidSlug"
 )
 
 // AddBindingRules adds additional binding rules
@@ -40,7 +40,6 @@ func AddBindingRules() {
 	addGlobOrRegexPatternRule()
 	addUsernamePatternRule()
 	addValidGroupTeamMapRule()
-	addValidImageURLBindingRule()
 	addSlugPatternRule()
 }
 
@@ -98,24 +97,6 @@ func addValidSiteURLBindingRule() {
 	})
 }
 
-func addValidImageURLBindingRule() {
-	// URL validation rule
-	binding.AddRule(&binding.Rule{
-		IsMatch: func(rule string) bool {
-			return strings.HasPrefix(rule, "ValidImageUrl")
-		},
-		IsValid: func(errs binding.Errors, name string, val any) (bool, binding.Errors) {
-			str := fmt.Sprintf("%v", val)
-			if len(str) != 0 && !IsValidImageURL(str) {
-				errs.Add([]string{name}, ErrInvalidImageURL, "ImageURL")
-				return false, errs
-			}
-
-			return true, errs
-		},
-	})
-}
-
 func addSlugPatternRule() {
 	binding.AddRule(&binding.Rule{
 		IsMatch: func(rule string) bool {

modules/validation/helpers.go

@@ -6,7 +6,6 @@ package validation
 import (
 	"net"
 	"net/url"
-	"path/filepath"
 	"regexp"
 	"strings"
 
@@ -51,29 +50,6 @@ func IsValidSiteURL(uri string) bool {
 	return false
 }
 
-// IsValidImageURL checks if URL is valid and points to an image
-func IsValidImageURL(uri string) bool {
-	u, err := url.ParseRequestURI(uri)
-	if err != nil {
-		return false
-	}
-
-	if !validPort(portOnly(u.Host)) {
-		return false
-	}
-
-	for _, scheme := range setting.Service.ValidSiteURLSchemes {
-		if scheme == u.Scheme {
-			// Check if the path has an image file extension
-			ext := strings.ToLower(filepath.Ext(u.Path))
-			if ext == ".jpg" || ext == ".jpeg" || ext == ".png" || ext == ".gif" || ext == ".bmp" || ext == ".svg" || ext == ".webp" {
-				return true
-			}
-		}
-	}
-	return false
-}
-
 // IsEmailDomainListed checks whether the domain of an email address
 // matches a list of domains
 func IsEmailDomainListed(globs []glob.Glob, email string) bool {