mirror of
				https://github.com/go-gitea/gitea
				synced 2025-10-31 11:28:24 +00:00 
			
		
		
		
	Fix JS error on compare page (#23551)
Fix regression from #23271. This code apparently runs on the compare page where there is no review button so check for existance of both button and content. <img width="1226" alt="Screenshot 2023-03-17 at 21 42 47" src="https://user-images.githubusercontent.com/115237/226040001-ec097edd-d926-4c80-9962-526f9b7eff19.png"> Fixes #23562
This commit is contained in:
		| @@ -516,20 +516,22 @@ export function initRepoPullRequestReview() { | ||||
|   const $panel = $reviewBtn.parent().find('.review-box-panel'); | ||||
|   const $closeBtn = $panel.find('.close'); | ||||
|  | ||||
|   const tippy = createTippy($reviewBtn[0], { | ||||
|     content: $panel[0], | ||||
|     placement: 'bottom', | ||||
|     trigger: 'click', | ||||
|     role: 'menu', | ||||
|     maxWidth: 'none', | ||||
|     interactive: true, | ||||
|     hideOnClick: true, | ||||
|   }); | ||||
|   if ($reviewBtn.length && $panel.length) { | ||||
|     const tippy = createTippy($reviewBtn[0], { | ||||
|       content: $panel[0], | ||||
|       placement: 'bottom', | ||||
|       trigger: 'click', | ||||
|       role: 'menu', | ||||
|       maxWidth: 'none', | ||||
|       interactive: true, | ||||
|       hideOnClick: true, | ||||
|     }); | ||||
|  | ||||
|   $closeBtn.on('click', (e) => { | ||||
|     e.preventDefault(); | ||||
|     tippy.hide(); | ||||
|   }); | ||||
|     $closeBtn.on('click', (e) => { | ||||
|       e.preventDefault(); | ||||
|       tippy.hide(); | ||||
|     }); | ||||
|   } | ||||
|  | ||||
|   $(document).on('click', 'a.add-code-comment', async function (e) { | ||||
|     if ($(e.target).hasClass('btn-add-single')) return; // https://github.com/go-gitea/gitea/issues/4745 | ||||
|   | ||||
		Reference in New Issue
	
	Block a user