From 5789e603161aff311f8afcc15585892e783c931e Mon Sep 17 00:00:00 2001 From: mrsdizzie Date: Fri, 22 May 2020 09:14:02 -0400 Subject: [PATCH] Use default commit message for wiki edits (#11550) Use a default commit message when a user doesn't add one (same as repo editor) to avoid commit lists with no message --- routers/repo/wiki.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/routers/repo/wiki.go b/routers/repo/wiki.go index 5da01f21ac..cc60b4388d 100644 --- a/routers/repo/wiki.go +++ b/routers/repo/wiki.go @@ -572,6 +572,11 @@ func NewWikiPost(ctx *context.Context, form auth.NewWikiForm) { } wikiName := wiki_service.NormalizeWikiName(form.Title) + + if len(form.Message) == 0 { + form.Message = ctx.Tr("repo.editor.add", form.Title) + } + if err := wiki_service.AddWikiPage(ctx.User, ctx.Repo.Repository, wikiName, form.Content, form.Message); err != nil { if models.IsErrWikiReservedName(err) { ctx.Data["Err_Title"] = true @@ -621,6 +626,10 @@ func EditWikiPost(ctx *context.Context, form auth.NewWikiForm) { oldWikiName := wiki_service.NormalizeWikiName(ctx.Params(":page")) newWikiName := wiki_service.NormalizeWikiName(form.Title) + if len(form.Message) == 0 { + form.Message = ctx.Tr("repo.editor.update", form.Title) + } + if err := wiki_service.EditWikiPage(ctx.User, ctx.Repo.Repository, oldWikiName, newWikiName, form.Content, form.Message); err != nil { ctx.ServerError("EditWikiPage", err) return