tdsds.com/gitea
tdsds.com/gitea
1
1
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-22 16:44:26 +00:00
Code Releases Activity

Make frontend unit test code could know it is in testing (#32656)

Browse Source 
See the comment of isInFrontendUnitTest
This commit is contained in:
wxiaoguang 2024-11-28 01:40:32 +08:00 committed by GitHub
parent 846f618716
commit 5a50b271e7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
web_src/js/utils/dom.ts
View File

@ -1,6 +1,7 @@
import {debounce} from 'throttle-debounce'; import {debounce} from 'throttle-debounce';
import type {Promisable} from 'type-fest'; import type {Promisable} from 'type-fest';
import type $ from 'jquery'; import type $ from 'jquery';
import {isInFrontendUnitTest} from './testhelper.ts';
type ArrayLikeIterable<T> = ArrayLike<T> & Iterable<T>; // for NodeListOf and Array type ArrayLikeIterable<T> = ArrayLike<T> & Iterable<T>; // for NodeListOf and Array
type ElementArg = Element | string | ArrayLikeIterable<Element> | ReturnType<typeof $>; type ElementArg = Element | string | ArrayLikeIterable<Element> | ReturnType<typeof $>;
@ -76,8 +77,8 @@ export function queryElemSiblings<T extends Element>(el: Element, selector = '*'
// it works like jQuery.children: only the direct children are selected // it works like jQuery.children: only the direct children are selected
export function queryElemChildren<T extends Element>(parent: Element | ParentNode, selector = '*', fn?: ElementsCallback<T>): ArrayLikeIterable<T> { export function queryElemChildren<T extends Element>(parent: Element | ParentNode, selector = '*', fn?: ElementsCallback<T>): ArrayLikeIterable<T> {
if (window.vitest) { if (isInFrontendUnitTest()) {
// bypass the vitest bug: it doesn't support ":scope >" // https://github.com/capricorn86/happy-dom/issues/1620 : ":scope" doesn't work
const selected = Array.from<T>(parent.children as any).filter((child) => child.matches(selector)); const selected = Array.from<T>(parent.children as any).filter((child) => child.matches(selector));
return applyElemsCallback<T>(selected, fn); return applyElemsCallback<T>(selected, fn);
} }
@ -357,6 +358,6 @@ export function addDelegatedEventListener<T extends HTMLElement, E extends Event
parent.addEventListener(type, (e: Event) => { parent.addEventListener(type, (e: Event) => {
const elem = (e.target as HTMLElement).closest(selector); const elem = (e.target as HTMLElement).closest(selector);
if (!elem) return; if (!elem) return;
listener(elem as T, e); listener(elem as T, e as E);
}, options); }, options);
} }

6
web_src/js/utils/testhelper.ts Normal file
View File

@ -0,0 +1,6 @@
// there could be different "testing" concepts, for example: backend's "setting.IsInTesting"
// even if backend is in testing mode, frontend could be complied in production mode
// so this function only checks if the frontend is in unit testing mode (usually from *.test.ts files)
export function isInFrontendUnitTest() {
return process.env.TEST === 'true';
}