Handle refactor (#3339)

* Replace all ctx.Handle with ctx.ServerError or ctx.NotFound

* Change Handle(403) to NotFound, avoid using macaron's NotFound

routers/user/auth.go

@@ -81,7 +81,7 @@ func checkAutoLogin(ctx *context.Context) bool {
 	// Check auto-login.
 	isSucceed, err := AutoSignIn(ctx)
 	if err != nil {
-		ctx.Handle(500, "AutoSignIn", err)
+		ctx.ServerError("AutoSignIn", err)
 		return true
 	}
 
@@ -116,7 +116,7 @@ func SignIn(ctx *context.Context) {
 
 	orderedOAuth2Names, oauth2Providers, err := models.GetActiveOAuth2Providers()
 	if err != nil {
-		ctx.Handle(500, "UserSignIn", err)
+		ctx.ServerError("UserSignIn", err)
 		return
 	}
 	ctx.Data["OrderedOAuth2Names"] = orderedOAuth2Names
@@ -135,7 +135,7 @@ func SignInPost(ctx *context.Context, form auth.SignInForm) {
 
 	orderedOAuth2Names, oauth2Providers, err := models.GetActiveOAuth2Providers()
 	if err != nil {
-		ctx.Handle(500, "UserSignIn", err)
+		ctx.ServerError("UserSignIn", err)
 		return
 	}
 	ctx.Data["OrderedOAuth2Names"] = orderedOAuth2Names
@@ -159,7 +159,7 @@ func SignInPost(ctx *context.Context, form auth.SignInForm) {
 			ctx.RenderWithErr(ctx.Tr("form.email_been_used"), tplSignIn, &form)
 			log.Info("Failed authentication attempt for %s from %s", form.UserName, ctx.RemoteAddr())
 		} else {
-			ctx.Handle(500, "UserSignIn", err)
+			ctx.ServerError("UserSignIn", err)
 		}
 		return
 	}
@@ -171,7 +171,7 @@ func SignInPost(ctx *context.Context, form auth.SignInForm) {
 		if models.IsErrTwoFactorNotEnrolled(err) {
 			handleSignIn(ctx, u, form.Remember)
 		} else {
-			ctx.Handle(500, "UserSignIn", err)
+			ctx.ServerError("UserSignIn", err)
 		}
 		return
 	}
@@ -193,7 +193,7 @@ func TwoFactor(ctx *context.Context) {
 
 	// Ensure user is in a 2FA session.
 	if ctx.Session.Get("twofaUid") == nil {
-		ctx.Handle(500, "UserSignIn", errors.New("not in 2FA session"))
+		ctx.ServerError("UserSignIn", errors.New("not in 2FA session"))
 		return
 	}
 
@@ -207,21 +207,21 @@ func TwoFactorPost(ctx *context.Context, form auth.TwoFactorAuthForm) {
 	// Ensure user is in a 2FA session.
 	idSess := ctx.Session.Get("twofaUid")
 	if idSess == nil {
-		ctx.Handle(500, "UserSignIn", errors.New("not in 2FA session"))
+		ctx.ServerError("UserSignIn", errors.New("not in 2FA session"))
 		return
 	}
 
 	id := idSess.(int64)
 	twofa, err := models.GetTwoFactorByUID(id)
 	if err != nil {
-		ctx.Handle(500, "UserSignIn", err)
+		ctx.ServerError("UserSignIn", err)
 		return
 	}
 
 	// Validate the passcode with the stored TOTP secret.
 	ok, err := twofa.ValidateTOTP(form.Passcode)
 	if err != nil {
-		ctx.Handle(500, "UserSignIn", err)
+		ctx.ServerError("UserSignIn", err)
 		return
 	}
 
@@ -229,20 +229,20 @@ func TwoFactorPost(ctx *context.Context, form auth.TwoFactorAuthForm) {
 		remember := ctx.Session.Get("twofaRemember").(bool)
 		u, err := models.GetUserByID(id)
 		if err != nil {
-			ctx.Handle(500, "UserSignIn", err)
+			ctx.ServerError("UserSignIn", err)
 			return
 		}
 
 		if ctx.Session.Get("linkAccount") != nil {
 			gothUser := ctx.Session.Get("linkAccountGothUser")
 			if gothUser == nil {
-				ctx.Handle(500, "UserSignIn", errors.New("not in LinkAccount session"))
+				ctx.ServerError("UserSignIn", errors.New("not in LinkAccount session"))
 				return
 			}
 
 			err = models.LinkAccountToUser(u, gothUser.(goth.User))
 			if err != nil {
-				ctx.Handle(500, "UserSignIn", err)
+				ctx.ServerError("UserSignIn", err)
 				return
 			}
 		}
@@ -265,7 +265,7 @@ func TwoFactorScratch(ctx *context.Context) {
 
 	// Ensure user is in a 2FA session.
 	if ctx.Session.Get("twofaUid") == nil {
-		ctx.Handle(500, "UserSignIn", errors.New("not in 2FA session"))
+		ctx.ServerError("UserSignIn", errors.New("not in 2FA session"))
 		return
 	}
 
@@ -279,14 +279,14 @@ func TwoFactorScratchPost(ctx *context.Context, form auth.TwoFactorScratchAuthFo
 	// Ensure user is in a 2FA session.
 	idSess := ctx.Session.Get("twofaUid")
 	if idSess == nil {
-		ctx.Handle(500, "UserSignIn", errors.New("not in 2FA session"))
+		ctx.ServerError("UserSignIn", errors.New("not in 2FA session"))
 		return
 	}
 
 	id := idSess.(int64)
 	twofa, err := models.GetTwoFactorByUID(id)
 	if err != nil {
-		ctx.Handle(500, "UserSignIn", err)
+		ctx.ServerError("UserSignIn", err)
 		return
 	}
 
@@ -295,14 +295,14 @@ func TwoFactorScratchPost(ctx *context.Context, form auth.TwoFactorScratchAuthFo
 		// Invalidate the scratch token.
 		twofa.ScratchToken = ""
 		if err = models.UpdateTwoFactor(twofa); err != nil {
-			ctx.Handle(500, "UserSignIn", err)
+			ctx.ServerError("UserSignIn", err)
 			return
 		}
 
 		remember := ctx.Session.Get("twofaRemember").(bool)
 		u, err := models.GetUserByID(id)
 		if err != nil {
-			ctx.Handle(500, "UserSignIn", err)
+			ctx.ServerError("UserSignIn", err)
 			return
 		}
 
@@ -343,7 +343,7 @@ func handleSignInFull(ctx *context.Context, u *models.User, remember bool, obeyR
 	// Register last login
 	u.SetLastLogin()
 	if err := models.UpdateUserCols(u, "last_login_unix"); err != nil {
-		ctx.Handle(500, "UpdateUserCols", err)
+		ctx.ServerError("UpdateUserCols", err)
 		return
 	}
 
@@ -366,7 +366,7 @@ func SignInOAuth(ctx *context.Context) {
 
 	loginSource, err := models.GetActiveOAuth2LoginSourceByName(provider)
 	if err != nil {
-		ctx.Handle(500, "SignIn", err)
+		ctx.ServerError("SignIn", err)
 		return
 	}
 
@@ -380,7 +380,7 @@ func SignInOAuth(ctx *context.Context) {
 
 	err = oauth2.Auth(loginSource.Name, ctx.Req.Request, ctx.Resp)
 	if err != nil {
-		ctx.Handle(500, "SignIn", err)
+		ctx.ServerError("SignIn", err)
 	}
 	// redirect is done in oauth2.Auth
 }
@@ -392,12 +392,12 @@ func SignInOAuthCallback(ctx *context.Context) {
 	// first look if the provider is still active
 	loginSource, err := models.GetActiveOAuth2LoginSourceByName(provider)
 	if err != nil {
-		ctx.Handle(500, "SignIn", err)
+		ctx.ServerError("SignIn", err)
 		return
 	}
 
 	if loginSource == nil {
-		ctx.Handle(500, "SignIn", errors.New("No valid provider found, check configured callback url in provider"))
+		ctx.ServerError("SignIn", errors.New("No valid provider found, check configured callback url in provider"))
 		return
 	}
 
@@ -408,7 +408,7 @@ func SignInOAuthCallback(ctx *context.Context) {
 
 func handleOAuth2SignIn(u *models.User, gothUser goth.User, ctx *context.Context, err error) {
 	if err != nil {
-		ctx.Handle(500, "UserSignIn", err)
+		ctx.ServerError("UserSignIn", err)
 		return
 	}
 
@@ -433,7 +433,7 @@ func handleOAuth2SignIn(u *models.User, gothUser goth.User, ctx *context.Context
 			// Register last login
 			u.SetLastLogin()
 			if err := models.UpdateUserCols(u, "last_login_unix"); err != nil {
-				ctx.Handle(500, "UpdateUserCols", err)
+				ctx.ServerError("UpdateUserCols", err)
 				return
 			}
 
@@ -445,7 +445,7 @@ func handleOAuth2SignIn(u *models.User, gothUser goth.User, ctx *context.Context
 
 			ctx.Redirect(setting.AppSubURL + "/")
 		} else {
-			ctx.Handle(500, "UserSignIn", err)
+			ctx.ServerError("UserSignIn", err)
 		}
 		return
 	}
@@ -513,7 +513,7 @@ func LinkAccount(ctx *context.Context) {
 
 	gothUser := ctx.Session.Get("linkAccountGothUser")
 	if gothUser == nil {
-		ctx.Handle(500, "UserSignIn", errors.New("not in LinkAccount session"))
+		ctx.ServerError("UserSignIn", errors.New("not in LinkAccount session"))
 		return
 	}
 
@@ -538,7 +538,7 @@ func LinkAccountPostSignIn(ctx *context.Context, signInForm auth.SignInForm) {
 
 	gothUser := ctx.Session.Get("linkAccountGothUser")
 	if gothUser == nil {
-		ctx.Handle(500, "UserSignIn", errors.New("not in LinkAccount session"))
+		ctx.ServerError("UserSignIn", errors.New("not in LinkAccount session"))
 		return
 	}
 
@@ -552,7 +552,7 @@ func LinkAccountPostSignIn(ctx *context.Context, signInForm auth.SignInForm) {
 		if models.IsErrUserNotExist(err) {
 			ctx.RenderWithErr(ctx.Tr("form.username_password_incorrect"), tplLinkAccount, &signInForm)
 		} else {
-			ctx.Handle(500, "UserLinkAccount", err)
+			ctx.ServerError("UserLinkAccount", err)
 		}
 		return
 	}
@@ -564,12 +564,12 @@ func LinkAccountPostSignIn(ctx *context.Context, signInForm auth.SignInForm) {
 		if models.IsErrTwoFactorNotEnrolled(err) {
 			err = models.LinkAccountToUser(u, gothUser.(goth.User))
 			if err != nil {
-				ctx.Handle(500, "UserLinkAccount", err)
+				ctx.ServerError("UserLinkAccount", err)
 			} else {
 				handleSignIn(ctx, u, signInForm.Remember)
 			}
 		} else {
-			ctx.Handle(500, "UserLinkAccount", err)
+			ctx.ServerError("UserLinkAccount", err)
 		}
 		return
 	}
@@ -597,7 +597,7 @@ func LinkAccountPostRegister(ctx *context.Context, cpt *captcha.Captcha, form au
 
 	gothUser := ctx.Session.Get("linkAccountGothUser")
 	if gothUser == nil {
-		ctx.Handle(500, "UserSignUp", errors.New("not in LinkAccount session"))
+		ctx.ServerError("UserSignUp", errors.New("not in LinkAccount session"))
 		return
 	}
 
@@ -630,7 +630,7 @@ func LinkAccountPostRegister(ctx *context.Context, cpt *captcha.Captcha, form au
 
 	loginSource, err := models.GetActiveOAuth2LoginSourceByName(gothUser.(goth.User).Provider)
 	if err != nil {
-		ctx.Handle(500, "CreateUser", err)
+		ctx.ServerError("CreateUser", err)
 	}
 
 	u := &models.User{
@@ -658,7 +658,7 @@ func LinkAccountPostRegister(ctx *context.Context, cpt *captcha.Captcha, form au
 			ctx.Data["Err_UserName"] = true
 			ctx.RenderWithErr(ctx.Tr("user.form.name_pattern_not_allowed", err.(models.ErrNamePatternNotAllowed).Pattern), tplLinkAccount, &form)
 		default:
-			ctx.Handle(500, "CreateUser", err)
+			ctx.ServerError("CreateUser", err)
 		}
 		return
 	}
@@ -670,7 +670,7 @@ func LinkAccountPostRegister(ctx *context.Context, cpt *captcha.Captcha, form au
 		u.IsActive = true
 		u.SetLastLogin()
 		if err := models.UpdateUserCols(u, "is_admin", "is_active", "last_login_unix"); err != nil {
-			ctx.Handle(500, "UpdateUser", err)
+			ctx.ServerError("UpdateUser", err)
 			return
 		}
 	}
@@ -774,7 +774,7 @@ func SignUpPost(ctx *context.Context, cpt *captcha.Captcha, form auth.RegisterFo
 			ctx.Data["Err_UserName"] = true
 			ctx.RenderWithErr(ctx.Tr("user.form.name_pattern_not_allowed", err.(models.ErrNamePatternNotAllowed).Pattern), tplSignUp, &form)
 		default:
-			ctx.Handle(500, "CreateUser", err)
+			ctx.ServerError("CreateUser", err)
 		}
 		return
 	}
@@ -786,7 +786,7 @@ func SignUpPost(ctx *context.Context, cpt *captcha.Captcha, form auth.RegisterFo
 		u.IsActive = true
 		u.SetLastLogin()
 		if err := models.UpdateUserCols(u, "is_admin", "is_active", "last_login_unix"); err != nil {
-			ctx.Handle(500, "UpdateUser", err)
+			ctx.ServerError("UpdateUser", err)
 			return
 		}
 	}
@@ -841,14 +841,14 @@ func Activate(ctx *context.Context) {
 		user.IsActive = true
 		var err error
 		if user.Rands, err = models.GetUserSalt(); err != nil {
-			ctx.Handle(500, "UpdateUser", err)
+			ctx.ServerError("UpdateUser", err)
 			return
 		}
 		if err := models.UpdateUserCols(user, "is_active", "rands"); err != nil {
 			if models.IsErrUserNotExist(err) {
 				ctx.Error(404)
 			} else {
-				ctx.Handle(500, "UpdateUser", err)
+				ctx.ServerError("UpdateUser", err)
 			}
 			return
 		}
@@ -873,7 +873,7 @@ func ActivateEmail(ctx *context.Context) {
 	// Verify code.
 	if email := models.VerifyActiveEmailCode(code, emailStr); email != nil {
 		if err := email.Activate(); err != nil {
-			ctx.Handle(500, "ActivateEmail", err)
+			ctx.ServerError("ActivateEmail", err)
 		}
 
 		log.Trace("Email activated: %s", email.Email)
@@ -906,7 +906,7 @@ func ForgotPasswdPost(ctx *context.Context) {
 	ctx.Data["Title"] = ctx.Tr("auth.forgot_password_title")
 
 	if setting.MailService == nil {
-		ctx.Handle(403, "ForgotPasswdPost", nil)
+		ctx.NotFound("ForgotPasswdPost", nil)
 		return
 	}
 	ctx.Data["IsResetRequest"] = true
@@ -923,7 +923,7 @@ func ForgotPasswdPost(ctx *context.Context) {
 			return
 		}
 
-		ctx.Handle(500, "user.ResetPasswd(check existence)", err)
+		ctx.ServerError("user.ResetPasswd(check existence)", err)
 		return
 	}
 
@@ -987,16 +987,16 @@ func ResetPasswdPost(ctx *context.Context) {
 		u.Passwd = passwd
 		var err error
 		if u.Rands, err = models.GetUserSalt(); err != nil {
-			ctx.Handle(500, "UpdateUser", err)
+			ctx.ServerError("UpdateUser", err)
 			return
 		}
 		if u.Salt, err = models.GetUserSalt(); err != nil {
-			ctx.Handle(500, "UpdateUser", err)
+			ctx.ServerError("UpdateUser", err)
 			return
 		}
 		u.HashPassword()
 		if err := models.UpdateUserCols(u, "passwd", "rands", "salt"); err != nil {
-			ctx.Handle(500, "UpdateUser", err)
+			ctx.ServerError("UpdateUser", err)
 			return
 		}
 

routers/user/auth_openid.go

@@ -37,7 +37,7 @@ func SignInOpenID(ctx *context.Context) {
 	// Check auto-login.
 	isSucceed, err := AutoSignIn(ctx)
 	if err != nil {
-		ctx.Handle(500, "AutoSignIn", err)
+		ctx.ServerError("AutoSignIn", err)
 		return
 	}
 
@@ -276,7 +276,7 @@ func ConnectOpenIDPost(ctx *context.Context, form auth.ConnectOpenIDForm) {
 		if models.IsErrUserNotExist(err) {
 			ctx.RenderWithErr(ctx.Tr("form.username_password_incorrect"), tplConnectOID, &form)
 		} else {
-			ctx.Handle(500, "ConnectOpenIDPost", err)
+			ctx.ServerError("ConnectOpenIDPost", err)
 		}
 		return
 	}
@@ -288,7 +288,7 @@ func ConnectOpenIDPost(ctx *context.Context, form auth.ConnectOpenIDForm) {
 			ctx.RenderWithErr(ctx.Tr("form.openid_been_used", oid), tplConnectOID, &form)
 			return
 		}
-		ctx.Handle(500, "AddUserOpenID", err)
+		ctx.ServerError("AddUserOpenID", err)
 		return
 	}
 
@@ -376,7 +376,7 @@ func RegisterOpenIDPost(ctx *context.Context, cpt *captcha.Captcha, form auth.Si
 			ctx.Data["Err_UserName"] = true
 			ctx.RenderWithErr(ctx.Tr("user.form.name_pattern_not_allowed", err.(models.ErrNamePatternNotAllowed).Pattern), tplSignUpOID, &form)
 		default:
-			ctx.Handle(500, "CreateUser", err)
+			ctx.ServerError("CreateUser", err)
 		}
 		return
 	}
@@ -389,7 +389,7 @@ func RegisterOpenIDPost(ctx *context.Context, cpt *captcha.Captcha, form auth.Si
 			ctx.RenderWithErr(ctx.Tr("form.openid_been_used", oid), tplSignUpOID, &form)
 			return
 		}
-		ctx.Handle(500, "AddUserOpenID", err)
+		ctx.ServerError("AddUserOpenID", err)
 		return
 	}
 
@@ -399,7 +399,7 @@ func RegisterOpenIDPost(ctx *context.Context, cpt *captcha.Captcha, form auth.Si
 		u.IsActive = true
 		u.SetLastLogin()
 		if err := models.UpdateUserCols(u, "is_admin", "is_active", "last_login_unix"); err != nil {
-			ctx.Handle(500, "UpdateUser", err)
+			ctx.ServerError("UpdateUser", err)
 			return
 		}
 	}

routers/user/home.go

@@ -35,9 +35,9 @@ func getDashboardContextUser(ctx *context.Context) *models.User {
 		org, err := models.GetUserByName(orgName)
 		if err != nil {
 			if models.IsErrUserNotExist(err) {
-				ctx.Handle(404, "GetUserByName", err)
+				ctx.NotFound("GetUserByName", err)
 			} else {
-				ctx.Handle(500, "GetUserByName", err)
+				ctx.ServerError("GetUserByName", err)
 			}
 			return nil
 		}
@@ -46,7 +46,7 @@ func getDashboardContextUser(ctx *context.Context) *models.User {
 	ctx.Data["ContextUser"] = ctxUser
 
 	if err := ctx.User.GetOrganizations(true); err != nil {
-		ctx.Handle(500, "GetOrganizations", err)
+		ctx.ServerError("GetOrganizations", err)
 		return nil
 	}
 	ctx.Data["Orgs"] = ctx.User.Orgs
@@ -58,7 +58,7 @@ func getDashboardContextUser(ctx *context.Context) *models.User {
 func retrieveFeeds(ctx *context.Context, options models.GetFeedsOptions) {
 	actions, err := models.GetFeeds(options)
 	if err != nil {
-		ctx.Handle(500, "GetFeeds", err)
+		ctx.ServerError("GetFeeds", err)
 		return
 	}
 
@@ -76,7 +76,7 @@ func retrieveFeeds(ctx *context.Context, options models.GetFeedsOptions) {
 				if models.IsErrUserNotExist(err) {
 					continue
 				}
-				ctx.Handle(500, "GetUserByID", err)
+				ctx.ServerError("GetUserByID", err)
 				return
 			}
 			userCache[act.ActUserID] = u
@@ -90,7 +90,7 @@ func retrieveFeeds(ctx *context.Context, options models.GetFeedsOptions) {
 				if models.IsErrRepoNotExist(err) {
 					continue
 				}
-				ctx.Handle(500, "GetRepositoryByID", err)
+				ctx.ServerError("GetRepositoryByID", err)
 				return
 			}
 		}
@@ -103,7 +103,7 @@ func retrieveFeeds(ctx *context.Context, options models.GetFeedsOptions) {
 				if models.IsErrUserNotExist(err) {
 					continue
 				}
-				ctx.Handle(500, "GetUserByID", err)
+				ctx.ServerError("GetUserByID", err)
 				return
 			}
 		}
@@ -129,26 +129,26 @@ func Dashboard(ctx *context.Context) {
 	if ctxUser.IsOrganization() {
 		env, err := ctxUser.AccessibleReposEnv(ctx.User.ID)
 		if err != nil {
-			ctx.Handle(500, "AccessibleReposEnv", err)
+			ctx.ServerError("AccessibleReposEnv", err)
 			return
 		}
 
 		mirrors, err = env.MirrorRepos()
 		if err != nil {
-			ctx.Handle(500, "env.MirrorRepos", err)
+			ctx.ServerError("env.MirrorRepos", err)
 			return
 		}
 	} else {
 		mirrors, err = ctxUser.GetMirrorRepositories()
 		if err != nil {
-			ctx.Handle(500, "GetMirrorRepositories", err)
+			ctx.ServerError("GetMirrorRepositories", err)
 			return
 		}
 	}
 	ctx.Data["MaxShowRepoNum"] = setting.UI.User.RepoPagingNum
 
 	if err := models.MirrorRepositoryList(mirrors).LoadAttributes(); err != nil {
-		ctx.Handle(500, "MirrorRepositoryList.LoadAttributes", err)
+		ctx.ServerError("MirrorRepositoryList.LoadAttributes", err)
 		return
 	}
 	ctx.Data["MirrorCount"] = len(mirrors)
@@ -217,18 +217,18 @@ func Issues(ctx *context.Context) {
 	if ctxUser.IsOrganization() {
 		env, err := ctxUser.AccessibleReposEnv(ctx.User.ID)
 		if err != nil {
-			ctx.Handle(500, "AccessibleReposEnv", err)
+			ctx.ServerError("AccessibleReposEnv", err)
 			return
 		}
 		userRepoIDs, err = env.RepoIDs(1, ctxUser.NumRepos)
 		if err != nil {
-			ctx.Handle(500, "env.RepoIDs", err)
+			ctx.ServerError("env.RepoIDs", err)
 			return
 		}
 	} else {
 		userRepoIDs, err = ctxUser.GetAccessRepoIDs()
 		if err != nil {
-			ctx.Handle(500, "ctxUser.GetAccessRepoIDs", err)
+			ctx.ServerError("ctxUser.GetAccessRepoIDs", err)
 			return
 		}
 	}
@@ -266,7 +266,7 @@ func Issues(ctx *context.Context) {
 
 	counts, err := models.CountIssuesByRepo(opts)
 	if err != nil {
-		ctx.Handle(500, "CountIssuesByRepo", err)
+		ctx.ServerError("CountIssuesByRepo", err)
 		return
 	}
 
@@ -274,7 +274,7 @@ func Issues(ctx *context.Context) {
 	opts.PageSize = setting.UI.IssuePagingNum
 	issues, err := models.Issues(opts)
 	if err != nil {
-		ctx.Handle(500, "Issues", err)
+		ctx.ServerError("Issues", err)
 		return
 	}
 
@@ -282,7 +282,7 @@ func Issues(ctx *context.Context) {
 	for repoID := range counts {
 		repo, err := models.GetRepositoryByID(repoID)
 		if err != nil {
-			ctx.Handle(500, "GetRepositoryByID", err)
+			ctx.ServerError("GetRepositoryByID", err)
 			return
 		}
 		showReposMap[repoID] = repo
@@ -292,7 +292,7 @@ func Issues(ctx *context.Context) {
 		if _, ok := showReposMap[repoID]; !ok {
 			repo, err := models.GetRepositoryByID(repoID)
 			if err != nil {
-				ctx.Handle(500, "GetRepositoryByID", fmt.Errorf("[%d]%v", repoID, err))
+				ctx.ServerError("GetRepositoryByID", fmt.Errorf("[%d]%v", repoID, err))
 				return
 			}
 			showReposMap[repoID] = repo
@@ -310,7 +310,7 @@ func Issues(ctx *context.Context) {
 	showRepos := models.RepositoryListOfMap(showReposMap)
 	sort.Sort(showRepos)
 	if err = showRepos.LoadAttributes(); err != nil {
-		ctx.Handle(500, "LoadAttributes", err)
+		ctx.ServerError("LoadAttributes", err)
 		return
 	}
 
@@ -327,7 +327,7 @@ func Issues(ctx *context.Context) {
 		IsClosed:    isShowClosed,
 	})
 	if err != nil {
-		ctx.Handle(500, "GetUserIssueStats", err)
+		ctx.ServerError("GetUserIssueStats", err)
 		return
 	}
 
@@ -361,7 +361,7 @@ func Issues(ctx *context.Context) {
 func ShowSSHKeys(ctx *context.Context, uid int64) {
 	keys, err := models.ListPublicKeys(uid)
 	if err != nil {
-		ctx.Handle(500, "ListPublicKeys", err)
+		ctx.ServerError("ListPublicKeys", err)
 		return
 	}
 
@@ -396,17 +396,17 @@ func showOrgProfile(ctx *context.Context) {
 	if ctx.IsSigned && !ctx.User.IsAdmin {
 		env, err := org.AccessibleReposEnv(ctx.User.ID)
 		if err != nil {
-			ctx.Handle(500, "AccessibleReposEnv", err)
+			ctx.ServerError("AccessibleReposEnv", err)
 			return
 		}
 		repos, err = env.Repos(page, setting.UI.User.RepoPagingNum)
 		if err != nil {
-			ctx.Handle(500, "env.Repos", err)
+			ctx.ServerError("env.Repos", err)
 			return
 		}
 		count, err = env.CountRepos()
 		if err != nil {
-			ctx.Handle(500, "env.CountRepos", err)
+			ctx.ServerError("env.CountRepos", err)
 			return
 		}
 		ctx.Data["Repos"] = repos
@@ -414,7 +414,7 @@ func showOrgProfile(ctx *context.Context) {
 		showPrivate := ctx.IsSigned && ctx.User.IsAdmin
 		repos, err = models.GetUserRepositories(org.ID, showPrivate, page, setting.UI.User.RepoPagingNum, "")
 		if err != nil {
-			ctx.Handle(500, "GetRepositories", err)
+			ctx.ServerError("GetRepositories", err)
 			return
 		}
 		ctx.Data["Repos"] = repos
@@ -423,7 +423,7 @@ func showOrgProfile(ctx *context.Context) {
 	ctx.Data["Page"] = paginater.New(int(count), setting.UI.User.RepoPagingNum, page, 5)
 
 	if err := org.GetMembers(); err != nil {
-		ctx.Handle(500, "GetMembers", err)
+		ctx.ServerError("GetMembers", err)
 		return
 	}
 	ctx.Data["Members"] = org.Members
@@ -438,9 +438,9 @@ func Email2User(ctx *context.Context) {
 	u, err := models.GetUserByEmail(ctx.Query("email"))
 	if err != nil {
 		if models.IsErrUserNotExist(err) {
-			ctx.Handle(404, "GetUserByEmail", err)
+			ctx.NotFound("GetUserByEmail", err)
 		} else {
-			ctx.Handle(500, "GetUserByEmail", err)
+			ctx.ServerError("GetUserByEmail", err)
 		}
 		return
 	}

routers/user/notification.go

@@ -30,7 +30,7 @@ func GetNotificationCount(c *context.Context) {
 
 	count, err := models.GetNotificationCount(c.User, models.NotificationStatusUnread)
 	if err != nil {
-		c.Handle(500, "GetNotificationCount", err)
+		c.ServerError("GetNotificationCount", err)
 		return
 	}
 
@@ -62,13 +62,13 @@ func Notifications(c *context.Context) {
 	statuses := []models.NotificationStatus{status, models.NotificationStatusPinned}
 	notifications, err := models.NotificationsForUser(c.User, statuses, page, perPage)
 	if err != nil {
-		c.Handle(500, "ErrNotificationsForUser", err)
+		c.ServerError("ErrNotificationsForUser", err)
 		return
 	}
 
 	total, err := models.GetNotificationCount(c.User, status)
 	if err != nil {
-		c.Handle(500, "ErrGetNotificationCount", err)
+		c.ServerError("ErrGetNotificationCount", err)
 		return
 	}
 
@@ -100,12 +100,12 @@ func NotificationStatusPost(c *context.Context) {
 	case "pinned":
 		status = models.NotificationStatusPinned
 	default:
-		c.Handle(500, "InvalidNotificationStatus", errors.New("Invalid notification status"))
+		c.ServerError("InvalidNotificationStatus", errors.New("Invalid notification status"))
 		return
 	}
 
 	if err := models.SetNotificationStatus(notificationID, c.User, status); err != nil {
-		c.Handle(500, "SetNotificationStatus", err)
+		c.ServerError("SetNotificationStatus", err)
 		return
 	}
 
@@ -117,7 +117,7 @@ func NotificationStatusPost(c *context.Context) {
 func NotificationPurgePost(c *context.Context) {
 	err := models.UpdateNotificationStatuses(c.User, models.NotificationStatusUnread, models.NotificationStatusRead)
 	if err != nil {
-		c.Handle(500, "ErrUpdateNotificationStatuses", err)
+		c.ServerError("ErrUpdateNotificationStatuses", err)
 		return
 	}
 

routers/user/profile.go

@@ -29,9 +29,9 @@ func GetUserByName(ctx *context.Context, name string) *models.User {
 	user, err := models.GetUserByName(name)
 	if err != nil {
 		if models.IsErrUserNotExist(err) {
-			ctx.Handle(404, "GetUserByName", nil)
+			ctx.NotFound("GetUserByName", nil)
 		} else {
-			ctx.Handle(500, "GetUserByName", err)
+			ctx.ServerError("GetUserByName", err)
 		}
 		return nil
 	}
@@ -79,7 +79,7 @@ func Profile(ctx *context.Context) {
 	// Show OpenID URIs
 	openIDs, err := models.GetUserOpenIDs(ctxUser.ID)
 	if err != nil {
-		ctx.Handle(500, "GetUserOpenIDs", err)
+		ctx.ServerError("GetUserOpenIDs", err)
 		return
 	}
 
@@ -91,7 +91,7 @@ func Profile(ctx *context.Context) {
 
 	orgs, err := models.GetOrgsByUserID(ctxUser.ID, showPrivate)
 	if err != nil {
-		ctx.Handle(500, "GetOrgsByUserIDDesc", err)
+		ctx.ServerError("GetOrgsByUserIDDesc", err)
 		return
 	}
 
@@ -147,13 +147,13 @@ func Profile(ctx *context.Context) {
 		if len(keyword) == 0 {
 			repos, err = ctxUser.GetStarredRepos(showPrivate, page, setting.UI.User.RepoPagingNum, orderBy.String())
 			if err != nil {
-				ctx.Handle(500, "GetStarredRepos", err)
+				ctx.ServerError("GetStarredRepos", err)
 				return
 			}
 
 			count, err = ctxUser.GetStarredRepoCount(showPrivate)
 			if err != nil {
-				ctx.Handle(500, "GetStarredRepoCount", err)
+				ctx.ServerError("GetStarredRepoCount", err)
 				return
 			}
 		} else {
@@ -168,7 +168,7 @@ func Profile(ctx *context.Context) {
 				Collaborate: util.OptionalBoolFalse,
 			})
 			if err != nil {
-				ctx.Handle(500, "SearchRepositoryByName", err)
+				ctx.ServerError("SearchRepositoryByName", err)
 				return
 			}
 		}
@@ -181,7 +181,7 @@ func Profile(ctx *context.Context) {
 			var total int
 			repos, err = models.GetUserRepositories(ctxUser.ID, showPrivate, page, setting.UI.User.RepoPagingNum, orderBy.String())
 			if err != nil {
-				ctx.Handle(500, "GetRepositories", err)
+				ctx.ServerError("GetRepositories", err)
 				return
 			}
 			ctx.Data["Repos"] = repos
@@ -191,7 +191,7 @@ func Profile(ctx *context.Context) {
 			} else {
 				count, err := models.GetPublicRepositoryCount(ctxUser)
 				if err != nil {
-					ctx.Handle(500, "GetPublicRepositoryCount", err)
+					ctx.ServerError("GetPublicRepositoryCount", err)
 					return
 				}
 				total = int(count)
@@ -210,7 +210,7 @@ func Profile(ctx *context.Context) {
 				PageSize:  setting.UI.User.RepoPagingNum,
 			})
 			if err != nil {
-				ctx.Handle(500, "SearchRepositoryByName", err)
+				ctx.ServerError("SearchRepositoryByName", err)
 				return
 			}
 
@@ -267,7 +267,7 @@ func Action(ctx *context.Context) {
 	}
 
 	if err != nil {
-		ctx.Handle(500, fmt.Sprintf("Action (%s)", ctx.Params(":action")), err)
+		ctx.ServerError(fmt.Sprintf("Action (%s)", ctx.Params(":action")), err)
 		return
 	}
 

routers/user/setting.go

@@ -73,7 +73,7 @@ func handleUsernameChange(ctx *context.Context, newName string) {
 				ctx.Flash.Error(ctx.Tr("user.newName_pattern_not_allowed"))
 				ctx.Redirect(setting.AppSubURL + "/user/settings")
 			default:
-				ctx.Handle(500, "ChangeUserName", err)
+				ctx.ServerError("ChangeUserName", err)
 			}
 			return
 		}
@@ -111,7 +111,7 @@ func SettingsPost(ctx *context.Context, form auth.UpdateProfileForm) {
 			ctx.Redirect(setting.AppSubURL + "/user/settings")
 			return
 		}
-		ctx.Handle(500, "UpdateUser", err)
+		ctx.ServerError("UpdateUser", err)
 		return
 	}
 
@@ -202,7 +202,7 @@ func SettingsSecurity(ctx *context.Context) {
 		if models.IsErrTwoFactorNotEnrolled(err) {
 			enrolled = false
 		} else {
-			ctx.Handle(500, "SettingsTwoFactor", err)
+			ctx.ServerError("SettingsTwoFactor", err)
 			return
 		}
 	}
@@ -232,12 +232,12 @@ func SettingsSecurityPost(ctx *context.Context, form auth.ChangePasswordForm) {
 		ctx.User.Passwd = form.Password
 		var err error
 		if ctx.User.Salt, err = models.GetUserSalt(); err != nil {
-			ctx.Handle(500, "UpdateUser", err)
+			ctx.ServerError("UpdateUser", err)
 			return
 		}
 		ctx.User.HashPassword()
 		if err := models.UpdateUserCols(ctx.User, "salt", "passwd"); err != nil {
-			ctx.Handle(500, "UpdateUser", err)
+			ctx.ServerError("UpdateUser", err)
 			return
 		}
 		log.Trace("User password updated: %s", ctx.User.Name)
@@ -254,7 +254,7 @@ func SettingsEmails(ctx *context.Context) {
 
 	emails, err := models.GetEmailAddresses(ctx.User.ID)
 	if err != nil {
-		ctx.Handle(500, "GetEmailAddresses", err)
+		ctx.ServerError("GetEmailAddresses", err)
 		return
 	}
 	ctx.Data["Emails"] = emails
@@ -270,7 +270,7 @@ func SettingsEmailPost(ctx *context.Context, form auth.AddEmailForm) {
 	// Make emailaddress primary.
 	if ctx.Query("_method") == "PRIMARY" {
 		if err := models.MakeEmailPrimary(&models.EmailAddress{ID: ctx.QueryInt64("id")}); err != nil {
-			ctx.Handle(500, "MakeEmailPrimary", err)
+			ctx.ServerError("MakeEmailPrimary", err)
 			return
 		}
 
@@ -282,7 +282,7 @@ func SettingsEmailPost(ctx *context.Context, form auth.AddEmailForm) {
 	// Add Email address.
 	emails, err := models.GetEmailAddresses(ctx.User.ID)
 	if err != nil {
-		ctx.Handle(500, "GetEmailAddresses", err)
+		ctx.ServerError("GetEmailAddresses", err)
 		return
 	}
 	ctx.Data["Emails"] = emails
@@ -302,7 +302,7 @@ func SettingsEmailPost(ctx *context.Context, form auth.AddEmailForm) {
 			ctx.RenderWithErr(ctx.Tr("form.email_been_used"), tplSettingsEmails, &form)
 			return
 		}
-		ctx.Handle(500, "AddEmailAddress", err)
+		ctx.ServerError("AddEmailAddress", err)
 		return
 	}
 
@@ -325,7 +325,7 @@ func SettingsEmailPost(ctx *context.Context, form auth.AddEmailForm) {
 // DeleteEmail response for delete user's email
 func DeleteEmail(ctx *context.Context) {
 	if err := models.DeleteEmailAddress(&models.EmailAddress{ID: ctx.QueryInt64("id"), UID: ctx.User.ID}); err != nil {
-		ctx.Handle(500, "DeleteEmail", err)
+		ctx.ServerError("DeleteEmail", err)
 		return
 	}
 	log.Trace("Email address deleted: %s", ctx.User.Name)
@@ -344,14 +344,14 @@ func SettingsKeys(ctx *context.Context) {
 
 	keys, err := models.ListPublicKeys(ctx.User.ID)
 	if err != nil {
-		ctx.Handle(500, "ListPublicKeys", err)
+		ctx.ServerError("ListPublicKeys", err)
 		return
 	}
 	ctx.Data["Keys"] = keys
 
 	gpgkeys, err := models.ListGPGKeys(ctx.User.ID)
 	if err != nil {
-		ctx.Handle(500, "ListGPGKeys", err)
+		ctx.ServerError("ListGPGKeys", err)
 		return
 	}
 	ctx.Data["GPGKeys"] = gpgkeys
@@ -366,14 +366,14 @@ func SettingsKeysPost(ctx *context.Context, form auth.AddKeyForm) {
 
 	keys, err := models.ListPublicKeys(ctx.User.ID)
 	if err != nil {
-		ctx.Handle(500, "ListPublicKeys", err)
+		ctx.ServerError("ListPublicKeys", err)
 		return
 	}
 	ctx.Data["Keys"] = keys
 
 	gpgkeys, err := models.ListGPGKeys(ctx.User.ID)
 	if err != nil {
-		ctx.Handle(500, "ListGPGKeys", err)
+		ctx.ServerError("ListGPGKeys", err)
 		return
 	}
 	ctx.Data["GPGKeys"] = gpgkeys
@@ -398,7 +398,7 @@ func SettingsKeysPost(ctx *context.Context, form auth.AddKeyForm) {
 				ctx.Data["Err_Content"] = true
 				ctx.RenderWithErr(ctx.Tr("settings.gpg_no_key_email_found"), tplSettingsKeys, &form)
 			default:
-				ctx.Handle(500, "AddPublicKey", err)
+				ctx.ServerError("AddPublicKey", err)
 			}
 			return
 		}
@@ -428,7 +428,7 @@ func SettingsKeysPost(ctx *context.Context, form auth.AddKeyForm) {
 				ctx.Data["Err_Title"] = true
 				ctx.RenderWithErr(ctx.Tr("settings.ssh_key_name_used"), tplSettingsKeys, &form)
 			default:
-				ctx.Handle(500, "AddPublicKey", err)
+				ctx.ServerError("AddPublicKey", err)
 			}
 			return
 		}
@@ -474,7 +474,7 @@ func SettingsApplications(ctx *context.Context) {
 
 	tokens, err := models.ListAccessTokens(ctx.User.ID)
 	if err != nil {
-		ctx.Handle(500, "ListAccessTokens", err)
+		ctx.ServerError("ListAccessTokens", err)
 		return
 	}
 	ctx.Data["Tokens"] = tokens
@@ -490,7 +490,7 @@ func SettingsApplicationsPost(ctx *context.Context, form auth.NewAccessTokenForm
 	if ctx.HasError() {
 		tokens, err := models.ListAccessTokens(ctx.User.ID)
 		if err != nil {
-			ctx.Handle(500, "ListAccessTokens", err)
+			ctx.ServerError("ListAccessTokens", err)
 			return
 		}
 		ctx.Data["Tokens"] = tokens
@@ -503,7 +503,7 @@ func SettingsApplicationsPost(ctx *context.Context, form auth.NewAccessTokenForm
 		Name: form.Name,
 	}
 	if err := models.NewAccessToken(t); err != nil {
-		ctx.Handle(500, "NewAccessToken", err)
+		ctx.ServerError("NewAccessToken", err)
 		return
 	}
 
@@ -533,17 +533,17 @@ func SettingsTwoFactorRegenerateScratch(ctx *context.Context) {
 
 	t, err := models.GetTwoFactorByUID(ctx.User.ID)
 	if err != nil {
-		ctx.Handle(500, "SettingsTwoFactor", err)
+		ctx.ServerError("SettingsTwoFactor", err)
 		return
 	}
 
 	if err = t.GenerateScratchToken(); err != nil {
-		ctx.Handle(500, "SettingsTwoFactor", err)
+		ctx.ServerError("SettingsTwoFactor", err)
 		return
 	}
 
 	if err = models.UpdateTwoFactor(t); err != nil {
-		ctx.Handle(500, "SettingsTwoFactor", err)
+		ctx.ServerError("SettingsTwoFactor", err)
 		return
 	}
 
@@ -558,12 +558,12 @@ func SettingsTwoFactorDisable(ctx *context.Context) {
 
 	t, err := models.GetTwoFactorByUID(ctx.User.ID)
 	if err != nil {
-		ctx.Handle(500, "SettingsTwoFactor", err)
+		ctx.ServerError("SettingsTwoFactor", err)
 		return
 	}
 
 	if err = models.DeleteTwoFactorByID(t.ID, ctx.User.ID); err != nil {
-		ctx.Handle(500, "SettingsTwoFactor", err)
+		ctx.ServerError("SettingsTwoFactor", err)
 		return
 	}
 
@@ -585,7 +585,7 @@ func twofaGenerateSecretAndQr(ctx *context.Context) bool {
 			AccountName: ctx.User.Name,
 		})
 		if err != nil {
-			ctx.Handle(500, "SettingsTwoFactor", err)
+			ctx.ServerError("SettingsTwoFactor", err)
 			return false
 		}
 	}
@@ -593,13 +593,13 @@ func twofaGenerateSecretAndQr(ctx *context.Context) bool {
 	ctx.Data["TwofaSecret"] = otpKey.Secret()
 	img, err := otpKey.Image(320, 240)
 	if err != nil {
-		ctx.Handle(500, "SettingsTwoFactor", err)
+		ctx.ServerError("SettingsTwoFactor", err)
 		return false
 	}
 
 	var imgBytes bytes.Buffer
 	if err = png.Encode(&imgBytes, img); err != nil {
-		ctx.Handle(500, "SettingsTwoFactor", err)
+		ctx.ServerError("SettingsTwoFactor", err)
 		return false
 	}
 
@@ -617,11 +617,11 @@ func SettingsTwoFactorEnroll(ctx *context.Context) {
 	t, err := models.GetTwoFactorByUID(ctx.User.ID)
 	if t != nil {
 		// already enrolled
-		ctx.Handle(500, "SettingsTwoFactor", err)
+		ctx.ServerError("SettingsTwoFactor", err)
 		return
 	}
 	if err != nil && !models.IsErrTwoFactorNotEnrolled(err) {
-		ctx.Handle(500, "SettingsTwoFactor", err)
+		ctx.ServerError("SettingsTwoFactor", err)
 		return
 	}
 
@@ -640,11 +640,11 @@ func SettingsTwoFactorEnrollPost(ctx *context.Context, form auth.TwoFactorAuthFo
 	t, err := models.GetTwoFactorByUID(ctx.User.ID)
 	if t != nil {
 		// already enrolled
-		ctx.Handle(500, "SettingsTwoFactor", err)
+		ctx.ServerError("SettingsTwoFactor", err)
 		return
 	}
 	if err != nil && !models.IsErrTwoFactorNotEnrolled(err) {
-		ctx.Handle(500, "SettingsTwoFactor", err)
+		ctx.ServerError("SettingsTwoFactor", err)
 		return
 	}
 
@@ -671,17 +671,17 @@ func SettingsTwoFactorEnrollPost(ctx *context.Context, form auth.TwoFactorAuthFo
 	}
 	err = t.SetSecret(secret)
 	if err != nil {
-		ctx.Handle(500, "SettingsTwoFactor", err)
+		ctx.ServerError("SettingsTwoFactor", err)
 		return
 	}
 	err = t.GenerateScratchToken()
 	if err != nil {
-		ctx.Handle(500, "SettingsTwoFactor", err)
+		ctx.ServerError("SettingsTwoFactor", err)
 		return
 	}
 
 	if err = models.NewTwoFactor(t); err != nil {
-		ctx.Handle(500, "SettingsTwoFactor", err)
+		ctx.ServerError("SettingsTwoFactor", err)
 		return
 	}
 
@@ -698,7 +698,7 @@ func SettingsAccountLinks(ctx *context.Context) {
 
 	accountLinks, err := models.ListAccountLinks(ctx.User)
 	if err != nil {
-		ctx.Handle(500, "ListAccountLinks", err)
+		ctx.ServerError("ListAccountLinks", err)
 		return
 	}
 
@@ -745,7 +745,7 @@ func SettingsDelete(ctx *context.Context) {
 			if models.IsErrUserNotExist(err) {
 				ctx.RenderWithErr(ctx.Tr("form.enterred_invalid_password"), tplSettingsDelete, nil)
 			} else {
-				ctx.Handle(500, "UserSignIn", err)
+				ctx.ServerError("UserSignIn", err)
 			}
 			return
 		}
@@ -759,7 +759,7 @@ func SettingsDelete(ctx *context.Context) {
 				ctx.Flash.Error(ctx.Tr("form.still_has_org"))
 				ctx.Redirect(setting.AppSubURL + "/user/settings/delete")
 			default:
-				ctx.Handle(500, "DeleteUser", err)
+				ctx.ServerError("DeleteUser", err)
 			}
 		} else {
 			log.Trace("Account deleted: %s", ctx.User.Name)
@@ -777,7 +777,7 @@ func SettingsOrganization(ctx *context.Context) {
 	ctx.Data["PageIsSettingsOrganization"] = true
 	orgs, err := models.GetOrgsByUserID(ctx.User.ID, ctx.IsSigned)
 	if err != nil {
-		ctx.Handle(500, "GetOrgsByUserID", err)
+		ctx.ServerError("GetOrgsByUserID", err)
 		return
 	}
 	ctx.Data["Orgs"] = orgs
@@ -792,7 +792,7 @@ func SettingsRepos(ctx *context.Context) {
 
 	var err error
 	if err = ctxUser.GetRepositories(1, setting.UI.User.RepoPagingNum); err != nil {
-		ctx.Handle(500, "GetRepositories", err)
+		ctx.ServerError("GetRepositories", err)
 		return
 	}
 	repos := ctxUser.Repos
@@ -801,12 +801,12 @@ func SettingsRepos(ctx *context.Context) {
 		if repos[i].IsFork {
 			err := repos[i].GetBaseRepo()
 			if err != nil {
-				ctx.Handle(500, "GetBaseRepo", err)
+				ctx.ServerError("GetBaseRepo", err)
 				return
 			}
 			err = repos[i].BaseRepo.GetOwner()
 			if err != nil {
-				ctx.Handle(500, "GetOwner", err)
+				ctx.ServerError("GetOwner", err)
 				return
 			}
 		}

routers/user/setting_openid.go

@@ -30,7 +30,7 @@ func SettingsOpenID(ctx *context.Context) {
 
 	openid, err := models.GetUserOpenIDs(ctx.User.ID)
 	if err != nil {
-		ctx.Handle(500, "GetUserOpenIDs", err)
+		ctx.ServerError("GetUserOpenIDs", err)
 		return
 	}
 	ctx.Data["OpenIDs"] = openid
@@ -46,7 +46,7 @@ func SettingsOpenIDPost(ctx *context.Context, form auth.AddOpenIDForm) {
 	if ctx.HasError() {
 		openid, err := models.GetUserOpenIDs(ctx.User.ID)
 		if err != nil {
-			ctx.Handle(500, "GetUserOpenIDs", err)
+			ctx.ServerError("GetUserOpenIDs", err)
 			return
 		}
 		ctx.Data["OpenIDs"] = openid
@@ -70,7 +70,7 @@ func SettingsOpenIDPost(ctx *context.Context, form auth.AddOpenIDForm) {
 
 	oids, err := models.GetUserOpenIDs(ctx.User.ID)
 	if err != nil {
-		ctx.Handle(500, "GetUserOpenIDs", err)
+		ctx.ServerError("GetUserOpenIDs", err)
 		return
 	}
 	ctx.Data["OpenIDs"] = oids
@@ -100,7 +100,7 @@ func settingsOpenIDVerify(ctx *context.Context) {
 
 	oids, err := models.GetUserOpenIDs(ctx.User.ID)
 	if err != nil {
-		ctx.Handle(500, "GetUserOpenIDs", err)
+		ctx.ServerError("GetUserOpenIDs", err)
 		return
 	}
 	ctx.Data["OpenIDs"] = oids
@@ -121,7 +121,7 @@ func settingsOpenIDVerify(ctx *context.Context) {
 			ctx.RenderWithErr(ctx.Tr("form.openid_been_used", id), tplSettingsOpenID, &auth.AddOpenIDForm{Openid: id})
 			return
 		}
-		ctx.Handle(500, "AddUserOpenID", err)
+		ctx.ServerError("AddUserOpenID", err)
 		return
 	}
 	log.Trace("Associated OpenID %s to user %s", id, ctx.User.Name)
@@ -133,7 +133,7 @@ func settingsOpenIDVerify(ctx *context.Context) {
 // DeleteOpenID response for delete user's openid
 func DeleteOpenID(ctx *context.Context) {
 	if err := models.DeleteUserOpenID(&models.UserOpenID{ID: ctx.QueryInt64("id"), UID: ctx.User.ID}); err != nil {
-		ctx.Handle(500, "DeleteUserOpenID", err)
+		ctx.ServerError("DeleteUserOpenID", err)
 		return
 	}
 	log.Trace("OpenID address deleted: %s", ctx.User.Name)
@@ -147,7 +147,7 @@ func DeleteOpenID(ctx *context.Context) {
 // ToggleOpenIDVisibility response for toggle visibility of user's openid
 func ToggleOpenIDVisibility(ctx *context.Context) {
 	if err := models.ToggleUserOpenIDVisibility(ctx.QueryInt64("id")); err != nil {
-		ctx.Handle(500, "ToggleUserOpenIDVisibility", err)
+		ctx.ServerError("ToggleUserOpenIDVisibility", err)
 		return
 	}