mirror of
https://github.com/go-gitea/gitea
synced 2025-07-04 09:37:19 +00:00
Prevent possible XSS when using jQuery (#18289)
In the case of misuse or misunderstanding from a developer whereby, if `sel` can receive user-controlled data, jQuery `$(sel)` can lead to the creation of a new element. Current usage is using hard-coded selectors in the templates, but nobody prevents that from expanding to user-controlled somehow.
This commit is contained in:
@ -52,14 +52,14 @@ export function initRepoSettingBranches() {
|
||||
initRepoCommonFilterSearchDropdown('.protected-branches .dropdown');
|
||||
$('.enable-protection, .enable-whitelist, .enable-statuscheck').on('change', function () {
|
||||
if (this.checked) {
|
||||
$($(this).data('target')).removeClass('disabled');
|
||||
$.find($(this).data('target')).removeClass('disabled');
|
||||
} else {
|
||||
$($(this).data('target')).addClass('disabled');
|
||||
$.find($(this).data('target')).addClass('disabled');
|
||||
}
|
||||
});
|
||||
$('.disable-whitelist').on('change', function () {
|
||||
if (this.checked) {
|
||||
$($(this).data('target')).addClass('disabled');
|
||||
$.find($(this).data('target')).addClass('disabled');
|
||||
}
|
||||
});
|
||||
}
|
||||
|
Reference in New Issue
Block a user