tdsds.com/gitea
1
1
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2025-07-15 23:17:19 +00:00
Code Releases Activity

Ensure that the testlogger has its final test removal safely (#16907)

Browse Source 
It is possible to get a data race right at the end of the TestMain
in integrations during the final removal of the test from the testlogger. This PR
uses a Reset function to remove any final tests but adds some extra
logging which will forcibly fail if there is an unclosed logger.

Signed-off-by: Andrew Thornton <art27@cantab.net>
This commit is contained in:
zeripath
2021-09-01 14:05:04 +01:00
committed by GitHub
parent de2e96e37b
commit 6e0e414f55
2 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
integrations/integration_test.go
View File

@@ -120,7 +120,7 @@ func TestMain(m *testing.M) {
}
exitCode := m.Run()
writerCloser.t = nil
writerCloser.Reset()
if err = util.RemoveAll(setting.Indexer.IssuePath); err != nil {
fmt.Printf("util.RemoveAll: %v\n", err)