tdsds.com/gitea
1
1
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2025-07-25 03:38:36 +00:00
Code Releases Activity

Dont load Review if Comment is CommentTypeReviewRequest (#28551)

Browse Source 
RequestReview get deleted on review.
So we don't have to try to load them on comments.

broken out #28544
This commit is contained in:
6543
2024-02-13 09:45:31 +01:00
committed by GitHub
parent b85e4a64fa
commit 6fad2c8744
3 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
models/issues/comment_list.go
View File

@@ -430,7 +430,8 @@ func (comments CommentList) loadReviews(ctx context.Context) error {
for _, comment := range comments {
comment.Review = reviews[comment.ReviewID]
if comment.Review == nil {
if comment.ReviewID > 0 {
// review request which has been replaced by actual reviews doesn't exist in database anymore, so don't log errors for them.
if comment.ReviewID > 0 && comment.Type != CommentTypeReviewRequest {
log.Error("comment with review id [%d] but has no review record", comment.ReviewID)
}
continue