tdsds.com/gitea
1
1
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2025-07-23 02:38:35 +00:00
Code Releases Activity

Move some issue methods as functions (#19255)

Browse Source 
* Move some issue methods as functions

* Fix bug
This commit is contained in:
Lunny Xiao
2022-03-29 22:57:33 +08:00
committed by GitHub
parent bd97736b9c
commit 74731c3a5a
19 changed files with 63 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
services/comments/comments.go
View File

@@ -28,7 +28,7 @@ func CreateIssueComment(doer *user_model.User, repo *repo_model.Repository, issu
return nil, err
}
mentions, err := issue.FindAndUpdateIssueMentions(db.DefaultContext, doer, comment.Content)
mentions, err := models.FindAndUpdateIssueMentions(db.DefaultContext, issue, doer, comment.Content)
if err != nil {
return nil, err
}

2
services/issue/assignee.go
View File

@@ -42,7 +42,7 @@ func DeleteNotPassedAssignee(issue *models.Issue, doer *user_model.User, assigne
// ToggleAssignee changes a user between assigned and not assigned for this issue, and make issue comment for it.
func ToggleAssignee(issue *models.Issue, doer *user_model.User, assigneeID int64) (removed bool, comment *models.Comment, err error) {
removed, comment, err = issue.ToggleAssignee(doer, assigneeID)
removed, comment, err = models.ToggleIssueAssignee(issue, doer, assigneeID)
if err != nil {
return
}

2
services/issue/content.go
View File

@@ -14,7 +14,7 @@ import (
func ChangeContent(issue *models.Issue, doer *user_model.User, content string) (err error) {
oldContent := issue.Content
if err := issue.ChangeContent(doer, content); err != nil {
if err := models.ChangeIssueContent(issue, doer, content); err != nil {
return err
}

6
services/issue/issue.go
View File

@@ -28,7 +28,7 @@ func NewIssue(repo *repo_model.Repository, issue *models.Issue, labelIDs []int64
}
}
mentions, err := issue.FindAndUpdateIssueMentions(db.DefaultContext, issue.Poster, issue.Content)
mentions, err := models.FindAndUpdateIssueMentions(db.DefaultContext, issue, issue.Poster, issue.Content)
if err != nil {
return err
}
@@ -49,7 +49,7 @@ func ChangeTitle(issue *models.Issue, doer *user_model.User, title string) (err
oldTitle := issue.Title
issue.Title = title
if err = issue.ChangeTitle(doer, oldTitle); err != nil {
if err = models.ChangeIssueTitle(issue, doer, oldTitle); err != nil {
return
}
@@ -63,7 +63,7 @@ func ChangeIssueRef(issue *models.Issue, doer *user_model.User, ref string) erro
oldRef := issue.Ref
issue.Ref = ref
if err := issue.ChangeRef(doer, oldRef); err != nil {
if err := models.ChangeIssueRef(issue, doer, oldRef); err != nil {
return err
}

4
services/issue/label.go
View File

@@ -12,7 +12,7 @@ import (
// ClearLabels clears all of an issue's labels
func ClearLabels(issue *models.Issue, doer *user_model.User) (err error) {
if err = issue.ClearLabels(doer); err != nil {
if err = models.ClearIssueLabels(issue, doer); err != nil {
return
}
@@ -73,7 +73,7 @@ func ReplaceLabels(issue *models.Issue, doer *user_model.User, labels []*models.
return err
}
if err := issue.ReplaceLabels(labels, doer); err != nil {
if err := models.ReplaceIssueLabels(issue, labels, doer); err != nil {
return err
}

2
services/issue/status.go
View File

@@ -14,7 +14,7 @@ import (
// ChangeStatus changes issue status to open or closed.
func ChangeStatus(issue *models.Issue, doer *user_model.User, closed bool) error {
comment, err := issue.ChangeStatus(doer, closed)
comment, err := models.ChangeIssueStatus(issue, doer, closed)
if err != nil {
if models.IsErrDependenciesLeft(err) && closed {
if err := models.FinishIssueStopwatchIfPossible(db.DefaultContext, doer, issue); err != nil {

2
services/pull/pull.go
View File

@@ -69,7 +69,7 @@ func NewPullRequest(ctx context.Context, repo *repo_model.Repository, pull *mode
return err
}
mentions, err := pull.FindAndUpdateIssueMentions(ctx, pull.Poster, pull.Content)
mentions, err := models.FindAndUpdateIssueMentions(ctx, pull, pull.Poster, pull.Content)
if err != nil {
return err
}

6
services/pull/review.go
View File

@@ -61,7 +61,7 @@ func CreateCodeComment(ctx context.Context, doer *user_model.User, gitRepo *git.
return nil, err
}
mentions, err := issue.FindAndUpdateIssueMentions(ctx, doer, comment.Content)
mentions, err := models.FindAndUpdateIssueMentions(ctx, issue, doer, comment.Content)
if err != nil {
return nil, err
}
@@ -248,7 +248,7 @@ func SubmitReview(ctx context.Context, doer *user_model.User, gitRepo *git.Repos
return nil, nil, err
}
mentions, err := issue.FindAndUpdateIssueMentions(ctx, doer, comm.Content)
mentions, err := models.FindAndUpdateIssueMentions(ctx, issue, doer, comm.Content)
if err != nil {
return nil, nil, err
}
@@ -258,7 +258,7 @@ func SubmitReview(ctx context.Context, doer *user_model.User, gitRepo *git.Repos
for _, lines := range review.CodeComments {
for _, comments := range lines {
for _, codeComment := range comments {
mentions, err := issue.FindAndUpdateIssueMentions(ctx, doer, codeComment.Content)
mentions, err := models.FindAndUpdateIssueMentions(ctx, issue, doer, codeComment.Content)
if err != nil {
return nil, nil, err
}