mirror of
https://github.com/go-gitea/gitea
synced 2025-07-10 04:27:22 +00:00
Fix git client accessing renamed repo (#34034)
Fix #28460 The `reqGitSignIn` is just copied-pasted code (from githtttp.go) and causes the regression bug. Co-authored-by: Giteabot <teabot@gitea.io>
This commit is contained in:
@ -9,6 +9,8 @@ import (
|
||||
"net/url"
|
||||
"testing"
|
||||
|
||||
"code.gitea.io/gitea/modules/setting"
|
||||
"code.gitea.io/gitea/modules/test"
|
||||
"code.gitea.io/gitea/modules/util"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
@ -16,7 +18,10 @@ import (
|
||||
)
|
||||
|
||||
func TestGitSmartHTTP(t *testing.T) {
|
||||
onGiteaRun(t, testGitSmartHTTP)
|
||||
onGiteaRun(t, func(t *testing.T, u *url.URL) {
|
||||
testGitSmartHTTP(t, u)
|
||||
testRenamedRepoRedirect(t)
|
||||
})
|
||||
}
|
||||
|
||||
func testGitSmartHTTP(t *testing.T, u *url.URL) {
|
||||
@ -73,3 +78,21 @@ func testGitSmartHTTP(t *testing.T, u *url.URL) {
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func testRenamedRepoRedirect(t *testing.T) {
|
||||
defer test.MockVariableValue(&setting.Service.RequireSignInView, true)()
|
||||
|
||||
// git client requires to get a 301 redirect response before 401 unauthorized response
|
||||
req := NewRequest(t, "GET", "/user2/oldrepo1/info/refs")
|
||||
resp := MakeRequest(t, req, http.StatusMovedPermanently)
|
||||
redirect := resp.Header().Get("Location")
|
||||
assert.Equal(t, "/user2/repo1/info/refs", redirect)
|
||||
|
||||
req = NewRequest(t, "GET", redirect)
|
||||
resp = MakeRequest(t, req, http.StatusUnauthorized)
|
||||
assert.Equal(t, "Unauthorized\n", resp.Body.String())
|
||||
|
||||
req = NewRequest(t, "GET", redirect).AddBasicAuth("user2")
|
||||
resp = MakeRequest(t, req, http.StatusOK)
|
||||
assert.Contains(t, resp.Body.String(), "65f1bf27bc3bf70f64657658635e66094edbcb4d\trefs/tags/v1.1")
|
||||
}
|
||||
|
Reference in New Issue
Block a user