mirror of
				https://github.com/go-gitea/gitea
				synced 2025-10-31 03:18:24 +00:00 
			
		
		
		
	Less naked returns (#25713)
just a step towards #25655 and some related refactoring
This commit is contained in:
		| @@ -23,25 +23,25 @@ func RecalculateStars(x *xorm.Engine) (err error) { | ||||
|  | ||||
| 	for start := 0; ; start += batchSize { | ||||
| 		users := make([]User, 0, batchSize) | ||||
| 		if err = sess.Limit(batchSize, start).Where("type = ?", 0).Cols("id").Find(&users); err != nil { | ||||
| 			return | ||||
| 		if err := sess.Limit(batchSize, start).Where("type = ?", 0).Cols("id").Find(&users); err != nil { | ||||
| 			return err | ||||
| 		} | ||||
| 		if len(users) == 0 { | ||||
| 			break | ||||
| 		} | ||||
|  | ||||
| 		if err = sess.Begin(); err != nil { | ||||
| 			return | ||||
| 		if err := sess.Begin(); err != nil { | ||||
| 			return err | ||||
| 		} | ||||
|  | ||||
| 		for _, user := range users { | ||||
| 			if _, err = sess.Exec("UPDATE `user` SET num_stars=(SELECT COUNT(*) FROM `star` WHERE uid=?) WHERE id=?", user.ID, user.ID); err != nil { | ||||
| 				return | ||||
| 			if _, err := sess.Exec("UPDATE `user` SET num_stars=(SELECT COUNT(*) FROM `star` WHERE uid=?) WHERE id=?", user.ID, user.ID); err != nil { | ||||
| 				return err | ||||
| 			} | ||||
| 		} | ||||
|  | ||||
| 		if err = sess.Commit(); err != nil { | ||||
| 			return | ||||
| 		if err := sess.Commit(); err != nil { | ||||
| 			return err | ||||
| 		} | ||||
| 	} | ||||
|  | ||||
|   | ||||
		Reference in New Issue
	
	Block a user