1
1
mirror of https://github.com/go-gitea/gitea synced 2025-01-19 06:04:26 +00:00

fix(cache): cache test triggered by non memory cache (#33220)

Change SlowCacheThreshold to 30 milliseconds so it doesn't trigger on
non memory cache

Closes: https://github.com/go-gitea/gitea/issues/33190
Closes: https://github.com/go-gitea/gitea/issues/32657
This commit is contained in:
TheFox0x7 2025-01-11 21:33:43 +01:00 committed by GitHub
parent 5c150ce9b0
commit 8c6d7076b7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 3 deletions

View File

@ -38,9 +38,14 @@ func Init() error {
const ( const (
testCacheKey = "DefaultCache.TestKey" testCacheKey = "DefaultCache.TestKey"
SlowCacheThreshold = 100 * time.Microsecond // SlowCacheThreshold marks cache tests as slow
// set to 30ms per discussion: https://github.com/go-gitea/gitea/issues/33190
// TODO: Replace with metrics histogram
SlowCacheThreshold = 30 * time.Millisecond
) )
// Test performs delete, put and get operations on a predefined key
// returns
func Test() (time.Duration, error) { func Test() (time.Duration, error) {
if defaultCache == nil { if defaultCache == nil {
return 0, fmt.Errorf("default cache not initialized") return 0, fmt.Errorf("default cache not initialized")

View File

@ -43,7 +43,8 @@ func TestTest(t *testing.T) {
elapsed, err := Test() elapsed, err := Test()
assert.NoError(t, err) assert.NoError(t, err)
// mem cache should take from 300ns up to 1ms on modern hardware ... // mem cache should take from 300ns up to 1ms on modern hardware ...
assert.Less(t, elapsed, time.Millisecond) assert.Positive(t, elapsed)
assert.Less(t, elapsed, SlowCacheThreshold)
} }
func TestGetCache(t *testing.T) { func TestGetCache(t *testing.T) {