tdsds.com/gitea
1
1
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2025-11-04 05:18:25 +00:00
Code Releases Activity

Refactor all .length === 0 patterns in JS (#30045)

Browse Source 
This pattern comes of often during review, so let's fix it once and for
all. Did not test, but changes are trivial enough imho.
This commit is contained in:
silverwind
2024-03-25 19:37:55 +01:00
committed by GitHub
parent f73d891fc4
commit 8fe26fb314
14 changed files with 31 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
web_src/js/features/repo-home.js
View File

@@ -153,11 +153,11 @@ export function initRepoTopicBar() {
$.fn.form.settings.rules.validateTopic = function (_values, regExp) {
const $topics = $topicDropdown.children('a.ui.label');
const status = $topics.length === 0 || $topics.last()[0].getAttribute('data-value').match(regExp);
const status = !$topics.length || $topics.last()[0].getAttribute('data-value').match(regExp);
if (!status) {
$topics.last().removeClass('green').addClass('red');
}
return status && $topicDropdown.children('a.ui.label.red').length === 0;
return status && !$topicDropdown.children('a.ui.label.red').length;
};
$topicForm.form({