mirror of
				https://github.com/go-gitea/gitea
				synced 2025-10-31 11:28:24 +00:00 
			
		
		
		
	Backport #15015 Unfortunately there is a subtle problem with recreatetable on postgres which leads to the sequences not being renamed and not being left at 0. Fix #14725 Signed-off-by: Andrew Thornton <art27@cantab.net>
This commit is contained in:
		| @@ -5,10 +5,13 @@ | ||||
| package models | ||||
|  | ||||
| import ( | ||||
| 	"fmt" | ||||
| 	"reflect" | ||||
| 	"regexp" | ||||
| 	"strings" | ||||
| 	"testing" | ||||
|  | ||||
| 	"code.gitea.io/gitea/modules/setting" | ||||
| 	"github.com/stretchr/testify/assert" | ||||
| 	"xorm.io/builder" | ||||
| ) | ||||
| @@ -295,3 +298,61 @@ func FixNullArchivedRepository() (int64, error) { | ||||
| 		IsArchived: false, | ||||
| 	}) | ||||
| } | ||||
|  | ||||
| // CountBadSequences looks for broken sequences from recreate-table mistakes | ||||
| func CountBadSequences() (int64, error) { | ||||
| 	if !setting.Database.UsePostgreSQL { | ||||
| 		return 0, nil | ||||
| 	} | ||||
|  | ||||
| 	sess := x.NewSession() | ||||
| 	defer sess.Close() | ||||
|  | ||||
| 	var sequences []string | ||||
| 	schema := sess.Engine().Dialect().URI().Schema | ||||
|  | ||||
| 	sess.Engine().SetSchema("") | ||||
| 	if err := sess.Table("information_schema.sequences").Cols("sequence_name").Where("sequence_name LIKE 'tmp_recreate__%_id_seq%' AND sequence_catalog = ?", setting.Database.Name).Find(&sequences); err != nil { | ||||
| 		return 0, err | ||||
| 	} | ||||
| 	sess.Engine().SetSchema(schema) | ||||
|  | ||||
| 	return int64(len(sequences)), nil | ||||
| } | ||||
|  | ||||
| // FixBadSequences fixes for broken sequences from recreate-table mistakes | ||||
| func FixBadSequences() error { | ||||
| 	if !setting.Database.UsePostgreSQL { | ||||
| 		return nil | ||||
| 	} | ||||
|  | ||||
| 	sess := x.NewSession() | ||||
| 	defer sess.Close() | ||||
| 	if err := sess.Begin(); err != nil { | ||||
| 		return err | ||||
| 	} | ||||
|  | ||||
| 	var sequences []string | ||||
| 	schema := sess.Engine().Dialect().URI().Schema | ||||
|  | ||||
| 	sess.Engine().SetSchema("") | ||||
| 	if err := sess.Table("information_schema.sequences").Cols("sequence_name").Where("sequence_name LIKE 'tmp_recreate__%_id_seq%' AND sequence_catalog = ?", setting.Database.Name).Find(&sequences); err != nil { | ||||
| 		return err | ||||
| 	} | ||||
| 	sess.Engine().SetSchema(schema) | ||||
|  | ||||
| 	sequenceRegexp := regexp.MustCompile(`tmp_recreate__(\w+)_id_seq.*`) | ||||
|  | ||||
| 	for _, sequence := range sequences { | ||||
| 		tableName := sequenceRegexp.FindStringSubmatch(sequence)[1] | ||||
| 		newSequenceName := tableName + "_id_seq" | ||||
| 		if _, err := sess.Exec(fmt.Sprintf("ALTER SEQUENCE `%s` RENAME TO `%s`", sequence, newSequenceName)); err != nil { | ||||
| 			return err | ||||
| 		} | ||||
| 		if _, err := sess.Exec(fmt.Sprintf("SELECT setval('%s', COALESCE((SELECT MAX(id)+1 FROM `%s`), 1), false)", newSequenceName, tableName)); err != nil { | ||||
| 			return err | ||||
| 		} | ||||
| 	} | ||||
|  | ||||
| 	return sess.Commit() | ||||
| } | ||||
|   | ||||
		Reference in New Issue
	
	Block a user