Direct avatar rendering (#13649)

* Direct avatar rendering

This adds new template helpers for avatar rendering which output image
elements with direct links to avatars which makes them cacheable by the
browsers.

This should be a major performance improvment for pages with many avatars.

* fix avatars of other user's profile pages

* fix top border on user avatar name

* uncircle avatars

* remove old incomplete avatar selector

* use title attribute for name and add it back on blame

* minor refactor

* tweak comments

* fix url path join and adjust test to new result

* dedupe functions

templates/repo/settings/collaboration.tmpl

@@ -13,7 +13,7 @@
 				<div class="item ui grid">
 					<div class="ui five wide column">
 						<a href="{{AppSubUrl}}/{{.Name}}">
-							<img class="ui avatar image" src="{{.RelAvatarLink}}">
+							{{avatar .}}
 							{{.DisplayName}}
 						</a>
 					</div>

templates/repo/settings/lfs_locks.tmpl

@@ -35,7 +35,7 @@
 							</td>
 							<td>
 								<a href="{{AppSubUrl}}/{{$lock.Owner.Name}}">
-									<img class="ui avatar image" src="{{$lock.Owner.RelAvatarLink}}">
+									{{avatar $lock.Owner}}
 									{{$lock.Owner.DisplayName}}
 								</a>
 							</td>

templates/repo/settings/protected_branch.tmpl

@@ -48,7 +48,7 @@
 								<div class="menu">
 									{{range .Users}}
 										<div class="item" data-value="{{.ID}}">
-											<img class="ui mini image" src="{{.RelAvatarLink}}">
+											{{avatar . 28 "mini"}}
 											{{.GetDisplayName}}
 										</div>
 									{{end}}
@@ -98,7 +98,7 @@
 								<div class="menu">
 								{{range .Users}}
 									<div class="item" data-value="{{.ID}}">
-										<img class="ui mini image" src="{{.RelAvatarLink}}">
+										{{avatar . 28 "mini"}}
 									{{.GetDisplayName}}
 									</div>
 								{{end}}
@@ -178,7 +178,7 @@
 								<div class="menu">
 								{{range .Users}}
 									<div class="item" data-value="{{.ID}}">
-										<img class="ui mini image" src="{{.RelAvatarLink}}">
+										{{avatar . 28 "mini"}}
 									{{.GetDisplayName}}
 									</div>
 								{{end}}