mirror of
				https://github.com/go-gitea/gitea
				synced 2025-10-27 01:18:27 +00:00 
			
		
		
		
	remove util.OptionalBool and related functions (#29513)
and migrate affected code _last refactoring bits to replace **util.OptionalBool** with **optional.Option[bool]**_
This commit is contained in:
		| @@ -23,9 +23,9 @@ import ( | ||||
| 	"code.gitea.io/gitea/modules/graceful" | ||||
| 	"code.gitea.io/gitea/modules/log" | ||||
| 	base "code.gitea.io/gitea/modules/migration" | ||||
| 	"code.gitea.io/gitea/modules/optional" | ||||
| 	"code.gitea.io/gitea/modules/structs" | ||||
| 	"code.gitea.io/gitea/modules/test" | ||||
| 	"code.gitea.io/gitea/modules/util" | ||||
|  | ||||
| 	"github.com/stretchr/testify/assert" | ||||
| ) | ||||
| @@ -68,14 +68,14 @@ func TestGiteaUploadRepo(t *testing.T) { | ||||
|  | ||||
| 	milestones, err := db.Find[issues_model.Milestone](db.DefaultContext, issues_model.FindMilestoneOptions{ | ||||
| 		RepoID:   repo.ID, | ||||
| 		IsClosed: util.OptionalBoolFalse, | ||||
| 		IsClosed: optional.Some(false), | ||||
| 	}) | ||||
| 	assert.NoError(t, err) | ||||
| 	assert.Len(t, milestones, 1) | ||||
|  | ||||
| 	milestones, err = db.Find[issues_model.Milestone](db.DefaultContext, issues_model.FindMilestoneOptions{ | ||||
| 		RepoID:   repo.ID, | ||||
| 		IsClosed: util.OptionalBoolTrue, | ||||
| 		IsClosed: optional.Some(true), | ||||
| 	}) | ||||
| 	assert.NoError(t, err) | ||||
| 	assert.Empty(t, milestones) | ||||
| @@ -108,7 +108,7 @@ func TestGiteaUploadRepo(t *testing.T) { | ||||
|  | ||||
| 	issues, err := issues_model.Issues(db.DefaultContext, &issues_model.IssuesOptions{ | ||||
| 		RepoIDs:  []int64{repo.ID}, | ||||
| 		IsPull:   util.OptionalBoolFalse, | ||||
| 		IsPull:   optional.Some(false), | ||||
| 		SortType: "oldest", | ||||
| 	}) | ||||
| 	assert.NoError(t, err) | ||||
|   | ||||
		Reference in New Issue
	
	Block a user