mirror of
				https://github.com/go-gitea/gitea
				synced 2025-10-31 03:18:24 +00:00 
			
		
		
		
	add submodule diff links (#33097)
This adds links to submodules in diffs, similar to the existing link when viewing a repo at a specific commit. It does this by expanding diff parsing to recognize changes to submodules, and find the specific refs that are added, deleted or changed. Related #25888 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
		| @@ -1,42 +1,30 @@ | ||||
| // Copyright 2018 The Gitea Authors. All rights reserved. | ||||
| // Copyright 2024 The Gitea Authors. All rights reserved. | ||||
| // SPDX-License-Identifier: MIT | ||||
|  | ||||
| package git | ||||
|  | ||||
| import ( | ||||
| 	"context" | ||||
| 	"testing" | ||||
|  | ||||
| 	"github.com/stretchr/testify/assert" | ||||
| ) | ||||
|  | ||||
| func TestCommitSubModuleFileGetRefURL(t *testing.T) { | ||||
| 	kases := []struct { | ||||
| 		refURL     string | ||||
| 		prefixURL  string | ||||
| 		parentPath string | ||||
| 		SSHDomain  string | ||||
| 		expect     string | ||||
| 	}{ | ||||
| 		{"git://github.com/user1/repo1", "/", "user1/repo2", "", "http://github.com/user1/repo1"}, | ||||
| 		{"https://localhost/user1/repo1.git", "/", "user1/repo2", "", "https://localhost/user1/repo1"}, | ||||
| 		{"http://localhost/user1/repo1.git", "/", "owner/reponame", "", "http://localhost/user1/repo1"}, | ||||
| 		{"git@github.com:user1/repo1.git", "/", "owner/reponame", "", "http://github.com/user1/repo1"}, | ||||
| 		{"ssh://git@git.zefie.net:2222/zefie/lge_g6_kernel_scripts.git", "/", "zefie/lge_g6_kernel", "", "http://git.zefie.net/zefie/lge_g6_kernel_scripts"}, | ||||
| 		{"git@git.zefie.net:2222/zefie/lge_g6_kernel_scripts.git", "/", "zefie/lge_g6_kernel", "", "http://git.zefie.net/2222/zefie/lge_g6_kernel_scripts"}, | ||||
| 		{"git@try.gitea.io:go-gitea/gitea", "https://try.gitea.io/", "go-gitea/sdk", "", "https://try.gitea.io/go-gitea/gitea"}, | ||||
| 		{"ssh://git@try.gitea.io:9999/go-gitea/gitea", "https://try.gitea.io/", "go-gitea/sdk", "", "https://try.gitea.io/go-gitea/gitea"}, | ||||
| 		{"git://git@try.gitea.io:9999/go-gitea/gitea", "https://try.gitea.io/", "go-gitea/sdk", "", "https://try.gitea.io/go-gitea/gitea"}, | ||||
| 		{"ssh://git@127.0.0.1:9999/go-gitea/gitea", "https://127.0.0.1:3000/", "go-gitea/sdk", "", "https://127.0.0.1:3000/go-gitea/gitea"}, | ||||
| 		{"https://gitea.com:3000/user1/repo1.git", "https://127.0.0.1:3000/", "user/repo2", "", "https://gitea.com:3000/user1/repo1"}, | ||||
| 		{"https://example.gitea.com/gitea/user1/repo1.git", "https://example.gitea.com/gitea/", "", "user/repo2", "https://example.gitea.com/gitea/user1/repo1"}, | ||||
| 		{"https://username:password@github.com/username/repository.git", "/", "username/repository2", "", "https://username:password@github.com/username/repository"}, | ||||
| 		{"somethingbad", "https://127.0.0.1:3000/go-gitea/gitea", "/", "", ""}, | ||||
| 		{"git@localhost:user/repo", "https://localhost/", "user2/repo1", "", "https://localhost/user/repo"}, | ||||
| 		{"../path/to/repo.git/", "https://localhost/", "user/repo2", "", "https://localhost/user/path/to/repo.git"}, | ||||
| 		{"ssh://git@ssh.gitea.io:2222/go-gitea/gitea", "https://try.gitea.io/", "go-gitea/sdk", "ssh.gitea.io", "https://try.gitea.io/go-gitea/gitea"}, | ||||
| 	} | ||||
| func TestCommitSubmoduleLink(t *testing.T) { | ||||
| 	sf := NewCommitSubmoduleFile("git@github.com:user/repo.git", "aaaa") | ||||
|  | ||||
| 	for _, kase := range kases { | ||||
| 		assert.EqualValues(t, kase.expect, getRefURL(kase.refURL, kase.prefixURL, kase.parentPath, kase.SSHDomain)) | ||||
| 	} | ||||
| 	wl := sf.SubmoduleWebLink(context.Background()) | ||||
| 	assert.Equal(t, "https://github.com/user/repo", wl.RepoWebLink) | ||||
| 	assert.Equal(t, "https://github.com/user/repo/commit/aaaa", wl.CommitWebLink) | ||||
|  | ||||
| 	wl = sf.SubmoduleWebLink(context.Background(), "1111") | ||||
| 	assert.Equal(t, "https://github.com/user/repo", wl.RepoWebLink) | ||||
| 	assert.Equal(t, "https://github.com/user/repo/commit/1111", wl.CommitWebLink) | ||||
|  | ||||
| 	wl = sf.SubmoduleWebLink(context.Background(), "1111", "2222") | ||||
| 	assert.Equal(t, "https://github.com/user/repo", wl.RepoWebLink) | ||||
| 	assert.Equal(t, "https://github.com/user/repo/compare/1111...2222", wl.CommitWebLink) | ||||
|  | ||||
| 	wl = (*CommitSubmoduleFile)(nil).SubmoduleWebLink(context.Background()) | ||||
| 	assert.Nil(t, wl) | ||||
| } | ||||
|   | ||||
		Reference in New Issue
	
	Block a user