tdsds.com/gitea
1
1
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2025-07-22 10:18:38 +00:00
Code Releases Activity

tests: add coverage for models migration helpers (#18162)

Browse Source 
They were previously not covered at all, either by integration tests or unit tests.

This PR also fixes a bug where the `num_comments` field was incorrectly set to include all types of comments.

It sets num_closed_issues: 0 as default in milestone unit test fixtures. If they are not set, Incr("num_closed_issues") will be a noop because the field is null.
This commit is contained in:
Aravinth Manivannan
2022-01-03 15:35:01 +00:00
committed by GitHub
parent f499f23039
commit ade41f3f04
3 changed files with 173 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
models/migrate.go
View File

@@ -166,7 +166,7 @@ func InsertIssueComments(comments []*Comment) error {
}
for issueID := range issueIDs {
if _, err := db.Exec(ctx, "UPDATE issue set num_comments = (SELECT count(*) FROM comment WHERE issue_id = ?) WHERE id = ?", issueID, issueID); err != nil {
if _, err := db.Exec(ctx, "UPDATE issue set num_comments = (SELECT count(*) FROM comment WHERE issue_id = ? AND `type`=?) WHERE id = ?", issueID, CommentTypeComment, issueID); err != nil {
return err
}
}