mirror of
https://github.com/go-gitea/gitea
synced 2025-07-22 18:28:37 +00:00
Improve repo commit view (#33877)
Fix #24623 Major changes: 1. Redirect `/owner/repo/blob/*` requests to `/owner/repo/src/commit/*` (like GitHub) 2. Add a "view file diff" link (see screenshot below) 3. Refactor "AssertHTMLElement" to generic, now we can accurately assert existence or number. 4. Add more tests --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: delvh <dev.lh@web.de>
This commit is contained in:
@@ -42,12 +42,13 @@ func (doc *HTMLDoc) GetCSRF() string {
|
||||
return doc.GetInputValueByName("_csrf")
|
||||
}
|
||||
|
||||
// AssertElement check if element by selector exists or does not exist depending on checkExists
|
||||
func (doc *HTMLDoc) AssertElement(t testing.TB, selector string, checkExists bool) {
|
||||
// AssertHTMLElement check if element by selector exists or does not exist depending on checkExists
|
||||
func AssertHTMLElement[T int | bool](t testing.TB, doc *HTMLDoc, selector string, checkExists T) {
|
||||
sel := doc.doc.Find(selector)
|
||||
if checkExists {
|
||||
assert.Equal(t, 1, sel.Length())
|
||||
} else {
|
||||
assert.Equal(t, 0, sel.Length())
|
||||
switch v := any(checkExists).(type) {
|
||||
case bool:
|
||||
assert.Equal(t, v, sel.Length() > 0)
|
||||
case int:
|
||||
assert.Equal(t, v, sel.Length())
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user