CSS navbar and color tweaks (#13609)

* CSS and color tweaks

- Unify navbar-style menus
- Fix admin bar overlapping menu bar
- Fixes file edit comment box
- Fix double border on review box
- Fix review timeline icons

* Many fixes to new-menu and navbar layout enhancements

* misc settings fixes

* navbar tweak

* fix pr tabs

* branch tag and arc color tweaks

templates/user/auth/link_account.tmpl

@@ -2,27 +2,29 @@
 
 <div class="user link-account">
 	<div class="ui secondary pointing tabular top attached borderless menu new-menu navbar">
-		<!-- TODO handle .ShowRegistrationButton once other login bugs are fixed -->
-		<a class="item {{if not .user_exists}}active{{end}}"
-			data-tab="auth-link-signup-tab">
-			{{.i18n.Tr "auth.oauth_signup_tab"}}
-		</a>
-		<a class="item {{if .user_exists}}active{{end}}"
-			data-tab="auth-link-signin-tab">
-			{{.i18n.Tr "auth.oauth_signin_tab"}}
-		</a>
-	</div>
-
-	<div class="ui middle very relaxed page grid">
-		<div class="column">
-			<div class="ui tab {{if not .user_exists}}active{{end}}"
+		<div class="new-menu-inner">
+			<!-- TODO handle .ShowRegistrationButton once other login bugs are fixed -->
+			<a class="item {{if not .user_exists}}active{{end}}"
 				data-tab="auth-link-signup-tab">
-				{{template "user/auth/signup_inner" .}}
-			</div>
-			<div class="ui tab {{if .user_exists}}active{{end}}"
+				{{.i18n.Tr "auth.oauth_signup_tab"}}
+			</a>
+			<a class="item {{if .user_exists}}active{{end}}"
 				data-tab="auth-link-signin-tab">
-				<div class="ui user signin container icon">
-					{{template "user/auth/signin_inner" .}}
+				{{.i18n.Tr "auth.oauth_signin_tab"}}
+			</a>
+		</div>
+
+		<div class="ui middle very relaxed page grid">
+			<div class="column">
+				<div class="ui tab {{if not .user_exists}}active{{end}}"
+					data-tab="auth-link-signup-tab">
+					{{template "user/auth/signup_inner" .}}
+				</div>
+				<div class="ui tab {{if .user_exists}}active{{end}}"
+					data-tab="auth-link-signin-tab">
+					<div class="ui user signin container icon">
+						{{template "user/auth/signin_inner" .}}
+					</div>
 				</div>
 			</div>
 		</div>

templates/user/auth/signin_navbar.tmpl

@@ -1,19 +1,21 @@
 {{if or .EnableOpenIDSignIn .EnableSSPI}}
 <div class="ui secondary pointing tabular top attached borderless menu new-menu navbar">
-	<a class="{{if .PageIsLogin}}active{{end}} item" rel="nofollow" href="{{AppSubUrl}}/user/login">
-		{{.i18n.Tr "auth.login_userpass"}}
-	</a>
-	{{if .EnableOpenIDSignIn}}
-	<a class="{{if .PageIsLoginOpenID}}active{{end}} item" rel="nofollow" href="{{AppSubUrl}}/user/login/openid">
-		<i class="fa fa-openid"></i>
-		&nbsp;OpenID
-	</a>
-	{{end}}
-	{{if .EnableSSPI}}
-	<a class="item" rel="nofollow" href="{{AppSubUrl}}/user/login?auth_with_sspi=1">
-		<i class="fa fa-windows"></i>
-		&nbsp;SSPI
-	</a>
-	{{end}}
+	<div class="new-menu-inner">
+		<a class="{{if .PageIsLogin}}active{{end}} item" rel="nofollow" href="{{AppSubUrl}}/user/login">
+			{{.i18n.Tr "auth.login_userpass"}}
+		</a>
+		{{if .EnableOpenIDSignIn}}
+		<a class="{{if .PageIsLoginOpenID}}active{{end}} item" rel="nofollow" href="{{AppSubUrl}}/user/login/openid">
+			<i class="fa fa-openid"></i>
+			&nbsp;OpenID
+		</a>
+		{{end}}
+		{{if .EnableSSPI}}
+		<a class="item" rel="nofollow" href="{{AppSubUrl}}/user/login?auth_with_sspi=1">
+			<i class="fa fa-windows"></i>
+			&nbsp;SSPI
+		</a>
+		{{end}}
+	</div>
 </div>
 {{end}}

templates/user/auth/signup_openid_navbar.tmpl

@@ -1,11 +1,13 @@
 <div class="ui secondary pointing tabular top attached borderless menu stackable new-menu navbar">
-	<a class="{{if .PageIsOpenIDConnect}}active{{end}} item" href="{{AppSubUrl}}/user/openid/connect">
-		{{.i18n.Tr "auth.openid_connect_title"}}
-	</a>
-	{{if .EnableOpenIDSignUp}}
-		<a class="{{if .PageIsOpenIDRegister}}active{{end}} item" href="{{AppSubUrl}}/user/openid/register">
-			{{.i18n.Tr "auth.openid_register_title"}}
+	<div class="new-menu-inner">
+		<a class="{{if .PageIsOpenIDConnect}}active{{end}} item" href="{{AppSubUrl}}/user/openid/connect">
+			{{.i18n.Tr "auth.openid_connect_title"}}
 		</a>
-	{{end}}
+		{{if .EnableOpenIDSignUp}}
+			<a class="{{if .PageIsOpenIDRegister}}active{{end}} item" href="{{AppSubUrl}}/user/openid/register">
+				{{.i18n.Tr "auth.openid_register_title"}}
+			</a>
+		{{end}}
+	</div>
 </div>
 

templates/user/profile.tmpl

@@ -1,5 +1,5 @@
 {{template "base/head" .}}
-<div class="user profile">
+<div class="user profile mt-5">
 	<div class="ui container">
 		<div class="ui stackable grid">
 			<div class="ui five wide column">

templates/user/settings/navbar.tmpl

@@ -1,23 +1,25 @@
 <div class="ui secondary pointing tabular top attached borderless menu stackable new-menu navbar">
-	<a class="{{if .PageIsSettingsProfile}}active{{end}} item" href="{{AppSubUrl}}/user/settings">
-		{{.i18n.Tr "settings.profile"}}
-	</a>
-	<a class="{{if .PageIsSettingsAccount}}active{{end}} item" href="{{AppSubUrl}}/user/settings/account">
-		{{.i18n.Tr "settings.account"}}
-	</a>
-	<a class="{{if .PageIsSettingsSecurity}}active{{end}} item" href="{{AppSubUrl}}/user/settings/security">
-		{{.i18n.Tr "settings.security"}}
-	</a>
-	<a class="{{if .PageIsSettingsApplications}}active{{end}} item" href="{{AppSubUrl}}/user/settings/applications">
-		{{.i18n.Tr "settings.applications"}}
-	</a>
-	<a class="{{if .PageIsSettingsKeys}}active{{end}} item" href="{{AppSubUrl}}/user/settings/keys">
-		{{.i18n.Tr "settings.ssh_gpg_keys"}}
-	</a>
-	<a class="{{if .PageIsSettingsOrganization}}active{{end}} item" href="{{AppSubUrl}}/user/settings/organization">
-		{{.i18n.Tr "settings.organization"}}
-	</a>
-	<a class="{{if .PageIsSettingsRepos}}active{{end}} item" href="{{AppSubUrl}}/user/settings/repos">
-		{{.i18n.Tr "settings.repos"}}
-	</a>
+	<div class="new-menu-inner">
+		<a class="{{if .PageIsSettingsProfile}}active{{end}} item" href="{{AppSubUrl}}/user/settings">
+			{{.i18n.Tr "settings.profile"}}
+		</a>
+		<a class="{{if .PageIsSettingsAccount}}active{{end}} item" href="{{AppSubUrl}}/user/settings/account">
+			{{.i18n.Tr "settings.account"}}
+		</a>
+		<a class="{{if .PageIsSettingsSecurity}}active{{end}} item" href="{{AppSubUrl}}/user/settings/security">
+			{{.i18n.Tr "settings.security"}}
+		</a>
+		<a class="{{if .PageIsSettingsApplications}}active{{end}} item" href="{{AppSubUrl}}/user/settings/applications">
+			{{.i18n.Tr "settings.applications"}}
+		</a>
+		<a class="{{if .PageIsSettingsKeys}}active{{end}} item" href="{{AppSubUrl}}/user/settings/keys">
+			{{.i18n.Tr "settings.ssh_gpg_keys"}}
+		</a>
+		<a class="{{if .PageIsSettingsOrganization}}active{{end}} item" href="{{AppSubUrl}}/user/settings/organization">
+			{{.i18n.Tr "settings.organization"}}
+		</a>
+		<a class="{{if .PageIsSettingsRepos}}active{{end}} item" href="{{AppSubUrl}}/user/settings/repos">
+			{{.i18n.Tr "settings.repos"}}
+		</a>
+	</div>
 </div>