mirror of
				https://github.com/go-gitea/gitea
				synced 2025-10-31 11:28:24 +00:00 
			
		
		
		
	Backport #28935 by @silverwind The `ToUTF8*` functions were stripping BOM, while BOM is actually valid in UTF8, so the stripping must be optional depending on use case. This does: - Add a options struct to all `ToUTF8*` functions, that by default will strip BOM to preserve existing behaviour - Remove `ToUTF8` function, it was dead code - Rename `ToUTF8WithErr` to `ToUTF8` - Preserve BOM in Monaco Editor - Remove a unnecessary newline in the textarea value. Browsers did ignore it, it seems but it's better not to rely on this behaviour. Fixes: https://github.com/go-gitea/gitea/issues/28743 Related: https://github.com/go-gitea/gitea/issues/6716 which seems to have once introduced a mechanism that strips and re-adds the BOM, but from what I can tell, this mechanism was removed at some point after that PR. Co-authored-by: silverwind <me@silverwind.io>
This commit is contained in:
		| @@ -384,7 +384,7 @@ func Diff(ctx *context.Context) { | ||||
| 			Metas:   ctx.Repo.Repository.ComposeMetas(), | ||||
| 			GitRepo: ctx.Repo.GitRepo, | ||||
| 			Ctx:     ctx, | ||||
| 		}, template.HTMLEscapeString(string(charset.ToUTF8WithFallback(note.Message)))) | ||||
| 		}, template.HTMLEscapeString(string(charset.ToUTF8WithFallback(note.Message, charset.ConvertOpts{})))) | ||||
| 		if err != nil { | ||||
| 			ctx.ServerError("RenderCommitMessage", err) | ||||
| 			return | ||||
|   | ||||
		Reference in New Issue
	
	Block a user