1
1
mirror of https://github.com/go-gitea/gitea synced 2025-07-12 13:37:20 +00:00

Add issue delete notifier (#34592)

Fixes https://github.com/go-gitea/gitea/issues/34591

A reference regarding the deletion of issue webhooks on GitHub:
https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=deleted#issues
This commit is contained in:
badhezi
2025-06-25 21:53:02 +03:00
committed by GitHub
parent 75aa23a665
commit c67a8397ff
5 changed files with 120 additions and 2 deletions

View File

@ -9,6 +9,7 @@ import (
"net/http"
"net/http/httptest"
"net/url"
"path"
"strings"
"testing"
@ -450,6 +451,39 @@ func Test_WebhookIssue(t *testing.T) {
})
}
func Test_WebhookIssueDelete(t *testing.T) {
onGiteaRun(t, func(t *testing.T, giteaURL *url.URL) {
var payloads []api.IssuePayload
var triggeredEvent string
provider := newMockWebhookProvider(func(r *http.Request) {
content, _ := io.ReadAll(r.Body)
var payload api.IssuePayload
err := json.Unmarshal(content, &payload)
assert.NoError(t, err)
payloads = append(payloads, payload)
triggeredEvent = "issue"
}, http.StatusOK)
defer provider.Close()
// 1. create a new webhook with special webhook for repo1
session := loginUser(t, "user2")
testAPICreateWebhookForRepo(t, session, "user2", "repo1", provider.URL(), "issues")
issueURL := testNewIssue(t, session, "user2", "repo1", "Title1", "Description1")
// 2. trigger the webhook
testIssueDelete(t, session, issueURL)
// 3. validate the webhook is triggered
assert.Equal(t, "issue", triggeredEvent)
require.Len(t, payloads, 2)
assert.EqualValues(t, "deleted", payloads[1].Action)
assert.Equal(t, "repo1", payloads[1].Issue.Repo.Name)
assert.Equal(t, "user2/repo1", payloads[1].Issue.Repo.FullName)
assert.Equal(t, "Title1", payloads[1].Issue.Title)
assert.Equal(t, "Description1", payloads[1].Issue.Body)
})
}
func Test_WebhookIssueAssign(t *testing.T) {
onGiteaRun(t, func(t *testing.T, giteaURL *url.URL) {
var payloads []api.PullRequestPayload
@ -596,6 +630,44 @@ func Test_WebhookPullRequest(t *testing.T) {
})
}
func Test_WebhookPullRequestDelete(t *testing.T) {
onGiteaRun(t, func(t *testing.T, giteaURL *url.URL) {
var payloads []api.PullRequestPayload
var triggeredEvent string
provider := newMockWebhookProvider(func(r *http.Request) {
content, _ := io.ReadAll(r.Body)
var payload api.PullRequestPayload
err := json.Unmarshal(content, &payload)
assert.NoError(t, err)
payloads = append(payloads, payload)
triggeredEvent = "pull_request"
}, http.StatusOK)
defer provider.Close()
// 1. create a new webhook with special webhook for repo1
session := loginUser(t, "user2")
testAPICreateWebhookForRepo(t, session, "user2", "repo1", provider.URL(), "pull_request")
testAPICreateBranch(t, session, "user2", "repo1", "master", "master2", http.StatusCreated)
repo1 := unittest.AssertExistsAndLoadBean(t, &repo.Repository{ID: 1})
issueURL := testCreatePullToDefaultBranch(t, session, repo1, repo1, "master2", "first pull request")
// 2. trigger the webhook
testIssueDelete(t, session, path.Join(repo1.Link(), "pulls", issueURL))
// 3. validate the webhook is triggered
assert.Equal(t, "pull_request", triggeredEvent)
require.Len(t, payloads, 2)
assert.EqualValues(t, "deleted", payloads[1].Action)
assert.Equal(t, "repo1", payloads[1].PullRequest.Base.Repository.Name)
assert.Equal(t, "user2/repo1", payloads[1].PullRequest.Base.Repository.FullName)
assert.Equal(t, 0, *payloads[1].PullRequest.Additions)
assert.Equal(t, 0, *payloads[1].PullRequest.ChangedFiles)
assert.Equal(t, 0, *payloads[1].PullRequest.Deletions)
})
}
func Test_WebhookPullRequestComment(t *testing.T) {
onGiteaRun(t, func(t *testing.T, giteaURL *url.URL) {
var payloads []api.IssueCommentPayload