mirror of
https://github.com/go-gitea/gitea
synced 2025-07-07 19:17:21 +00:00
Replace assert.Fail with assert.FailNow (#27578)
assert.Fail() will continue to execute the code while assert.FailNow() not. I thought those uses of assert.Fail() should exit immediately. PS: perhaps it's a good idea to use [require](https://pkg.go.dev/github.com/stretchr/testify/require) somewhere because the assert package's default behavior does not exit when an error occurs, which makes it difficult to find the root error reason.
This commit is contained in:
@ -47,8 +47,7 @@ func checkForConsistency(t assert.TestingT, bean any) {
|
||||
assert.NoError(t, err)
|
||||
f := consistencyCheckMap[tb.Name]
|
||||
if f == nil {
|
||||
assert.Fail(t, "unknown bean type: %#v", bean)
|
||||
return
|
||||
assert.FailNow(t, "unknown bean type: %#v", bean)
|
||||
}
|
||||
f(t, bean)
|
||||
}
|
||||
|
Reference in New Issue
Block a user