tdsds.com/gitea
1
1
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2025-07-09 03:57:19 +00:00
Code Releases Activity

Fix improper HTMLURL usages in Go code (#22839)

Browse Source 
In Go code, HTMLURL should be only used for external systems, like
API/webhook/mail/notification, etc.

If a URL is used by `Redirect` or rendered in a template, it should be a
relative URL (aka `Link()` in Gitea)

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This commit is contained in:
wxiaoguang
2023-02-11 14:34:11 +08:00
committed by GitHub
parent 1cb8d14bf7
commit e9288c2477
17 changed files with 33 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
services/actions/commit_status.go
View File

@ -59,7 +59,7 @@ func CreateCommitStatus(ctx context.Context, job *actions_model.ActionRunJob) er
Creator: creator,
CommitStatus: &git_model.CommitStatus{
SHA: sha,
TargetURL: run.HTMLURL(),
TargetURL: run.Link(),
Description: "",
Context: ctxname,
CreatorID: payload.Pusher.ID,