mirror of
https://github.com/go-gitea/gitea
synced 2025-07-26 04:08:35 +00:00
enforce nolint scope (#34851)
enable nolintlint scope requirement add comments to new directives so it's more obvious why they are in place --- I can also toggle the mandatory comments on if that's something of interest. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>
This commit is contained in:
@@ -224,9 +224,9 @@ func CreateBranch(ctx *context.APIContext) {
|
||||
ctx.APIErrorInternal(err)
|
||||
return
|
||||
}
|
||||
} else if len(opt.OldBranchName) > 0 { //nolint
|
||||
if gitrepo.IsBranchExist(ctx, ctx.Repo.Repository, opt.OldBranchName) { //nolint
|
||||
oldCommit, err = ctx.Repo.GitRepo.GetBranchCommit(opt.OldBranchName) //nolint
|
||||
} else if len(opt.OldBranchName) > 0 { //nolint:staticcheck // deprecated field
|
||||
if gitrepo.IsBranchExist(ctx, ctx.Repo.Repository, opt.OldBranchName) { //nolint:staticcheck // deprecated field
|
||||
oldCommit, err = ctx.Repo.GitRepo.GetBranchCommit(opt.OldBranchName) //nolint:staticcheck // deprecated field
|
||||
if err != nil {
|
||||
ctx.APIErrorInternal(err)
|
||||
return
|
||||
@@ -579,7 +579,7 @@ func CreateBranchProtection(ctx *context.APIContext) {
|
||||
|
||||
ruleName := form.RuleName
|
||||
if ruleName == "" {
|
||||
ruleName = form.BranchName //nolint
|
||||
ruleName = form.BranchName //nolint:staticcheck // deprecated field
|
||||
}
|
||||
if len(ruleName) == 0 {
|
||||
ctx.APIError(http.StatusBadRequest, "both rule_name and branch_name are empty")
|
||||
|
Reference in New Issue
Block a user