More improvements

This commit is contained in:
Lunny Xiao
2024-11-10 13:29:12 -08:00
parent 406884a6f4
commit ed261f1403
7 changed files with 39 additions and 22 deletions
+2 -2
View File
@@ -3166,7 +3166,7 @@ func NewComment(ctx *context.Context) {
ctx.Flash.Info(ctx.Tr("repo.pulls.open_unmerged_pull_exists", pr.Index))
} else {
closeOrReopen := form.Status == "close"
if closeOrReopen {
if closeOrReopen && !issue.IsClosed {
if err := issue_service.CloseIssue(ctx, issue, ctx.Doer, ""); err != nil {
log.Error("CloseIssue: %v", err)
if issues_model.IsErrDependenciesLeft(err) {
@@ -3184,7 +3184,7 @@ func NewComment(ctx *context.Context) {
}
log.Trace("Issue [%d] status changed to closed: %v", issue.ID, issue.IsClosed)
}
} else {
} else if !closeOrReopen && issue.IsClosed {
if err := issue_service.ReopenIssue(ctx, issue, ctx.Doer, ""); err != nil {
log.Error("ReopenIssue: %v", err)
}