tdsds.com/gitea
1
1
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2025-07-23 02:38:35 +00:00
Code Releases Activity

Ensure review dismissal only dismisses the correct review (#15477) (#15489)

Browse Source 
Backport #15477

Fix #15472

Signed-off-by: Andrew Thornton art27@cantab.net

Co-authored-by: 6543 <6543@obermui.de>
This commit is contained in:
zeripath
2021-04-15 16:24:59 +01:00
committed by GitHub
parent 55e6cde7c1
commit edd4ab49c8
2 changed files with 58 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
models/review.go
View File

@@ -566,7 +566,11 @@ func DismissReview(review *Review, isDismiss bool) (err error) {
review.Dismissed = isDismiss
_, err = x.Cols("dismissed").Update(review)
if review.ID == 0 {
return ErrReviewNotExist{}
}
_, err = x.ID(review.ID).Cols("dismissed").Update(review)
return
}