tdsds.com/gitea
1
1
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2025-07-22 18:28:37 +00:00
Code Releases Activity

routers: do not leak secrets via timing side channel (#7364)

Browse Source 
* routers: do not leak secrets via timing side channel

* routers/repo: do not leak secrets via timing side channel
This commit is contained in:
leonklingele
2019-07-06 19:03:13 +02:00
committed by techknowlogick
parent 96b66e330b
commit ef57fe4ae3
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
routers/metrics.go
View File

@@ -5,6 +5,8 @@
package routers
import (
"crypto/subtle"
"github.com/prometheus/client_golang/prometheus/promhttp"
"code.gitea.io/gitea/modules/context"
@@ -22,7 +24,9 @@ func Metrics(ctx *context.Context) {
ctx.Error(401)
return
}
if header != "Bearer "+setting.Metrics.Token {
got := []byte(header)
want := []byte("Bearer " + setting.Metrics.Token)
if subtle.ConstantTimeCompare(got, want) != 1 {
ctx.Error(401)
return
}