mirror of
https://github.com/go-gitea/gitea
synced 2025-07-23 02:38:35 +00:00
Use a variable but a function for IsProd because of a slight performance increment (#17368)
This commit is contained in:
@@ -95,7 +95,7 @@ func (ctx *APIContext) Error(status int, title string, obj interface{}) {
|
||||
if status == http.StatusInternalServerError {
|
||||
log.ErrorWithSkip(1, "%s: %s", title, message)
|
||||
|
||||
if setting.IsProd() && !(ctx.User != nil && ctx.User.IsAdmin) {
|
||||
if setting.IsProd && !(ctx.User != nil && ctx.User.IsAdmin) {
|
||||
message = ""
|
||||
}
|
||||
}
|
||||
@@ -112,7 +112,7 @@ func (ctx *APIContext) InternalServerError(err error) {
|
||||
log.ErrorWithSkip(1, "InternalServerError: %v", err)
|
||||
|
||||
var message string
|
||||
if !setting.IsProd() || (ctx.User != nil && ctx.User.IsAdmin) {
|
||||
if !setting.IsProd || (ctx.User != nil && ctx.User.IsAdmin) {
|
||||
message = err.Error()
|
||||
}
|
||||
|
||||
|
@@ -225,7 +225,7 @@ func (ctx *Context) NotFound(title string, err error) {
|
||||
func (ctx *Context) notFoundInternal(title string, err error) {
|
||||
if err != nil {
|
||||
log.ErrorWithSkip(2, "%s: %v", title, err)
|
||||
if !setting.IsProd() {
|
||||
if !setting.IsProd {
|
||||
ctx.Data["ErrorMsg"] = err
|
||||
}
|
||||
}
|
||||
@@ -261,7 +261,7 @@ func (ctx *Context) ServerError(title string, err error) {
|
||||
func (ctx *Context) serverErrorInternal(title string, err error) {
|
||||
if err != nil {
|
||||
log.ErrorWithSkip(2, "%s: %v", title, err)
|
||||
if !setting.IsProd() {
|
||||
if !setting.IsProd {
|
||||
ctx.Data["ErrorMsg"] = err
|
||||
}
|
||||
}
|
||||
@@ -645,7 +645,7 @@ func Contexter() func(next http.Handler) http.Handler {
|
||||
"CurrentURL": setting.AppSubURL + req.URL.RequestURI(),
|
||||
"PageStartTime": startTime,
|
||||
"Link": link,
|
||||
"IsProd": setting.IsProd(),
|
||||
"IsProd": setting.IsProd,
|
||||
},
|
||||
}
|
||||
// PageData is passed by reference, and it will be rendered to `window.config.pageData` in `head.tmpl` for JavaScript modules
|
||||
|
Reference in New Issue
Block a user