1
1
mirror of https://github.com/go-gitea/gitea synced 2025-07-22 18:28:37 +00:00

Avoid duplicate SetContextValue call (#33564)

And fix FIXME and TODO
This commit is contained in:
wxiaoguang
2025-02-12 14:25:46 +08:00
committed by GitHub
parent 06f1065636
commit f58f5bb3d8
6 changed files with 3 additions and 7 deletions

View File

@@ -87,7 +87,7 @@ func Routes() *web.Router {
// FIXME: it is not right to use context.Contexter here because all routes here should use PrivateContext
// Fortunately, the LFS handlers are able to handle requests without a complete web context
common.AddOwnerRepoGitLFSRoutes(r, func(ctx *context.PrivateContext) {
webContext := &context.Context{Base: ctx.Base}
webContext := &context.Context{Base: ctx.Base} // see above, it shouldn't manually construct the web context
ctx.SetContextValue(context.WebContextKey, webContext) // FIXME: this is not ideal but no other way at the moment
})
})