Improve NuGet API Parity (#21291) (#34940)

Fixes #21291, allowing icons and other missing attributes to appear for
NuGet packages from inside Visual Studio like they do with GitHub Nuget
packages.

Adds additional NuGet package information, particularly `IconURL`, to
bring the Gitea NuGet API more in-line with GitHub's NuGet API.

ref: https://learn.microsoft.com/en-us/nuget/api/search-query-service-resource

routers/api/packages/nuget/api_v3.go

@@ -53,15 +53,23 @@ type RegistrationIndexPageItem struct {
 // https://docs.microsoft.com/en-us/nuget/api/registration-base-url-resource#catalog-entry
 type CatalogEntry struct {
 	CatalogLeafURL           string                    `json:"@id"`
-	PackageContentURL        string                    `json:"packageContent"`
-	ID                       string                    `json:"id"`
-	Version                  string                    `json:"version"`
-	Description              string                    `json:"description"`
-	ReleaseNotes             string                    `json:"releaseNotes"`
 	Authors                  string                    `json:"authors"`
-	RequireLicenseAcceptance bool                      `json:"requireLicenseAcceptance"`
-	ProjectURL               string                    `json:"projectURL"`
+	Copyright                string                    `json:"copyright"`
 	DependencyGroups         []*PackageDependencyGroup `json:"dependencyGroups"`
+	Description              string                    `json:"description"`
+	IconURL                  string                    `json:"iconUrl"`
+	ID                       string                    `json:"id"`
+	IsPrerelease             bool                      `json:"isPrerelease"`
+	Language                 string                    `json:"language"`
+	LicenseURL               string                    `json:"licenseUrl"`
+	PackageContentURL        string                    `json:"packageContent"`
+	ProjectURL               string                    `json:"projectUrl"`
+	RequireLicenseAcceptance bool                      `json:"requireLicenseAcceptance"`
+	Summary                  string                    `json:"summary"`
+	Tags                     string                    `json:"tags"`
+	Version                  string                    `json:"version"`
+	ReleaseNotes             string                    `json:"releaseNotes"`
+	Published                time.Time                 `json:"published"`
 }
 
 // https://docs.microsoft.com/en-us/nuget/api/registration-base-url-resource#package-dependency-group
@@ -109,15 +117,24 @@ func createRegistrationIndexPageItem(l *linkBuilder, pd *packages_model.PackageD
 		RegistrationLeafURL: l.GetRegistrationLeafURL(pd.Package.Name, pd.Version.Version),
 		PackageContentURL:   l.GetPackageDownloadURL(pd.Package.Name, pd.Version.Version),
 		CatalogEntry: &CatalogEntry{
-			CatalogLeafURL:    l.GetRegistrationLeafURL(pd.Package.Name, pd.Version.Version),
-			PackageContentURL: l.GetPackageDownloadURL(pd.Package.Name, pd.Version.Version),
-			ID:                pd.Package.Name,
-			Version:           pd.Version.Version,
-			Description:       metadata.Description,
-			ReleaseNotes:      metadata.ReleaseNotes,
-			Authors:           metadata.Authors,
-			ProjectURL:        metadata.ProjectURL,
-			DependencyGroups:  createDependencyGroups(pd),
+			CatalogLeafURL:           l.GetRegistrationLeafURL(pd.Package.Name, pd.Version.Version),
+			Authors:                  metadata.Authors,
+			Copyright:                metadata.Copyright,
+			DependencyGroups:         createDependencyGroups(pd),
+			Description:              metadata.Description,
+			IconURL:                  metadata.IconURL,
+			ID:                       pd.Package.Name,
+			IsPrerelease:             pd.Version.IsPrerelease(),
+			Language:                 metadata.Language,
+			LicenseURL:               metadata.LicenseURL,
+			PackageContentURL:        l.GetPackageDownloadURL(pd.Package.Name, pd.Version.Version),
+			ProjectURL:               metadata.ProjectURL,
+			RequireLicenseAcceptance: metadata.RequireLicenseAcceptance,
+			Summary:                  metadata.Summary,
+			Tags:                     metadata.Tags,
+			Version:                  pd.Version.Version,
+			ReleaseNotes:             metadata.ReleaseNotes,
+			Published:                pd.Version.CreatedUnix.AsLocalTime(),
 		},
 	}
 }
@@ -145,22 +162,42 @@ func createDependencyGroups(pd *packages_model.PackageDescriptor) []*PackageDepe
 
 // https://docs.microsoft.com/en-us/nuget/api/registration-base-url-resource#registration-leaf
 type RegistrationLeafResponse struct {
-	RegistrationLeafURL  string    `json:"@id"`
-	Type                 []string  `json:"@type"`
-	Listed               bool      `json:"listed"`
-	PackageContentURL    string    `json:"packageContent"`
-	Published            time.Time `json:"published"`
-	RegistrationIndexURL string    `json:"registration"`
+	RegistrationLeafURL  string       `json:"@id"`
+	Type                 []string     `json:"@type"`
+	PackageContentURL    string       `json:"packageContent"`
+	RegistrationIndexURL string       `json:"registration"`
+	CatalogEntry         CatalogEntry `json:"catalogEntry"`
 }
 
 func createRegistrationLeafResponse(l *linkBuilder, pd *packages_model.PackageDescriptor) *RegistrationLeafResponse {
+	registrationLeafURL := l.GetRegistrationLeafURL(pd.Package.Name, pd.Version.Version)
+	packageDownloadURL := l.GetPackageDownloadURL(pd.Package.Name, pd.Version.Version)
+	metadata := pd.Metadata.(*nuget_module.Metadata)
 	return &RegistrationLeafResponse{
-		Type:                 []string{"Package", "http://schema.nuget.org/catalog#Permalink"},
-		Listed:               true,
-		Published:            pd.Version.CreatedUnix.AsLocalTime(),
-		RegistrationLeafURL:  l.GetRegistrationLeafURL(pd.Package.Name, pd.Version.Version),
-		PackageContentURL:    l.GetPackageDownloadURL(pd.Package.Name, pd.Version.Version),
+		RegistrationLeafURL:  registrationLeafURL,
 		RegistrationIndexURL: l.GetRegistrationIndexURL(pd.Package.Name),
+		PackageContentURL:    packageDownloadURL,
+		Type:                 []string{"Package", "http://schema.nuget.org/catalog#Permalink"},
+		CatalogEntry: CatalogEntry{
+			CatalogLeafURL:           registrationLeafURL,
+			Authors:                  metadata.Authors,
+			Copyright:                metadata.Copyright,
+			DependencyGroups:         createDependencyGroups(pd),
+			Description:              metadata.Description,
+			IconURL:                  metadata.IconURL,
+			ID:                       pd.Package.Name,
+			IsPrerelease:             pd.Version.IsPrerelease(),
+			Language:                 metadata.Language,
+			LicenseURL:               metadata.LicenseURL,
+			PackageContentURL:        packageDownloadURL,
+			ProjectURL:               metadata.ProjectURL,
+			RequireLicenseAcceptance: metadata.RequireLicenseAcceptance,
+			Summary:                  metadata.Summary,
+			Tags:                     metadata.Tags,
+			Version:                  pd.Version.Version,
+			ReleaseNotes:             metadata.ReleaseNotes,
+			Published:                pd.Version.CreatedUnix.AsLocalTime(),
+		},
 	}
 }
 
@@ -188,13 +225,24 @@ type SearchResultResponse struct {
 
 // https://docs.microsoft.com/en-us/nuget/api/search-query-service-resource#search-result
 type SearchResult struct {
-	ID                   string                 `json:"id"`
-	Version              string                 `json:"version"`
-	Versions             []*SearchResultVersion `json:"versions"`
-	Description          string                 `json:"description"`
-	Authors              string                 `json:"authors"`
-	ProjectURL           string                 `json:"projectURL"`
-	RegistrationIndexURL string                 `json:"registration"`
+	Authors                  string                    `json:"authors"`
+	Copyright                string                    `json:"copyright"`
+	DependencyGroups         []*PackageDependencyGroup `json:"dependencyGroups"`
+	Description              string                    `json:"description"`
+	IconURL                  string                    `json:"iconUrl"`
+	ID                       string                    `json:"id"`
+	IsPrerelease             bool                      `json:"isPrerelease"`
+	Language                 string                    `json:"language"`
+	LicenseURL               string                    `json:"licenseUrl"`
+	ProjectURL               string                    `json:"projectUrl"`
+	RequireLicenseAcceptance bool                      `json:"requireLicenseAcceptance"`
+	Summary                  string                    `json:"summary"`
+	Tags                     string                    `json:"tags"`
+	Title                    string                    `json:"title"`
+	TotalDownloads           int64                     `json:"totalDownloads"`
+	Version                  string                    `json:"version"`
+	Versions                 []*SearchResultVersion    `json:"versions"`
+	RegistrationIndexURL     string                    `json:"registration"`
 }
 
 // https://docs.microsoft.com/en-us/nuget/api/search-query-service-resource#search-result
@@ -230,11 +278,12 @@ func createSearchResultResponse(l *linkBuilder, totalHits int64, pds []*packages
 func createSearchResult(l *linkBuilder, pds []*packages_model.PackageDescriptor) *SearchResult {
 	latest := pds[0]
 	versions := make([]*SearchResultVersion, 0, len(pds))
+	totalDownloads := int64(0)
 	for _, pd := range pds {
 		if latest.SemVer.LessThan(pd.SemVer) {
 			latest = pd
 		}
-
+		totalDownloads += pd.Version.DownloadCount
 		versions = append(versions, &SearchResultVersion{
 			RegistrationLeafURL: l.GetRegistrationLeafURL(pd.Package.Name, pd.Version.Version),
 			Version:             pd.Version.Version,
@@ -244,12 +293,23 @@ func createSearchResult(l *linkBuilder, pds []*packages_model.PackageDescriptor)
 	metadata := latest.Metadata.(*nuget_module.Metadata)
 
 	return &SearchResult{
-		ID:                   latest.Package.Name,
-		Version:              latest.Version.Version,
-		Versions:             versions,
-		Description:          metadata.Description,
-		Authors:              metadata.Authors,
-		ProjectURL:           metadata.ProjectURL,
-		RegistrationIndexURL: l.GetRegistrationIndexURL(latest.Package.Name),
+		Authors:                  metadata.Authors,
+		Copyright:                metadata.Copyright,
+		Description:              metadata.Description,
+		DependencyGroups:         createDependencyGroups(latest),
+		IconURL:                  metadata.IconURL,
+		ID:                       latest.Package.Name,
+		IsPrerelease:             latest.Version.IsPrerelease(),
+		Language:                 metadata.Language,
+		LicenseURL:               metadata.LicenseURL,
+		ProjectURL:               metadata.ProjectURL,
+		RequireLicenseAcceptance: metadata.RequireLicenseAcceptance,
+		Summary:                  metadata.Summary,
+		Tags:                     metadata.Tags,
+		Title:                    metadata.Title,
+		TotalDownloads:           totalDownloads,
+		Version:                  latest.Version.Version,
+		Versions:                 versions,
+		RegistrationIndexURL:     l.GetRegistrationIndexURL(latest.Package.Name),
 	}
 }