wxiaoguang 
							
						 
					 
					
						
						
							
						
						0141d1667d 
					 
					
						
						
							
							Fix broken Chroma CSS styles ( #23174 )  
						
						... 
						
						
						
						The CSS styles in Gitea themes are out-of-sync of Chroma's styles.
This PR introduces a `chroma-style-diff.go` tool to compare the diff.
The missing CSS styles have been added manually. They are left as empty
to reduce arguments because there was no color for them before.
And this PR fixes  #22348 , with just 2 lines changed: `.chroma .kt & .n`,
these colors are taken from GitHub.
It's good enough for #22348 

---------
Co-authored-by: silverwind <me@silverwind.io > 
						
						
					 
					
						2023-03-09 22:16:16 -05:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						17c8a0523a 
					 
					
						
						
							
							Fix and move "Use this template" button ( #23398 )  
						
						... 
						
						
						
						Before:
<img width="1157" alt="Screenshot 2023-03-09 at 23 21 25"
src="https://user-images.githubusercontent.com/115237/224174168-869966cc-fa59-4231-b449-23bd9db12862.png ">
After:
<img width="1145" alt="Screenshot 2023-03-09 at 23 24 34"
src="https://user-images.githubusercontent.com/115237/224174173-7f5b9c22-44c4-4eed-990c-da49d749eb0e.png ">
---------
Co-authored-by: techknowlogick <techknowlogick@gitea.io > 
						
						
					 
					
						2023-03-09 22:14:45 -05:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
						
						4c59c8c768 
					 
					
						
						
							
							Fix various ImageDiff/SVG bugs ( #23312 )  
						
						... 
						
						
						
						Replace #23310 , Close  #19733 
And fix various UI problems, including regressions from #22959  #22950 
and more.
## SVG Detection
The old regexp may mismatch non-SVG files. This PR adds new tests for
those cases.
## UI Changes
### Before


### After






---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com > 
						
						
					 
					
						2023-03-07 20:11:24 +08:00 
						 
				 
			
				
					
						
							
							
								Hester Gong 
							
						 
					 
					
						
						
							
						
						471b6d24b4 
					 
					
						
						
							
							Fix PR view misalignment caused by long name file ( #23321 )  
						
						... 
						
						
						
						Close  #23248 
The UI after this PR:
https://user-images.githubusercontent.com/17645053/223009758-7f0c9f12-d346-4cb2-a605-729fddce732f.mov  
					
						2023-03-06 09:44:04 -06:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
						
						188c8c12c2 
					 
					
						
						
							
							Make Ctrl+Enter submit a pending comment (starting review) instead of submitting a single comment ( #23245 )  
						
						... 
						
						
						
						Close  #23241 
Before: press Ctrl+Enter in the Code Review Form, a single comment will
be added.
After: press Ctrl+Enter in the Code Review Form, start the review with
pending comments.
The old name `is_review` is not clear, so the new code use
`pending_review` as the new name.
Co-authored-by: delvh <leon@kske.dev >
Co-authored-by: techknowlogick <techknowlogick@gitea.io > 
					
						2023-03-04 02:13:37 -05:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
						
						787a05a3a2 
					 
					
						
						
							
							Fix code wrap for unbroken lines ( #23268 )  
						
						... 
						
						
						
						## The Problem
`overflow-wrap: break-word` doesn't work well for unbroken lines. Use
`overflow-wrap: anywhere` instead, and remove legacy alias `word-wrap`
## Before

## After

---------
Co-authored-by: silverwind <me@silverwind.io > 
						
						
					 
					
						2023-03-03 23:48:59 -05:00 
						 
				 
			
				
					
						
							
							
								Brecht Van Lommel 
							
						 
					 
					
						
						
							
						
						545495dcb0 
					 
					
						
						
							
							Pull Requests: add button to compare force pushed commits ( #22857 )  
						
						... 
						
						
						
						To quickly see what changed without having to re-read the whole diff. 
						
						
					 
					
						2023-03-01 14:19:47 -05:00 
						 
				 
			
				
					
						
							
							
								yp05327 
							
						 
					 
					
						
						
							
						
						6e90a1459b 
					 
					
						
						
							
							Add word-break to sidebar-item-link ( #23146 )  
						
						... 
						
						
						
						Fixes https://github.com/go-gitea/gitea/issues/22953 

Co-authored-by: delvh <leon@kske.dev > 
						
						
					 
					
						2023-02-27 15:19:50 -05:00 
						 
				 
			
				
					
						
							
							
								HesterG 
							
						 
					 
					
						
						
							
						
						d20b29d7ce 
					 
					
						
						
							
							Fix height for sticky head on large screen on PR page ( #23111 )  
						
						... 
						
						
						
						Right now on the PR 'File Change' Tab, the file title header sticky to
the top on large screens has wrong height, resulting in wrong ui
behavior when scrolling down. This PR is to fix this.
Before:
<img width="964" alt="截屏2023-02-24 17 12 29"
src="https://user-images.githubusercontent.com/17645053/221140409-025c4a84-6bbe-4b5b-a13f-bd2b79063522.png ">
After:
<img width="1430" alt="截屏2023-02-24 21 10 12"
src="https://user-images.githubusercontent.com/17645053/221186750-0344d652-4610-4a90-a4c0-7f6269f950d6.png "> 
						
						
					 
					
						2023-02-24 14:29:49 +00:00 
						 
				 
			
				
					
						
							
							
								HesterG 
							
						 
					 
					
						
						
							
						
						8ed6096158 
					 
					
						
						
							
							Add wrapper to author to avoid long name ui problem ( #23030 )  
						
						... 
						
						
						
						This PR is a possible solution for issue #22866 . Main change is to add a
`author-wrapper` class around author name, like the wrapper added to
message. The `max-width` is set to 200px on PC, and 100px on mobile
device for now. 
						
						
					 
					
						2023-02-23 14:28:18 -06:00 
						 
				 
			
				
					
						
							
							
								HesterG 
							
						 
					 
					
						
						
							
						
						3adfc0f02d 
					 
					
						
						
							
							Change style to improve whitespaces trimming inside inline markdown code  ( #23093 )  
						
						... 
						
						
						
						Given mardown source
```
x ` a` y
x `a ` y
x ` a ` y
```
Render
<img width="1421" alt="2023-02-23 15 33 14"
src="https://user-images.githubusercontent.com/17645053/220844280-a304c788-ac79-4a26-a55a-0db00f2fb3f3.png ">
Fixes  #23080 . 
						
						
					 
					
						2023-02-23 20:57:03 +08:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						77f70bd5a3 
					 
					
						
						
							
							Upgrade to stylelint 15 ( #22944 )  
						
						... 
						
						
						
						- Upgrade stylelint and plugin
- Change ruleset to a explicit one, with all deprecated rules removed
- Fix new issues detected by value validation
For `overflow: overlay` see
https://github.com/stylelint/stylelint/issues/6667  
						
						
					 
					
						2023-02-21 09:23:45 -06:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
						
						1fcf96ad01 
					 
					
						
						
							
							Improve PR Review Box UI ( #22986 )  
						
						... 
						
						
						
						This PR follows: 
* #22950 
### Before
The Review Box has many problems:
* It doesn't work for small screens.
* It has an anonying animation which makes the UI laggy.
* It uses "custom dropdown menu" which is very difficult to fine tune.
* `$().toggle('visible')` is not a correct call 
* jQuery just accepts any invalid `duration` argument:
`$().toggle('anyting')`
* The button is not a button.
<details>

</details>
### After
These problems are fixed, and eliminate many `!important` games.
<details>



</details>
And most dropdown icons still looks good:
<details>


</details>
Co-authored-by: delvh <leon@kske.dev > 
						
						
					 
					
						2023-02-21 21:36:53 +08:00 
						 
				 
			
				
					
						
							
							
								HesterG 
							
						 
					 
					
						
						
							
						
						9ebf6424ee 
					 
					
						
						
							
							Remove dashes between organization member avatars on hover ( #23034 )  
						
						... 
						
						
						
						On the home page of an organization, there are unexpected dashes between
the avatars of the members when hovering over the avatars, as shown in
below:


This is because in `fomantic/build/semantic.css` there is a
rule `text-decoration: underline;` when hovering over the `<a>` tag.
Here, the `<a>` tag has width and height because of the avatar image inside,
leading to the unexpected underlines.
This PR overrides the `a:hover` rule so the underline does not exist anymore.
Co-authored-by: delvh <leon@kske.dev > 
						
						
					 
					
						2023-02-21 12:28:31 +01:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
						
						1b950b98cf 
					 
					
						
						
							
							Use gt-relative class instead of the ambiguous gt-pr class  ( #23008 )  
						
						... 
						
						
						
						`.gt-relative` is also `position: relative !important;`
There are `gt-pr-?` styles below (line 140) for `padding-right`, which
makes `.gt-pr` ambiguous
Co-authored-by: delvh <leon@kske.dev >
Co-authored-by: John Olheiser <john.olheiser@gmail.com >
Co-authored-by: techknowlogick <techknowlogick@gitea.io > 
						
						
					 
					
						2023-02-20 19:16:56 -05:00 
						 
				 
			
				
					
						
							
							
								oliverpool 
							
						 
					 
					
						
						
							
						
						3596df52c0 
					 
					
						
						
							
							Fix hidden commit status on multiple checks ( #22889 )  
						
						... 
						
						
						
						Since #22632 , when a commit status has multiple checks, no check is
shown at all (hence no way to see the other checks).
This PR fixes this by always adding a tag with the
`.commit-statuses-trigger` to the DOM (the `.vm` is for vertical
alignment).

---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com > 
						
						
					 
					
						2023-02-20 16:43:04 +08:00 
						 
				 
			
				
					
						
							
							
								Zettat123 
							
						 
					 
					
						
						
							
						
						65fc2d1b83 
					 
					
						
						
							
							Fix avatar misalignment ( #22955 )  
						
						... 
						
						
						
						Fix  #22818 .
|  Before   | After  |
|  ----  | ----  |
| <img
src="https://user-images.githubusercontent.com/15528715/219617504-d86e7a90-d4ac-4a92-bd8a-100dddc693d5.png "
width="200px" /> | <img
src="https://user-images.githubusercontent.com/15528715/219618645-a4045f65-bda6-49ce-a676-f03a9817bb70.png "
width="200px" />|
| <img
src="https://user-images.githubusercontent.com/15528715/219618013-844ef208-853b-44bd-a67c-36e360f0ffa7.png "
width="200px" /> | <img
src="https://user-images.githubusercontent.com/15528715/219618361-cb13c369-852e-47bf-ae30-e429d348823d.png "
width="200px" /> |
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com > 
					
						2023-02-20 07:07:46 +08:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
						
						d32af84a10 
					 
					
						
						
							
							Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none ( #22950 )  
						
						... 
						
						
						
						Close  #22847 
This PR:
* introduce Gitea's own `showElem` and related functions
* remove jQuery show/hide
* remove .hide class
* remove inline style=display:none 
From now on:
do not use:
* "[hidden]" attribute: it's too weak, can not be applied to an element
with "display: flex"
* ".hidden" class: it has been polluted by Fomantic UI in many cases
* inline style="display: none": it's difficult to tweak
* jQuery's show/hide/toggle: it can not show/hide elements with
"display: xxx !important"
only use:
* this ".gt-hidden" class
* showElem/hideElem/toggleElem functions in "utils/dom.js"
cc: @silverwind , this is the all-in-one PR 
					
						2023-02-19 12:06:14 +08:00 
						 
				 
			
				
					
						
							
							
								Brecht Van Lommel 
							
						 
					 
					
						
						
							
						
						6221a6fd54 
					 
					
						
						
							
							Scoped labels ( #22585 )  
						
						... 
						
						
						
						Add a new "exclusive" option per label. This makes it so that when the
label is named `scope/name`, no other label with the same `scope/`
prefix can be set on an issue.
The scope is determined by the last occurence of `/`, so for example
`scope/alpha/name` and `scope/beta/name` are considered to be in
different scopes and can coexist.
Exclusive scopes are not enforced by any database rules, however they
are enforced when editing labels at the models level, automatically
removing any existing labels in the same scope when either attaching a
new label or replacing all labels.
In menus use a circle instead of checkbox to indicate they function as
radio buttons per scope. Issue filtering by label ensures that only a
single scoped label is selected at a time. Clicking with alt key can be
used to remove a scoped label, both when editing individual issues and
batch editing.
Label rendering refactor for consistency and code simplification:
* Labels now consistently have the same shape, emojis and tooltips
everywhere. This includes the label list and label assignment menus.
* In label list, show description below label same as label menus.
* Don't use exactly black/white text colors to look a bit nicer.
* Simplify text color computation. There is no point computing luminance
in linear color space, as this is a perceptual problem and sRGB is
closer to perceptually linear.
* Increase height of label assignment menus to show more labels. Showing
only 3-4 labels at a time leads to a lot of scrolling.
* Render all labels with a new RenderLabel template helper function.
Label creation and editing in multiline modal menu:
* Change label creation to open a modal menu like label editing.
* Change menu layout to place name, description and colors on separate
lines.
* Don't color cancel button red in label editing modal menu.
* Align text to the left in model menu for better readability and
consistent with settings layout elsewhere.
Custom exclusive scoped label rendering:
* Display scoped label prefix and suffix with slightly darker and
lighter background color respectively, and a slanted edge between them
similar to the `/` symbol.
* In menus exclusive labels are grouped with a divider line.
---------
Co-authored-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: Lauris BH <lauris@nix.lv > 
						
						
					 
					
						2023-02-18 21:17:39 +02:00 
						 
				 
			
				
					
						
							
							
								Ferdinand Thiessen 
							
						 
					 
					
						
						
							
						
						8bba7e30b2 
					 
					
						
						
							
							webview: Fix overflowing diff body ( #22959 )  
						
						... 
						
						
						
						If the content is quite large the diff body overflows the container and
can not be read.
This is fixed by setting the diff body maximum width to 100% and enable
overflow scrollbars:
before | after
---|---

|

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de > 
						
						
					 
					
						2023-02-18 09:47:06 +08:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
						
						2e97a77e12 
					 
					
						
						
							
							First step to refactor the .hide to .gt-hidden ( #22916 )  
						
						... 
						
						
						
						A separate PR from #22884  (without touching the jQuery methods) 
						
						
					 
					
						2023-02-16 20:07:21 +08:00 
						 
				 
			
				
					
						
							
							
								Zettat123 
							
						 
					 
					
						
						
							
						
						71ee488098 
					 
					
						
						
							
							Fix dark-colored description text in arc-green theme ( #22908 )  
						
						... 
						
						
						
						Fix  #22873 . 
					
						2023-02-14 13:05:19 -06:00 
						 
				 
			
				
					
						
							
							
								zeripath 
							
						 
					 
					
						
						
							
						
						51383ec084 
					 
					
						
						
							
							Move helpers to be prefixed with gt- ( #22879 )  
						
						... 
						
						
						
						As discussed in #22847  the helpers in helpers.less need to have a
separate prefix as they are causing conflicts with fomantic styles
This will allow us to have the `.gt-hidden { display:none !important; }`
style that is needed to for the reverted PR.
Of note in doing this I have noticed that there was already a conflict
with at least one chroma style which this PR now avoids.
I've also added in the `gt-hidden` style that matches the tailwind one
and switched the code that needed it to use that.
Signed-off-by: Andrew Thornton <art27@cantab.net >
---------
Signed-off-by: Andrew Thornton <art27@cantab.net >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com > 
						
						
					 
					
						2023-02-13 17:59:59 +00:00 
						 
				 
			
				
					
						
							
							
								Jason Song 
							
						 
					 
					
						
						
							
						
						00b18ab42f 
					 
					
						
						
							
							Remove _actions.less ( #22885 )  
						
						... 
						
						
						
						Fix  #22883 .
Revert commit 59beb2dba6 
					
						2023-02-13 08:33:33 -06:00 
						 
				 
			
				
					
						
							
							
								delvh 
							
						 
					 
					
						
						
							
						
						ffa89945d1 
					 
					
						
						
							
							Highlight focused diff file ( #22870 )  
						
						... 
						
						
						
						When a diff file has been focused through the URL ID fragment, it will
be highlighted.


---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com > 
						
						
					 
					
						2023-02-13 18:46:47 +08:00 
						 
				 
			
				
					
						
							
							
								Lunny Xiao 
							
						 
					 
					
						
						
							
						
						00f695da48 
					 
					
						
						
							
							Revert "Fix notification and stopwatch empty states" ( #22876 )  
						
						... 
						
						
						
						Per https://github.com/go-gitea/gitea/pull/22845#issuecomment-1426950234 
Reverts go-gitea/gitea#22845 
Let's have a better PR.
@silverwind @zeripath
Co-authored-by: zeripath <art27@cantab.net > 
						
						
					 
					
						2023-02-12 08:18:07 +00:00 
						 
				 
			
				
					
						
							
							
								gempir 
							
						 
					 
					
						
						
							
						
						e460b6ef4d 
					 
					
						
						
							
							Fix PR file tree folders no longer collapsing ( #22864 )  
						
						... 
						
						
						
						Collapsing folders currently just throws a console error
```
index.js?v=1.19.0~dev-403-gb6b8feb3d:10 TypeError: this.$set is not a function
    at Proxy.handleClick (index.js?v=1.19.0~dev-403-gb6b8feb3d:58:7159)
    at index.js?v=1.19.0~dev-403-gb6b8feb3d:58:6466
    at index.js?v=1.19.0~dev-403-gb6b8feb3d:10:93922
    at ce (index.js?v=1.19.0~dev-403-gb6b8feb3d:10:1472)
    at Q (index.js?v=1.19.0~dev-403-gb6b8feb3d:10:1567)
    at HTMLDivElement.$e (index.js?v=1.19.0~dev-403-gb6b8feb3d:10:79198)
```
This PR fixes this and allows folders to be collapsed again.
Also:
- better cursor interaction with folders
- added some color to the diff detail stats
- remove green link color from all the file names
Screenshots:


---------
Co-authored-by: zeripath <art27@cantab.net >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com > 
						
						
					 
					
						2023-02-12 10:34:46 +08:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						8fa54d0fda 
					 
					
						
						
							
							Fix notification and stopwatch empty states ( #22845 )  
						
						... 
						
						
						
						Previous solution was relying on fomantic selector `.ui.label.hidden` to
hide the elements in their empty state, but this doesn't work any more
with the removal of the `label` class. Instead, introduce a standalone
CSS rule for the `hidden` class, which is universally usable as a single
class.
We can unfortunately not use the existing `hide` class because without
the `!important`, it does not have enough specificity to win against
fomantic's `.ui.menu:not(.vertical) .item {display: flex}` rule.
Followup and fixes regression from
https://github.com/go-gitea/gitea/pull/22169 .
Before:
<img width="98" alt="image"
src="https://user-images.githubusercontent.com/115237/217959380-d3279ff3-526a-4ac4-9a18-3ab7c9ae91dd.png ">
After:
<img width="77" alt="image"
src="https://user-images.githubusercontent.com/115237/217959463-44852716-cb25-4110-8481-668842ad4454.png "> 
						
						
					 
					
						2023-02-11 21:45:58 +00:00 
						 
				 
			
				
					
						
							
							
								Nathaniel Sabanski 
							
						 
					 
					
						
						
							
						
						fb1a2a13f0 
					 
					
						
						
							
							Preview images for Issue cards in Project Board view ( #22112 )  
						
						... 
						
						
						
						Original Issue: https://github.com/go-gitea/gitea/issues/22102 
This addition would be a big benefit for design and art teams using the
issue tracking.
The preview will be the latest "image type" attachments on an issue-
simple, and allows for automatic updates of the cover image as issue
progress is made!
This would make Gitea competitive with Trello... wouldn't it be amazing
to say goodbye to Atlassian products? Ha.
First image is the most recent, the SQL will fetch up to 5 latest images
(URL string).
All images supported by browsers plus upcoming formats: *.avif *.bmp
*.gif *.jpg *.jpeg *.jxl *.png *.svg *.webp
The CSS will try to center-align images until it cannot, then it will
left align with overflow hidden. Single images get to be slightly
larger!
Tested so far on: Chrome, Firefox, Android Chrome, Android Firefox.
Current revision with light and dark themes:


---------
Co-authored-by: Jason Song <i@wolfogre.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: delvh <dev.lh@web.de > 
						
						
					 
					
						2023-02-11 16:12:41 +08:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
						
						affdd40296 
					 
					
						
						
							
							Make issue title edit buttons focusable and fix incorrect ajax requests ( #22807 )  
						
						... 
						
						
						
						Replace #19922  , which is stale since my last review:
https://github.com/go-gitea/gitea/pull/19922#pullrequestreview-1003546506 
and https://github.com/go-gitea/gitea/pull/19922#issuecomment-1153181546 
Close  #19769 
Changes:
1. Use `<button>` instead of `<div>` for buttons
2. Prevent default event handler in `initGlobalButtonClickOnEnter`
3. Fix the incorrect call to `pullrequest_targetbranch_change`
4. Add a slight margin-left to the input element to make UI look better
The logic in repo-issue.js is not ideal, but this PR isn't going to
touch the logic.
This is also an example for future developers to understand how to make
buttons work properly.
### Before

### After
* Add a slight margin-left.
* The `Cancel` button is focused.

Co-authored-by: techknowlogick <techknowlogick@gitea.io > 
						
						
					 
					
						2023-02-09 12:11:16 -05:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						90cf07a2c8 
					 
					
						
						
							
							Improve notification and stopwatch styles ( #22169 )  
						
						... 
						
						
						
						- Add dot-style indicators to notification and time tracker
- Slightly reduce whitespace between right-aligned icons
- Move notification icon to right on mobile
- Switch menu icon to SVG
<img width="270" alt="Screenshot 2022-12-19 at 19 40 32"
src="https://user-images.githubusercontent.com/115237/208496795-ce8734a0-f109-47b7-8eb8-96931e867b23.png ">
<img width="607" alt="Screenshot 2022-12-19 at 19 41 04"
src="https://user-images.githubusercontent.com/115237/208496797-2ff68197-f520-4174-927e-ead15addd63e.png ">
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com > 
						
						
					 
					
						2023-02-09 13:42:18 +08:00 
						 
				 
			
				
					
						
							
							
								ByLCY 
							
						 
					 
					
						
						
							
						
						7baeb9c52a 
					 
					
						
						
							
							Add new captcha: cloudflare turnstile ( #22369 )  
						
						... 
						
						
						
						Added a new captcha(cloudflare turnstile) and its corresponding
document. Cloudflare turnstile official instructions are here:
https://developers.cloudflare.com/turnstile 
Signed-off-by: ByLCY <bylcy@bylcy.dev >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: Jason Song <i@wolfogre.com > 
						
						
					 
					
						2023-02-05 15:29:03 +08:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						c2774d9e80 
					 
					
						
						
							
							Fix color of tertiary button on dark theme ( #22739 )  
						
						... 
						
						
						
						Before:
<img width="266" alt="Screenshot 2023-02-03 at 14 07 34"
src="https://user-images.githubusercontent.com/115237/216611151-92e98305-c4b5-42f3-b2e2-8b1b805fa644.png ">
After:
<img width="271" alt="Screenshot 2023-02-03 at 14 07 52"
src="https://user-images.githubusercontent.com/115237/216611156-878a8a75-39a1-415b-9b6d-4f035985444e.png ">
This is the only instance of such a button in all templates.
---------
Co-authored-by: Lauris BH <lauris@nix.lv >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com > 
						
						
					 
					
						2023-02-04 11:17:43 +08:00 
						 
				 
			
				
					
						
							
							
								Jason Song 
							
						 
					 
					
						
						
							
						
						4011821c94 
					 
					
						
						
							
							Implement actions ( #21937 )  
						
						... 
						
						
						
						Close  #13539 .
Co-authored by: @lunny @appleboy @fuxiaohei and others.
Related projects:
- https://gitea.com/gitea/actions-proto-def 
- https://gitea.com/gitea/actions-proto-go 
- https://gitea.com/gitea/act 
- https://gitea.com/gitea/act_runner 
### Summary
The target of this PR is to bring a basic implementation of "Actions",
an internal CI/CD system of Gitea. That means even though it has been
merged, the state of the feature is **EXPERIMENTAL**, and please note
that:
- It is disabled by default;
- It shouldn't be used in a production environment currently;
- It shouldn't be used in a public Gitea instance currently;
- Breaking changes may be made before it's stable.
**Please comment on #13539  if you have any different product design
ideas**, all decisions reached there will be adopted here. But in this
PR, we don't talk about **naming, feature-creep or alternatives**.
### ⚠️  Breaking
`gitea-actions` will become a reserved user name. If a user with the
name already exists in the database, it is recommended to rename it.
### Some important reviews
- What is `DEFAULT_ACTIONS_URL` in `app.ini` for?
  - https://github.com/go-gitea/gitea/pull/21937#discussion_r1055954954 
- Why the api for runners is not under the normal `/api/v1` prefix?
  - https://github.com/go-gitea/gitea/pull/21937#discussion_r1061173592 
- Why DBFS?
  - https://github.com/go-gitea/gitea/pull/21937#discussion_r1061301178 
- Why ignore events triggered by `gitea-actions` bot?
  - https://github.com/go-gitea/gitea/pull/21937#discussion_r1063254103 
- Why there's no permission control for actions?
  - https://github.com/go-gitea/gitea/pull/21937#discussion_r1090229868 
### What it looks like
<details>
#### Manage runners
<img width="1792" alt="image"
src="https://user-images.githubusercontent.com/9418365/205870657-c72f590e-2e08-4cd4-be7f-2e0abb299bbf.png ">
#### List runs
<img width="1792" alt="image"
src="https://user-images.githubusercontent.com/9418365/205872794-50fde990-2b45-48c1-a178-908e4ec5b627.png ">
#### View logs
<img width="1792" alt="image"
src="https://user-images.githubusercontent.com/9418365/205872501-9b7b9000-9542-4991-8f55-18ccdada77c3.png ">
</details>
### How to try it
<details>
#### 1. Start Gitea
Clone this branch and [install from
source](https://docs.gitea.io/en-us/install-from-source ).
Add additional configurations in `app.ini` to enable Actions:
```ini
[actions]
ENABLED = true
```
Start it.
If all is well, you'll see the management page of runners:
<img width="1792" alt="image"
src="https://user-images.githubusercontent.com/9418365/205877365-8e30a780-9b10-4154-b3e8-ee6c3cb35a59.png ">
#### 2. Start runner
Clone the [act_runner](https://gitea.com/gitea/act_runner ), and follow
the
[README](https://gitea.com/gitea/act_runner/src/branch/main/README.md )
to start it.
If all is well, you'll see a new runner has been added:
<img width="1792" alt="image"
src="https://user-images.githubusercontent.com/9418365/205878000-216f5937-e696-470d-b66c-8473987d91c3.png ">
#### 3. Enable actions for a repo
Create a new repo or open an existing one, check the `Actions` checkbox
in settings and submit.
<img width="1792" alt="image"
src="https://user-images.githubusercontent.com/9418365/205879705-53e09208-73c0-4b3e-a123-2dcf9aba4b9c.png ">
<img width="1792" alt="image"
src="https://user-images.githubusercontent.com/9418365/205879383-23f3d08f-1a85-41dd-a8b3-54e2ee6453e8.png ">
If all is well, you'll see a new tab "Actions":
<img width="1792" alt="image"
src="https://user-images.githubusercontent.com/9418365/205881648-a8072d8c-5803-4d76-b8a8-9b2fb49516c1.png ">
#### 4. Upload workflow files
Upload some workflow files to `.gitea/workflows/xxx.yaml`, you can
follow the [quickstart](https://docs.github.com/en/actions/quickstart )
of GitHub Actions. Yes, Gitea Actions is compatible with GitHub Actions
in most cases, you can use the same demo:
```yaml
name: GitHub Actions Demo
run-name: ${{ github.actor }} is testing out GitHub Actions 🚀 
on: [push]
jobs:
  Explore-GitHub-Actions:
    runs-on: ubuntu-latest
    steps:
      - run: echo "🎉  The job was automatically triggered by a ${{ github.event_name }} event."
      - run: echo "🐧  This job is now running on a ${{ runner.os }} server hosted by GitHub!"
      - run: echo "🔎  The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}."
      - name: Check out repository code
        uses: actions/checkout@v3
      - run: echo "💡  The ${{ github.repository }} repository has been cloned to the runner."
      - run: echo "🖥️  The workflow is now ready to test your code on the runner."
      - name: List files in the repository
        run: |
          ls ${{ github.workspace }}
      - run: echo "🍏  This job's status is ${{ job.status }}."
```
If all is well, you'll see a new run in `Actions` tab:
<img width="1792" alt="image"
src="https://user-images.githubusercontent.com/9418365/205884473-79a874bc-171b-4aaf-acd5-0241a45c3b53.png ">
#### 5. Check the logs of jobs
Click a run and you'll see the logs:
<img width="1792" alt="image"
src="https://user-images.githubusercontent.com/9418365/205884800-994b0374-67f7-48ff-be9a-4c53f3141547.png ">
#### 6. Go on
You can try more examples in [the
documents](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions )
of GitHub Actions, then you might find a lot of bugs.
Come on, PRs are welcome.
</details>
See also: [Feature Preview: Gitea
Actions](https://blog.gitea.io/2022/12/feature-preview-gitea-actions/ )
---------
Co-authored-by: a1012112796 <1012112796@qq.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: delvh <dev.lh@web.de >
Co-authored-by: ChristopherHX <christopher.homberger@web.de >
Co-authored-by: John Olheiser <john.olheiser@gmail.com > 
					
						2023-01-31 09:45:19 +08:00 
						 
				 
			
				
					
						
							
							
								zeripath 
							
						 
					 
					
						
						
							
						
						b8eb282327 
					 
					
						
						
							
							Truncate commit summary on repo files table. ( #22551 )  
						
						... 
						
						
						
						There was an unintended regression in #21124  which assumed that
`.commits-list .message-wrapper` would only match the commit summaries
on `/{owner}/{name}/commits/*`. This assumption is incorrect as the
directory/file view also uses a `.commits-list` wrapper.
Rather than completely restructure this page this PR simply adjusts the
styling to again use `display: inline-block;` for `#repo-files-table
.commit-list .message-wrapper`
Fix  #22360 
Signed-off-by: Andrew Thornton <art27@cantab.net > 
						
						
					 
					
						2023-01-20 23:23:03 +08:00 
						 
				 
			
				
					
						
							
							
								Jason Song 
							
						 
					 
					
						
						
							
						
						4804900ac9 
					 
					
						
						
							
							Load asciicast css async ( #22502 )  
						
						... 
						
						
						
						Load asciicast css asynchronously.
Related to #22448 . 
						
						
					 
					
						2023-01-18 12:19:38 -06:00 
						 
				 
			
				
					
						
							
							
								Jason Song 
							
						 
					 
					
						
						
							
						
						d9f748a700 
					 
					
						
						
							
							Support asciicast files as new markup ( #22448 )  
						
						... 
						
						
						
						Support [asciicast
files](https://github.com/asciinema/asciinema/blob/develop/doc/asciicast-v2.md )
as a new markup via
[asciinema-player](https://github.com/asciinema/asciinema-player ). For
more on asciinema, see the [introduction](https://asciinema.org/ ).
So users can use asciinema recorder to generate an asciicast file (or
you can download a sample file from
https://asciinema.org/a/335480.cast?dl=1 ), then upload it to Gitea and
play it on Gitea.
Snapshots:
<details>
## Upload asciicast files
<img width="1134" alt="image"
src="https://user-images.githubusercontent.com/9418365/212461061-cc2c7181-0e14-4534-af55-1ec60a639fd1.png ">
## Open an asciicast file
<img width="1137" alt="image"
src="https://user-images.githubusercontent.com/9418365/212461090-a3b5141f-4894-430d-a2b4-ea257801a0ed.png ">
## Play it
<img width="1144" alt="image"
src="https://user-images.githubusercontent.com/9418365/212461157-4e82db69-0e41-471d-928f-ac1fe0737105.png ">
## Copy contents from the "video"
<img width="1145" alt="image"
src="https://user-images.githubusercontent.com/9418365/212461286-211612bc-15d6-427a-89a9-6abff5c6a0a5.png ">
## View the source
<img width="1140" alt="image"
src="https://user-images.githubusercontent.com/9418365/212461187-05473b2d-ba3d-4072-84a6-4aa1e7d82182.png ">
</details>
Known issue:
Don't support the [v1 version asciicast
files](https://github.com/asciinema/asciinema/blob/develop/doc/asciicast-v1.md ),
it's a poorly designed version, it does not specify the file extension
and uses `*.json` usually, so it's impossible to recognize the files.
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com > 
						
						
					 
					
						2023-01-18 08:46:58 +08:00 
						 
				 
			
				
					
						
							
							
								zeripath 
							
						 
					 
					
						
						
							
						
						c0da3638e7 
					 
					
						
						
							
							Restore function to "Show more" buttons ( #22399 )  
						
						... 
						
						
						
						There was a serious regression in #21012  which broke the Show More
button on the diff page, and the show more button was also broken on the
file tree too.
This PR fixes this by resetting the pageData.diffFiles as the vue
watched value and reattachs a function to the show more button outside
of the file tree view.
Fix  #22380 
Signed-off-by: Andrew Thornton <art27@cantab.net >
Co-authored-by: John Olheiser <john.olheiser@gmail.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com > 
						
						
					 
					
						2023-01-13 13:50:32 +08:00 
						 
				 
			
				
					
						
							
							
								crystal 
							
						 
					 
					
						
						
							
						
						f1c13b4ace 
					 
					
						
						
							
							improve explore relevancy note ( #22421 )  
						
						... 
						
						
						
						makes the explore relevancy note much prettier on most themes 
						
						
					 
					
						2023-01-12 19:10:12 -06:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						f5cd0d9319 
					 
					
						
						
							
							Add Mermaid copy button, avoid unnecessary tooltip hide ( #22225 )  
						
						... 
						
						
						
						- Add Copy button to mermaid diagrams which copies their source.
- Set tippy to not hide on click and avoid tooltip re-creation for
temporary tooltips. This avoids hide and show when copying repo url.
Popovers still hide the tooltip as usual.
<img width="815" alt="Screenshot 2022-12-23 at 14 02 32"
src="https://user-images.githubusercontent.com/115237/209341696-98e30953-f246-46d9-9157-2ececfd791c9.png ">
Co-authored-by: Lauris BH <lauris@nix.lv >
Co-authored-by: KN4CK3R <admin@oldschoolhack.me > 
						
						
					 
					
						2022-12-25 18:17:48 +01:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						41f0668da8 
					 
					
						
						
							
							Hide file borders on sticky diff box ( #22217 )  
						
						... 
						
						
						
						Before: (1px border left and right when scrolled to a file)
<img width="1143" alt="Screenshot 2022-12-22 at 15 37 54"
src="https://user-images.githubusercontent.com/115237/209158082-c1a413b1-45b7-46b7-a71c-8e5a06324f43.png ">
After: (no border)
<img width="1149" alt="Screenshot 2022-12-22 at 15 39 01"
src="https://user-images.githubusercontent.com/115237/209158086-9b00641f-2f41-4de1-9c08-22230c8a966a.png ">
Layout in the box does not shift with the changes.
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com > 
						
						
					 
					
						2022-12-23 11:58:30 +08:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						c4c4151f7d 
					 
					
						
						
							
							Fix margin and alignment in dashboard repolist ( #22120 )  
						
						... 
						
						
						
						Seems this has recently regressed, previously, there was a significant
whitespace between icon and text, but it seems to be gone, so I added
the margin and also vertically aligned the icon because it was slightly
misaligned.
Before:
<img width="419" alt="Screenshot 2022-12-13 at 20 03 51"
src="https://user-images.githubusercontent.com/115237/207422938-7c45110c-f73e-4344-afc8-c072266d1f95.png ">
After:
<img width="419" alt="image"
src="https://user-images.githubusercontent.com/115237/207447579-95525405-574d-4ca8-84ba-d8a9af50015a.png ">
Co-authored-by: KN4CK3R <admin@oldschoolhack.me > 
						
						
					 
					
						2022-12-17 09:58:57 +08:00 
						 
				 
			
				
					
						
							
							
								Nathaniel Sabanski 
							
						 
					 
					
						
						
							
						
						ae97197404 
					 
					
						
						
							
							Fixed Project view .board-column height for tall screens. ( #22108 )  
						
						... 
						
						
						
						This bug occurs because we are calculating `.board-column` height
strictly off of `vh`, when the layout header is of static height.
BEFORE
https://user-images.githubusercontent.com/24665/206991060-372c24e3-986e-4fc6-9fc8-aab8b4ef09bb.mp4 
AFTER
https://user-images.githubusercontent.com/24665/206991070-91b7cbab-d807-4016-8696-e43bdaf8a7ff.mp4  
						
						
					 
					
						2022-12-14 21:14:50 +00:00 
						 
				 
			
				
					
						
							
							
								Chongyi Zheng 
							
						 
					 
					
						
						
							
						
						a95247b7df 
					 
					
						
						
							
							Fix autofilled text visibility in dark mode ( #22088 )  
						
						... 
						
						
						
						Fixes  #22087  
					
						2022-12-13 19:06:23 +08:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						e2fa84fddc 
					 
					
						
						
							
							Release and Tag List tweaks ( #21712 )  
						
						... 
						
						
						
						- Reduce font size on tag list and add muted links
- Move Release tag to right side on release list
- Move Release edit button to far-right and make it icon-only
- Add styles for error dropdowns, seen on release edit page
- Make the release page slightly more mobile-friendly
<img width="468" alt="Screen Shot 2022-11-07 at 22 10 44"
src="https://user-images.githubusercontent.com/115237/200417500-149f40f5-2376-42b4-92a7-d7eba3ac359d.png ">
<img width="1015" alt="Screen Shot 2022-11-07 at 22 27 14"
src="https://user-images.githubusercontent.com/115237/200419201-b28f39d6-fe9e-4049-8023-b301c9bae528.png ">
<img width="1019" alt="Screen Shot 2022-11-07 at 22 27 27"
src="https://user-images.githubusercontent.com/115237/200419206-3f07d988-42f6-421d-8ba9-303a0d59e711.png ">
<img width="709" alt="Screen Shot 2022-11-07 at 22 42 10"
src="https://user-images.githubusercontent.com/115237/200421671-f0393cde-2d8f-4e1f-a788-f1f51fc4807c.png ">
<img width="713" alt="Screen Shot 2022-11-07 at 22 42 27"
src="https://user-images.githubusercontent.com/115237/200421676-5797f8cf-dfe8-4dd6-85d4-dc69e31a9912.png ">
<img width="406" alt="image"
src="https://user-images.githubusercontent.com/115237/200418220-8c3f7549-61b4-4661-935e-39e1352f7851.png ">
<img width="416" alt="Screen Shot 2022-11-07 at 22 21 36"
src="https://user-images.githubusercontent.com/115237/200418107-cdb0eb6f-1292-469c-b89a-2cb13f24173c.png ">
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com > 
						
						
					 
					
						2022-12-06 21:15:46 +08:00 
						 
				 
			
				
					
						
							
							
								Percy Ma 
							
						 
					 
					
						
						
							
						
						9eb9cf5153 
					 
					
						
						
							
							fix(web): reduce page jitter on browsers that support overlay scrollbar ( #21850 )  
						
						... 
						
						
						
						Reduce jitter caused by the presence or absence of scrollbars in page
switching
---
Ref [scrollbar-gutter |
MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/scrollbar-gutter )
https://user-images.githubusercontent.com/45708948/165972251-7d5a5017-f76d-4ba2-9106-a224b3ee521f.mp4  
						
						
					 
					
						2022-12-04 08:56:10 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						d64063277d 
					 
					
						
						
							
							Multiple improvements for comment edit diff ( #21990 )  
						
						... 
						
						
						
						- Use explicit avatar size so when JS copies the HTML, the size gets
copied with it
- Replace icon font use with SVG
- Improve styling and diff rendering
- Sort lists in `svg.js`
Fixes: https://github.com/go-gitea/gitea/issues/21924 
<img width="933" alt="Screenshot 2022-11-30 at 17 52 17"
src="https://user-images.githubusercontent.com/115237/204859608-f322a8f8-7b91-45e4-87c0-82694e574115.png ">
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: techknowlogick <techknowlogick@gitea.io > 
						
						
					 
					
						2022-12-02 11:42:34 +02:00 
						 
				 
			
				
					
						
							
							
								Percy Ma 
							
						 
					 
					
						
						
							
						
						b91167b772 
					 
					
						
						
							
							fix(web): keep the pages of the navigation in the center ( #21867 )  
						
						... 
						
						
						
						Keep the pages of the navigation in the center
<table>
  <tr>
    <th>Before</th>
    <th>After</th>
  </tr>
  <tr>
    <td>
<img width="200" alt="image"
src="https://user-images.githubusercontent.com/45708948/202838756-d6d57b3f-8144-4a43-a33b-ea7c8ab3a495.png ">
</td>
    <td>
<img width="192" alt="image"
src="https://user-images.githubusercontent.com/45708948/202838740-bbae1e86-b14c-421d-92d4-d0e53d5952a2.png ">
</td>
  </tr>
</table>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: John Olheiser <john.olheiser@gmail.com > 
						
						
					 
					
						2022-11-25 14:37:02 +08:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						b97548a2ee 
					 
					
						
						
							
							Fix table misalignments and tweak webhook and githook lists ( #21917 )  
						
						... 
						
						
						
						- Fix regression from #21893  which had misaligned a few tables like repo
lists and e-mails
- Bring githooks list in line with webhooks list for styling
- Change webhook list icons to just colored dots, like githook list
- Increase size of dot in webhook and githook list from 16 to 22px 
						
						
					 
					
						2022-11-24 00:43:07 -06:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						ee21d5453f 
					 
					
						
						
							
							Move all remaining colors into CSS variables ( #21903 )  
						
						... 
						
						
						
						This should eliminate all non-variable color usage in the styles, making
gitea fully themeable via CSS variables. Also, it adds a linter to
enforce variables for colors. 
						
						
					 
					
						2022-11-23 08:22:27 +08:00